botfuel / botfuel-dialog Goto Github PK

Solution:

• It should have been caught by the tests, investigate it's not

Original request:
Sometime unloggable objects are logged, see #207

It throws the exception "[Run] Converting circular structure to JSON TypeError: Converting circular structure to JSON" and the issue is not caught by the tests. It happened to me a couple of times now (Michel)

We don't want phantom.js to pollute the sdk when we install dependencies.

It is currently used by two dependencies: mocha and charfunk.

It will be removed with the migration to jest for mocha.

We use CharFunk only to look for digit or letter character, we could easily get rid of that.

Hello !

I faced a problem on extractors loading from Botfuel NLU. By default, all JS files into extractors directory are loaded, including files containing parent class.

The problem was that a parent class is loaded and executed while his constructor parameters are required. It returned an error.

I think we just have to improve this regex to allow JS files to not be loaded:

return files.filter(file => file.match(/^.*-extractor.js$/));

So, files without -extractor will not be loaded and allow us to create some-parentextractor.js for example.

Currently many HTML tags are sanitized by sdk, we must define what is open and what is not.
Example: inclusion of an interactive GMaps

Proposal:

Add a webchat client flag that disables all tag filtering.

Hi,

it seems you have accidentally added fs but this is not a package on npmjs, fs is an internal NodeJS module.

https://github.com/Botfuel/botfuel-dialog/blob/master/packages/botfuel-dialog/package.json#L36

See https://nodejs.org/api/fs.html

You might want to remove it using npm uninstall fs.

• Getting started

type:

• postback
• nlu
• dialog manager
• dialog + dialogname

call this property triggeredBy

update docs

Example:

u: I want to travel => travel intent

b:where?

u: travel blah => did not understand

Detect that we are in the same intent as the previous one and that no new information has been added. (check code for reentrant dialog with unclassified sentence)

Use same limits as Facebook Messenger does
We discussed this should be in the service, not in the adapter

Investigate the messages facebook provides.

• If they just return a number, implement the check in sdk messages
• If they return a nice error, implement it in the webchat service and the adapters (webchat+messenger) (log an error)

https://github.com/Botfuel/bot-sdk2/blame/master/src/adapters/botfuel_adapter.js#L21

Is your feature request related to a problem? Please describe.
It's not possible to run Botfuel with node 10, message is :
error [email protected]: The engine "node" is incompatible with this module. Expected version "8.x". Got "10.15.3"

Describe the solution you'd like
I think this project must be already compatible with node 9/10/11, you should just update your "engine" section in package.json to reflect this

Problem is: when SDK sends request to EE, if service is being loaded, SDK gets 503 error.

Solution:
Retry entext in SDK if get 503 error (when the service is being restarted), immediately, 3 times.

Issue:
-when a big utterance is entered, any of our 3 services can crash and crash the bot or UI
-we need to set a common min of 3 services and enforce it

Solution:

SDK TEAM:
1.Make the input length check in the SDK. Don't call the services if message is too long but trigger the complex input dialog. (limit 256 chars)
2. Prevent users from entering long sentences in playgrounds + test panel (same everywhere)

NLP TEAM:
Implement a check on all services that return an error if input is too long (trainer api classify included).

Display warning if I define a helpful warning if for example I mistype something:

Unknown config parameter 'multiItent'. Maybe you meant 'multiIntent'?

Describe the bug
Default view in Spanish is missing

To Reproduce
Just talk to a bot with a phrase not recognised as an intent.

Logs

Mi name is Laura
2018-10-26T11:59:31.288Z - error: [Bot] Could not resolve 'default'
> The following error occured:
> {"stack":"default: Could not find default in: chatbot/src/views/default-view.es.js,

Whatsapp recently launched a business product. https://venturebeat.com/2018/08/01/whatsapp-launches-facebook-chat-ads-and-business-api-for-automated-messaging-with-customers/

What would be involved in creating an adapter for it?

intentFilter() takes a parameter intents that seems to be a list of { value: ..., name: "..."}. However intentFilter() must return a list of string. This is very misleading and in several parts of the SDK, intents can either name a list of string or something else.

Preferably lodash

Could you please add more details regarding 'reentrant' value in the documentation?

If I have an intent (research-operation) with two entities:

• category
• subcategory

subcategories are associated to a specific category, but at some points when we reenter in the dialog with new subcategory or category this new entity don't match this associated subcategory/category and Emmanuel have too update the dialog entities manually in his dialog to make sure that the new entities are associated to the previous matched.

It would be nice to have a new entity hook to be able to update matched entities values so that in this case Emmanuel would be able to reset the previous matched entities if they don't match with the new ones.

Need to discuss how best to do this, preliminary thought is that is should be in the SDK not a module.

onboarding dialog that's called by the webchat or automatically by the dialog manager

Describe the bug
I cam't start the bot on a windows machine in powershell

To Reproduce
The environment variables are not recognised when I try to start the bot using the line found in the back-office

Fix example - test-complexdialogs
Fix SDK
Fix docs

already in test-complexdialogs

• missing view-name.adapter.js resolution

Made this mistake sometimes

Provide the bot developer with the timestamp of the current message and the timestamp of the message just before it

Seems to overlap with ✓ Time stamp in the brain for everything [tech design]