FF Multi Converter does not create a shortcut about pi-apps HOT 15 CLOSED

I've gone ahead and updated the description to say it can be launched from Office. If @Rak1ta replies to say the menu launcher is absent from the Office category, then I can re-open the issue.

As usual, my deepest thanks goes to those involved in relentlessly weeding out all bugs from Pi-Apps. I cannot do this alone as a busy engineering college student.

from pi-apps.

Alright cool.
I'll have to add a checks for the appropriate version when that flag was added. And only add it when necessary.
Thanks

from pi-apps.

Does it show up after a reboot? The code you linked seems to indicate it does install a . desktop file.

from pi-apps.

@theofficialgman yes, I gave a link to install .desktop file. The program works, but there is no shortcut. Rebooting doesn't affect anything for me.

from pi-apps.

I just installed FF Multi Converter and it shows up in Office instead of Accessories as the pi-apps description claims. @Rak1ta, do you see it in Office on your system?

from pi-apps.

@Botspot I'm missing a shortcut. It is not available as a .desktop file either.

from pi-apps.

@Rak1ta, please run this command:

file /usr/local/share/applications/ffmulticonverter.desktop

from pi-apps.

And this:

file /usr/local/share/applications

from pi-apps.

I can reproduce the issue. For some reason the binary is installed (/usr/local/bin/ffmulticonverter) but the .desktop file is nowhere to be found.
Tested on Bookworm ARM64
The folder /usr/local/share/applications already existed on my system even, so it isn't like it failed to place the file there because the folder did not previously exist.

I'm not super familiar with python distutils but it has to do with that https://docs.python.org/3.11/distutils/setupscript.html#installing-additional-files. Everything looks good to me so idk whats wrong.

from pi-apps.

Seems like Bookworm is the difference here. I'm still on Bullseye.

from pi-apps.

yeah this is a setuptools bug.... not sure who it needs to be reported to. it is simply ignoring the data_files entirely. We know setup.py is deprecated but its not supposed to be broken...

from pi-apps.

can also confirm the issue on ubuntu mantic (also on python 3.11). so this definitely seems like a regression from 3.9 -> 3.11 regarding setuptools

from pi-apps.

@Botspot found the change and found the fix
python changed to installing data_files to egg /usr/local/lib/python3.11/dist-packages/ffmulticonverter-1.8.0-py3.11.egg/

now you have to pass --old-and-unmanageable to have the old expected results
https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#data-files

sudo python3 setup.py install --old-and-unmanageable

does that run on bullseye without an error? because I will add it to the script if bullseye does not care even if it does not use it

from pi-apps.

@Botspot found the change and found the fix python changed to installing data_files to egg /usr/local/lib/python3.11/dist-packages/ffmulticonverter-1.8.0-py3.11.egg/

now you have to pass --old-and-unmanageable to have the old expected results https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#data-files

sudo python3 setup.py install --old-and-unmanageable

does that run on bullseye without an error? because I will add it to the script if bullseye does not care even if it does not use it

No it fails.

Errors:
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: setup.py --help [cmd1 cmd2 ...]
   or: setup.py --help-commands
   or: setup.py cmd --help

error: option --old-and-unmanageable not recognized

from pi-apps.

Just to be clear, I changed line 8 in the install script to include this:

sudo python3 setup.py install --old-and-unmanageable

from pi-apps.