bowtieworks / automerge_orm Goto Github PK

Since the EntityRepository is Clone, you could remove the Arc around the EntityManager and instead make it Clone as well, since the DocHandle is Clone.

Besides removing the arc, if you were ever to start using DocHandle.changed somewhere, you would get what I think is a more intuitive kind of result than if you were to use the same refcounted doc handle everywhere: with the current setup it could lead to some updates apparently not propagating(because each doc handle keeps track of the latest state it has seen, and the arc would make this a single global thing as opposed to a local thing, see this note).