bozoh / moodle-block_simple_certificate Goto Github PK

https://moodle.org/mod/forum/discuss.php?d=323803#p1498248

Hi...

In view.php, the user id is not validated and it is a request parameter. A user can get the certificate list for any other user changing the uid param by get.
$uid = required_param('uid', PARAM_INT);

It is a bug or a feature?
In the block content, the userid is from the session user.
$certs = self::get_issued_certificates($USER->id, $COURSE->id);

Besides, in mod/simplecertificate/wmsendfile.php the user is validated and the certificatecopy marker is added when the current user is different to the certificate user, however, the personal information is into the certificate. A user can get many certificates changing values into the URL, including guest users.

Can I change this and submit the correction? or
Do you want to keep it that way?

Saludos

Invalid get_string() identifier: 'simple_certificate:addinstance' or component 'block_simple_certificate'.
Perhaps you are missing
    $string['simple_certificate:addinstance'] = '...';
in .../blocks/simple_certificate/lang/en/block_simple_certificate.php?

I guess the same applies for the other capability simple_certificate:myaddinstance

The class simple_certificate_tree violates the naming conventions - see https://docs.moodle.org/dev/Plugin_contribution_checklist#Namespace-collisions

Better to use Moodle class autoloading mechanism that would implicitly "force" you to name the class correctly.

Hi Carlos,

The block was working really well, but now that I install the new upgrade in M3.1 I got the following errors when I click on an issued certificate from the block.

and I'm using the latest version of mod simple certificate 2.2.6 (2017091800)

Thanks!