bpc-exchange-framework / e-invoice-onboarding-toolkit Goto Github PK

Hey so I started doing some light review of the code and I have some suggestions:

• We don't need to replicate the MIT license in each file since it's already in the LICENSE file at the root.
  Unless we are using multiple licenses? It's quite confusing and unnecessary.
• The folder structure is super confusing. What is the idea behind e-Invoice/src/einvoice?
• We want to follow python PEP8 style guide: https://pep8.org/
• PEP8 indicates (https://pep8.org/#constants) ALLCAPS signifies a constant value. So the SMLURN class is confusing, can this be renamed to SMLUrn or something?
• PEP8 suggests (https://pep8.org/#function-names) we should follow either def snake_case or def camelCase for class methods but not both within the same project ex: createSMLookup. Can we pick one and stick with it? I prefer def snake_case.
• Generally we want to avoid prefixing filenames or variable names...so the ei_file1.py naming really does not add anything. You will always do import xxx from xxx anyways and you can use import xxx from module_yyy as yyy_xxx if you really need to distinguish, so prefixing is not useful in python 3. Can we rename the ei_* files?