bpmn-io / table-js Goto Github PK

Related to bpmn-io/dmn-js#8

Are there any docs or examples for how to use this and what it does?

Can you add integrations with https://github.com/bpmn-io/diagram-js

Is your feature request related to a problem? Please describe

Like we have in diagram.js, it would make sense to have a getGraphics functionality for the ElementRegistry in table-js.

From an APIs perspective, it would be nice to have this aligned in all core libraries. I humbled over this while implementing test cases inside dmn-js-decision-table and get the DOM node from an element.

Describe the solution you'd like

Implement ElementRegistry#getGraphics to return a SVGElement oder a DOMNode.

Describe alternatives you've considered

Do nothing because it's not feasible.

Additional context

diagram.js Implementation

Hi!

I found an issue in case of Hungarian keyboard layout (or can be other layout too).
When user would like to type greater than sign '>' (AltGr + Y) e.g. in DMN advanced mode, then it is not typing '>' instead redo function occurs.

The problem is that in some type of language keyboard layout there is an AltGr key which fires both altKey and ctrlKey (command key) in Javascript.

The bug located in lib/features/keyboard/Keyboard.js:205
Which looks like the following:

function isCmd(modifiers) {
  return modifiers.ctrlKey || modifiers.metaKey;
}

But it should look like this:

function isCmd(modifiers) {
  return !modifiers.altKey && (modifiers.ctrlKey || modifiers.metaKey);
}

Note:
I found several Keyboard module in different bpmn.io projects, so if you agree with the above solution then it should implement in those Keyboard modules also (or not) (or standardize Keyboard.js because it looks like code duplication).

Thank you,
Best regards,
Rómeó Nagy

Reproduce:

1. Register for changes of an element with ID foo
2. Change ID to bar
3. Change element resulting in elements.changed being fired

Expected behavior:

1. As someone having registered for changes to the element I will be notified even if the ID changed

Actual behavior:

1. No notification

Related to bpmn-io/dmn-js#367.

• componentDidUpdate not called anymore

The context menu is positioned automatically depending on how much space there is on the screen. There should be an option for disabling that automatic positioning.

Related to bpmn-io/dmn-js#526

table-js performs poorly when dealing with >500 rows which sometimes is required. This is due to the core architecture of the library which was not designed with performance in mind. Therefore a rewrite of the library is more promising than trying to tweak the current architecture for better performance.

The selection feature currently only lets you directly editable cells. Complex cells and other types of cells can't be selected and there is no selection change when clicking them, therefore there are also no events fired. The selection feature is therefore not consistent.