bpoplauschi / bpforms Goto Github PK

Hello,

1. I want to say that you make a good job :)
2. I think selectionStyle of BPFormInfoCell should always be set to UITableViewCellSelectionStyleNone.
3. why my own BPFormInfoCell (infoCell) disaper when I tap BPFormInputTextFieldCell (password2Cell) which is above?
   self.formCells = @[@[nameCell, emailCell, passwordCell, password2Cell, infoCell, signUpCell]];
   I think you automaticly hide (remove) next cell if it is BPFormInfoCell but I'm not sure it is OK or not.
   I resolved this problem:
   self.formCells = @[@[nameCell, emailCell, passwordCell, password2Cell], @[infoCell, signUpCell]];
   but now I have empty space between password2Cell and infoCell.

Crash in BPFormViewController allCellsAreValid

Fatal Exception: NSInvalidArgumentException
-[BPFormInfoCell validationState]: unrecognized selector sent to instance

Sample crash here

Noticed this message while running a form:

BPFormFloatLabelTextField -webView called. This method is no longer supported with the new text architecture

I guess some change is in order to avoid using deprecated calls.

Hi,

I was wondering if you could provide some info on the necessary basics needed to make our own FormInputCells?

Thanks!

Do you think it would be technically possible to rewrite BPForms to use an UIStackView internally? I think about trying to do it due to some issues with dynamic height and having several model objects to be displayed in one row.

In iOS 7 the keyboard is semi-transparent. BPForms resizes the tableview when the keyboard appears. This makes the Keyboard look transparent until it completely appeared, then the background color jump-animates to the view's background color.

Wouldn't it be possible to just set the tableview's contentInset and scrollIndicatorInsets instead of resizing the scroll view?

I run app though TAPKeyboardPopExample.xcodeproj and get errors:

diff: /../Podfile.lock: No such file or directory
diff: /Manifest.lock: No such file or directory
error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.

Love your library. very easy to implement. Want to use this in a real project.

But one thing is seriously missing from this lib. not all input types are text fields. have to have Choices, SegmentedControl, Date Inputs controls.

I mainly needed Choices which can show UIActionSheet to choose the options.

Do you have any plans for these in near future.

Just a question, before I fork and work on this a bit: it seems as though the UIAppearance mechanism does not as of yet make appearance changes smoothly. For instance, sizing the the input fields to be exceptionally legible (36 point font) or likewise for the infoCells, results in cells running over each other or occluding each other. If I set elementHeight = 55, and infoCellHeight = 24 and use a 48 point font (large, yes – but lets assume our human users have very tiny eyeballs), then each cell basically overlaps and the infoCells fall behind in such a way that they are not seen.
I'm happy to look at this closer, but I want to see if this is just the way BPForms is at the moment and I'm not overlooking something in my first go with this.

@bpoplauschi: The example works great with your awesome lib
Sorry for my mistake but the pod might lack of needed files. I manually add your lib as an external lib then it works but I think that could be not the right way, I love the "pod" way 👍
Here what I did:
Add the pod to my project, then create the signup controller as the example => can not compile due to "NOT FOUND" error of theses header files, e.g:

#import "BPFormFloatInputTextFieldCell.h"
#import "BPFormFloatInputTextViewCell.h" 

Thanks again for your great work.
Here what I see the differences

My env:

osx 10.9.1 ; xcode 5.1.1 (5B1008); pod 0.32.1

I managed to get the info view being displayed in the wrong location:

If I can reproduce, or even find the bug, I'll post more.

pod spec which BPForms
/Volumes/Home/XXXX/.cocoapods/repos/master/BPForms/1.1.0/BPForms.podspec

pod spec lint BPForms.podspec 
[!] Pod::Executable fetch origin tags/2.0.0 2>&1
fatal: Couldn't find remote ref tags/2.0.0
fatal: The remote end hung up unexpectedly

You also need to tag a version to 2.0.0 in your git repo.

In the example project sometimes the submit button has the wrong height.

Might be related to #11.

When I run the example code, I don't see the floating labels in any of the fields except for the description field. Based on the animation in the Readme, I was expecting them to show up in each of the fields as I started typing.