braddr / at-client Goto Github PK

Hey @braddr ,

What do you think about moving the bulk of the logic in these scripts into the dlang repositories? For example, do_build_dmd.sh would become:

#!/usr/bin/env bash
$1/dmd/.autotester/do_build_dmd.sh

Then the rest of the logic would be moved to the DMD repository under .autotester/do_build_dmd.sh.

This allows most of the logic to be versioned along with the repository itself, so any changes/fixes needed will be transparent to the autotester, the autotester will just work even if the logic underneath needs a change.

It also allows the autotester to build any version of code so long as this interface is not changed. For example, if the stable/master diverge, the autotester doesn't have to try to support both simultaneously, instead, each version of the DMD repo will already have the autotester build logic it needs.

Of course, I haven't looked into these scripts in detail, so the autotester interface may need to be a bit more than just the names of the scripts. It might need to pass some arguments back and forth. In any case, what do you think?