bradfrost / ish. Goto Github PK

I can't activate Focus Mode. Alt-U doesn't do anything on Mac in Chrome or Safari. I've tested on two different machines. Looking at the system preferences for keyboard shortcuts, I don't see something else overriding that key combination.

I combed the ish source looking for where the keyCode was defined, but I couldn't find it.

My suggestion would be to set the keyboard shortcut as a settable variable. But if you could just point me to where to set this, I'd be happy to do it myself.

I'd like to separate the ish interface from the task, so it can be included on any project for any purpose.

The javascript already does a pretty good job of declaring the interactive elements in variables, we'd just need to make sure these are used throughout and we can pass new values into the method.

The menu bar is out of alignment starting at the "S". i.e. Not flush along the bottom.

To make is nice and flush the "top" value in ".sg-controls" (line 148) should be changed from "0" to "-2".
( It should be the same as the "top" value in ".sg-code-contains code {" which is "-2" )

And thanks , it works great.
Glen

Would someone be able to add a zoom feature, similar to Chrome dev tools - toggle device toolbar, where users could test their work on viewport widths that are larger than the actual physical screen width?

Would love to test my work on 4k screens but naturally my dev screen is not larger than 1920px, I am a poor kid and still have an old analogue TV that I barley ever turn on.

Seeing how a layout might scale on those fancy big screens would be awesome.
Is there a tool for that actually?

A lot of ecommerce sites use the header for 'X-Frame-Options' set to 'sameorigin' to guard against clickjacking. And because ish. runs a site in an iframe that header value does not allow ish to run. To test this, use https://www.amazon.com as the site and view the console message in Chrome Dev Tools.

1. Go to ish demo
2. Scroll

Expected result- page scrolls
What happens - doesn't scroll

Chrome 36.0.1985.125, Mavericks, no extensions installed - the draggable resize bar doesn't seem to be visible.

It's there in the markup, and 'should' work, but this is possibly a bug in chrome that prevents it from being visible. If you delete the iframe from the DOM it oddly becomes visible again.

ish. demo at https://bradfrost.com/demo/ish/ is not found. 😢 Sincerely, missing Disco Mode.🕺🏽