Giter VIP home page Giter VIP logo

brainstormforce / all-in-one-schemaorg-rich-snippets Goto Github PK

View Code? Open in Web Editor NEW
113.0 32.0 44.0 2.01 MB

WordPress Plugin that Boost CTR. Improve SEO & Rankings. Supports most of the content type. Works perfectly with Google, Bing, Yahoo & Facebook.

Home Page: http://wordpress.org/plugins/all-in-one-schemaorg-rich-snippets/

CSS 8.95% PHP 86.33% JavaScript 4.58% Shell 0.14%
wordpress-plugin rich-snippets schema star-rating

all-in-one-schemaorg-rich-snippets's People

Contributors

aniljadhavmca avatar artemshelest avatar bmartus avatar dependabot[bot] avatar gauravkhupse avatar graylaurenm avatar hemant7405 avatar hofmannsven avatar imnavanath avatar mahajanleena1995 avatar nikschavan avatar patilvikasj avatar pratikchaskar avatar psrebniak avatar rajkiranbagal avatar rohitp-bsf avatar sandeshjangam avatar sushmak02 avatar swapnildhanrale avatar vrundakansara avatar yawalkar avatar yssambare12 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

all-in-one-schemaorg-rich-snippets's Issues

Location: Street Address is adding one extra div

Hey guys,

We had an issue with one of our websites- when you a street name, you have an opening div https://github.com/brainstormforce/all-in-one-schemaorg-rich-snippets/blob/master/functions.php#L999, but if you don't fill the field, you have an extra closing </div> here https://github.com/brainstormforce/all-in-one-schemaorg-rich-snippets/blob/master/functions.php#L1009

I've fixed the issue, adding the same check if(trim($service_street) != "") for the closing </div> item, even if it doesn't WordPress Coding Standards, which seems to be working fine for the project I'm working on.

Would you check the submitted PR and see if there is anything else that needs to be fixed?

Cheers

Using the subject - people - breaks code

All selections work fine except "people" - using latest Wordpress with MH News theme.
It has an extra "closed" somewhere in the code causing the sidebar to move down below the main content.
Adding an open

at the end of the content (body of article) temporarily fixes the issue.
This proves there is an extra
in the people section of the code.

HTML Syntax Errors

Hello,

The following html syntax errors were found which break html validation:

  1. Element div not allowed as child of element span (ie a div can't be within a span tag):
    Summary<span class="ratings"><div class="star-blocks"><form name="rating" method="post"

  2. Stray end tag span:
    <div class="snippet-data-img"><span itemprop="ratingValue">3</span> based on <span class="rating-count" itemprop="reviewCount">8</span> votes </span></div>

and here as well:

<div class="snippet-data-img"> <span itemprop="availability" content="in_stock">Available in Stock</span></span></div>

Thx,

SW

wp.media.editor fails to load on backend, breaking js

Hi there,

if you have additional backend packes running javascript a weird issue appears:

TypeError: undefined is not an object (evaluating 'wp.media.editor')

If you disable your plugin everthing's going back to normal.

Testing with: WordPress 4.1.1 + Custom Field Suite + yours -> Custom Field Suite Backend breaks (adding fields doesn't work anymore) as longs as you plugin is active

var_dump in bsd_Meta_box causes problems

On line 359 in the file all-in-one-schemaorg-rich-snippets/init.php there is a call to var_dump which causes the save draft functionality in Wordpress to break. This can be easily fixed by removing this var_dump($post_id).

itemReviewed schema is invalid

Google has tightened up the criteria for the types of schema that Review can be applied to:

https://webmasters.googleblog.com/2019/09/making-review-rich-results-more-helpful.html

As such, the markup for 'Item Review / itemReviewed' in the plugin is kicking out an error as it has 'Thing' applied to it.

I have edited the plugin on my own sites to set the itemType to Product as my reviews are for products.

It would be good if the plugin had secondary options for setting the type of Item Review to match Google's new criteria. In my case I cannot use the current option of Product within the plugin as this does not mark it up as a review of a product.

To fix the issue for the time being I have replaced this code on line 92:

$review .= "<div class='snippet-data'> <span itemprop='itemReviewed'>".esc_attr($item )."</span></div>";

With this:

$review .= "<div class='snippet-data'> <span itemprop='itemReviewed' itemscope itemtype='http://schema.org/Product'><span itemprop='name'>".esc_attr($item )."</span></span></div>"

import some data from yoast seo

Very booooooring typing to field info about link to image, description or whatever twice, i guess. Maybe do it automatically?
anyway thank for your plugin ;)

People snippet html is broken if no street address is given.

To reproduce problem:

  • configure rich snippet attached to single post
  • select post to be about 'People'
  • enter Person's Name 'John Doe' and Homepage URL 'http://example.org/john'
  • save the post

This produces html:

<div id="snippet-box" style="background:#F5F5F5; color:#333333; border:1px solid #ACACAC;">
  <div class="snippet-title" style="background:#E4E4E4; color:#333333; border-bottom:1px solid #ACACAC;">Summary</div>
  <div itemscope itemtype="http://schema.org/Person"">
    <script type="text/javascript">
      jQuery(document).ready(function() {
        jQuery(".snippet-label-img").addClass("snippet-clear");
      });
    </script>
    <div class="aio-info">
      <div class="snippet-label-img">Name</div>
      <div class="snippet-data-img">
        <span itemprop="name">John Doe</span>
      </div>
      <div class="snippet-clear"></div>
      <div class="snippet-label-img">Website</div>
      <div class="snippet-data-img">
        <a href="http://example.org/john" itemprop="url">http://example.org/john</a>
      </div>
      <div class="snippet-clear"></div>
      <!--</span>-->
      </span>      <!-- These elements are -->
      </div>       <!-- not opened if street address is missing -->
      <div class="snippet-clear"></div>
    </div>
  </div>
</div>
<div class="snippet-clear"></div>

If user chooses to enter person's street address, the html is correct:

<div id="snippet-box" style="background:#F5F5F5; color:#333333; border:1px solid #ACACAC;">
  <div class="snippet-title" style="background:#E4E4E4; color:#333333; border-bottom:1px solid #ACACAC;">Summary</div>
  <div itemscope itemtype="http://schema.org/Person"">
    <script type="text/javascript">
      jQuery(document).ready(function() {
        jQuery(".snippet-label-img").addClass("snippet-clear");
      });
    </script>
    <div class="aio-info">
      <div class="snippet-label-img">Name</div> 
      <div class="snippet-data-img">
        <span itemprop="name">John Doe</span>
      </div>
      <div class="snippet-clear"></div>
      <div class="snippet-label-img">Website</div>
      <div class="snippet-data-img">
        <a href="http://example.org/john" itemprop="url">http://example.org/john</a>
      </div>
      <div class="snippet-clear"></div>
      <div class="snippet-label-img">Address</div>
      <div class="snippet-data-img">
        <span itemprop="address" itemscope itemtype="http://schema.org/ PostalAddress">
          <!--<span typeof="v:Address">-->
          <span itemprop="streetAddress">Street 12</span>,<br>
          <!--</span>-->
        </span>
      </div>
      <div class="snippet-clear"></div>
    </div>
  </div>
</div>
<div class="snippet-clear"></div>

Missing alt on images

Hi,

Thank you for this wonderful plugin.
When using SEMRush, I've got warnings on missing alt attributes on images added by all-in-one.
Is that possible to add this feature in the plugin. We could take the alt attribute of the media, there is no need to custom it.

Thanks
Regards

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.