brave-intl / bat-ratios Goto Github PK

same as brave-intl/currency#58

• add postgres to heroku
• add interval task to insert prices and timestamp

Multi currency support

• Support passing of comma separated currencies
• Include test and update other coin gecko test

there should not be more than 18 decimal places. currently we have up to 36

if we are unable to respond with a value, use the last available historical prices

uphold has a public api for tickers, which is the provider we use anyway. so might as well just use it for ticker prices so the prices understood through the whole system are consistent

See Sentry. This error resulted in 4m of downtime as reported in Slack.

when hitting api endpoint, and reaching out to binance or oxr fails, failures should be handled by using previous values

if approved: hapijs/joi#1727 work on and implement for ratios to allow for faster responses

seems that the middleware is out of order
the robots.txt file is not being returned and it is causing extra requests to be handled and logged in prometheus: https://ratios.mercury.basicattentiontoken.org/metrics

filtering is highly useful especially when dealing with huge amounts of data. would be best to be able to filter csv and json by fields if so requested

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Vary for caching control

currency keys are not being parsed correctly somewhere in the /v1/ endpoint. find and fix

https://github.com/siimon/prom-client

Needs a version update. Causing a ton of sentry logs.

any endpoint that returns an array of objects can generally have the option available to send back as csv

currently non relevant paths are getting into metrics. remove them by reorganizing the middleware and filtering them out before they can be logged by prometheus