braze-inc / braze-gtm-initialization Goto Github PK

Hello,

To be GDPR compliant, you would need to load the Braze SDK only after it has been consented. Take the following user flow:

• user goes to the page
• Braze is not loaded as per GDPR
• user accepts cookies
• Braze is loaded and Braze.initialize() is called through this GTM tag
• user then refuses cookies
• Braze.disableSDK() is called through the GTM action tag
• user reloads the page
• Braze is not loaded as per GDPR
• user then re-accepts cookies
• Braze.initialize() is called though this GTM tag but the user still has the "disable cookie" present, so Braze skips all activity

In this case, we would need to call enableSDK after Braze has been loaded, but before Braze.initialize()

You can probably workaround this by duplicating the initialization tag and user tag sequencing + the GTM action tag with enable SDK but that would open two sessions in a row, or maybe not, I don't know Braze internals and I don't really want to know.

I basically modified the template with

  if (data.disableTracking) {
    const disableSdkName = majorVersion >= 4 ? 'disableSDK' : 'stopWebTracking';
    callInWindow(sdkObject + '.' + disableSdkName);
  } else {
    if (data.enableTracking) {
      const enableSdkName = majorVersion >= 4 ? 'enableSDK' : 'resumeWebTracking';
      callInWindow(sdkObject + '.' + enableSdkName);
    }

    // Initialize the SDK with api key and base url (from user input)
    callInWindow(sdkObject + '.initialize', data.apiKey, options);

This is not really an issue for 99% of the users, but for non technical people of a product team this can get confusing that it doesn't work

Thanks for submitting a template to the gallery, there were a few issues in your template that needed to be resolved ahead of approving the template for the gallery.

1. encodeUriComponent should be used on user provided values that are then used as parameters in your url. These methods take in a single text argument and return a URI Encoded string. You should use this method on "data.sdkVersion" when generating the url
   const url = 'https://js.appboycdn.com/web-sdk/'+ data.sdkVersion +'/appboy.min.js';
2. The readme.md doesn't provide any information. Instead it redirects user to the gallery page which is irrelevant. Please provide valid information if any about the template.