brendonmatos / golive Goto Github PK

⚡ Live views for GoLang with reactive HTML over WebSockets 🔌

License: MIT License

Go 84.52% HTML 0.34% JavaScript 15.14%

diff golang golive live-view liveview server-side-rendering virtual-dom websockets

golive's Introduction

Hi! 👋

My current focus is creating tools that make a difference for people. From creating software useful to clients to creating software for developers.

Be kind, be useful, and be happy. That is all that matters.

My personal website: brendonmatos.com

golive's People

Stargazers

Watchers

Forkers

ahmadwaleed isgasho tedsean samhennessy cxsx tawawhite forkgolang developgo hellcoderz rpwatkins zach-source patrickcurl didip youngsoonlee mazong-dongmo-manuel-glory mar-tina elchemista

golive's Issues

Updating the child component should not trigger rendering on the parent

Embed components

@brendonmatos Is it possible to embed components?

Click event not firing server side

Hello! I'm new to GoLive but I'm really excited about this project! I've ran the examples and I've tried to create my own from the start to get familiar but I'm struggling to get a simple button click event to fire on the server side.

I have the following HTML:

<button go-live-click="HandleUp">+</button>

And on the server I have this but the Println() doesn't seem to fire.

func (t *Thermostat) HandleUp() {
	fmt.Println("UP")
	t.Temperature = 50
}

I would really appreciate any help!

https://laravel-livewire.com/ and https://github.com/patrick-steele-idem/morphdom

Lavavel Livewire uses the https://github.com/patrick-steele-idem/morphdom library to diff the dom updates.

Does this package do the same thing?

But in TemplateHandler: .name needs to be .Name

golive/examples/list/main.go

Line 115 in 27cf35b

GL 21:44:35 ERR handle html request error=template execute: template: Books_UVRUV:13:99: executing "Books_UVRUV" at <$Book.name>: can't evaluate field name in type main.Book

Hi there, just a quick typo bug report on the above line.

Textarea doesn't start with initial value like `<input />` tag

Should be
<textarea>{{.Value}}</textarea>

Views are not syncing across browser windows in examples

Steps taken:

cd examples/slider
go build
./slider
Open http://127.0.0.1:3000 in two windows
Play with the slider

Expected:
The same thing happens in both windows at the same time.

Actual:
Only the window where the user is interacting gets updated.

I also saw this with the todo example. It happened both on Chrome and Safari on Mac.

page reloads unmounts old components but they are destroyed in the server and still try push data

step to reproduce:

run server with 1 or more components (like clock one which updates via server events)
reload the page
see the warning WRN handle ws request: unexpected connection close
start seeing errors every timestep the clock old clock component was updating

Error logs below

 ┌───────────────────────────────────────────────────┐ 
 │                    Fiber v2.2.3                   │ 
 │               http://127.0.0.1:9000               │ 
 │                                                   │ 
 │ Handlers ............. 4  Processes ........... 1 │ 
 │ Prefork ....... Disabled  PID ........... 2042802 │ 
 └───────────────────────────────────────────────────┘ 

GL 16:10:42 WRN handle ws request: unexpected connection close
GL 16:10:42 ERR call to commit on unmounted Component name=Root_bHk6G
GL 16:10:42 ERR call to commit on unmounted Component name=Root_ksoMy
GL 16:10:43 ERR call to commit on unmounted Component name=Root_bHk6G
GL 16:10:43 ERR call to commit on unmounted Component name=Root_ksoMy
GL 16:10:44 ERR call to commit on unmounted Component name=Root_bHk6G
GL 16:10:44 ERR call to commit on unmounted Component name=Root_ksoMy
GL 16:10:45 ERR call to commit on unmounted Component name=Root_ksoMy
GL 16:10:45 ERR call to commit on unmounted Component name=Root_bHk6G
GL 16:10:46 ERR call to commit on unmounted Component name=Root_bHk6G
GL 16:10:46 ERR call to commit on unmounted Component name=Root_ksoMy
GL 16:10:47 ERR call to commit on unmounted Component name=Root_bHk6G
GL 16:10:47 ERR call to commit on unmounted Component name=Root_ksoMy
GL 16:10:48 ERR call to commit on unmounted Component name=Root_ksoMy
GL 16:10:48 ERR call to commit on unmounted Component name=Root_bHk6G
GL 16:10:49 WRN handle ws request: unexpected connection close
GL 16:10:49 ERR call to commit on unmounted Component name=Root_gf946
GL 16:10:49 ERR call to commit on unmounted Component name=Root_i4d5f
GL 16:10:49 ERR call to commit on unmounted Component name=Root_bHk6G
GL 16:10:49 ERR call to commit on unmounted Component name=Root_ksoMy
GL 16:10:50 ERR call to commit on unmounted Component name=Root_i4d5f
GL 16:10:50 ERR call to commit on unmounted Component name=Root_gf946
GL 16:10:50 ERR call to commit on unmounted Component name=Root_bHk6G
GL 16:10:50 ERR call to commit on unmounted Component name=Root_ksoMy
GL 16:10:51 ERR call to commit on unmounted Component name=Root_i4d5f
GL 16:10:51 ERR call to commit on unmounted Component name=Root_gf946
GL 16:10:51 ERR call to commit on unmounted Component name=Root_ksoMy
GL 16:10:51 ERR call to commit on unmounted Component name=Root_bHk6G
GL 16:10:52 ERR call to commit on unmounted Component name=Root_gf946
GL 16:10:52 ERR call to commit on unmounted Component name=Root_i4d5f

panic upon closing todo window

Steps taken:

cd examples/todo
go build
./todo
Open http://127.0.0.1:3000 in a browser window
Close the window.

Expected:
The server keeps running.

Actual:
The server crashes like this:

GL 21:20:52 WRN handle ws request: unexpected connection close
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x13eabf1]

goroutine 52 [running]:
github.com/fasthttp/websocket.(*Conn).Close(...)
        /Users/issactrotts/pkg/mod/github.com/fasthttp/[email protected]/conn.go:344
github.com/brendonmatos/golive.(*LiveServer).HandleWSRequest.func2()
        /Users/issactrotts/src/github.com/brendonmatos/golive/server.go:196 +0x471
created by github.com/brendonmatos/golive.(*LiveServer).HandleWSRequest
        /Users/issactrotts/src/github.com/brendonmatos/golive/server.go:182 +0x305

websocket queue

This project is retty interesting.

You might want to look into adding NATS to this system:
Web sockets for NATS and soon Nats Jetstream is happening. See:
https://github.com/nats-io/nats.ws

It would make it easier to have 100's of distributed golang servers in sync with browser clients.

Not sure if you know NATS ?

The CLI now has Jetstream included ..

Let me know what you think...

How to use with a template engine

Thanks so much for this project! I'm finding it really fun to work with.

I'm new to gofiber and I was wondering how would I use golive with gofiber and a template engine instead of returning static HTML like in your examples in the TemplateHandler function. I tried using a template engine but it looks like none of the data or interaction is correctly working in an interactive way.

Something like

	app.Get("/", func(c *fiber.Ctx) error {
		// Render index template
		return c.Render("view", fiber.Map{
			"Title": "Hello, World!",
		})
	})

I do see one mistake I have here which is there's no creation of the model object, but I'm not really sure how this flows with golive so I'm a little confused. I would really appreciate the help! Thanks so much for putting your time into this project I tried a bunch of similar ones and this one has been by far the funnest one to work with.

how about add support go-app?

https://github.com/maxence-charriere/go-app

I love your idea but I think this package need to method how to write template on golang.