brettjephson / ash-js Goto Github PK

Hi, thanks for the ash-js lib!

So I pulled the repo and did a grunt build, but there appears to be some problems.

/build/ashteroids.js
line 972, the empty array argument is missing
line 2442, 'ash' and the empty array are missing. instead,:

define("ash", function(){});

is inserted at line 2448

these (optimization?) changes are seemingly problematic.

This may or may not be similar to the entity not being removed from the system. Basically there was a bug in the as3 version where when you destroyed an entity, associated nodes kept reference to the entity until that node was used for a newly created entity.

Since the js port of Ash was created before the as3 issue was resolved, it's quite possible the faulty logic was also ported over.

There is an extensive conversation as well as tests for the as3 version here -https://groups.google.com/forum/?hl=en#!topic/ash-framework/SIlNf9ifA1E

Here was the fix for the as3 version addressed by Mr. Lord - richardlord/Ash@dfa978f

Hey, would it be possible to add minified script to cdnjs? I really like component based architecture, and cdn is useful for prototyping.

Hi Brett,
Do you have a sample project showing how to use the framework?
Thanks for porting Ash to JS!

...for use in Node/Browserify projects

Example:

On a system:

for (node = this._listnodes.head; node; node = node.next) {
var component = new Component();
node.entity.add(component);
node.entity.remove(component); <--component not removed
}