Hi Brett,

I noticed when using some custom menu's (for example in the footer), I had to overwrite quite a bit of the menu styles; I think it would be a good idea to specify (parts of) the styling a bit more, as in targeting the --primary menu only. For example: visibility, hover states, z-index and the like.

Cheers, Tibor

Investigate the option of using Laravel Mix for the build tool

Consider adding Dependabot. Looks like a useful service that's used on the Foundation repo.

I seem to keep on having problems with running the npm commands... After nmp install i try to run the watch script but seems to get the error:

npm ERR! code ELIFECYCLE
npm ERR! errno 1

I dont know if it 's got something to do with the luxe config, but my other luxe projects seem to have no problems...
Cleared my caches, dit a reintall, updates node, run audit fixes...

Add vertical rhythm to Sass. Possibly based off Inuit but maybe use a vr() function to output a value.

Hi Brett!

I am currently working on an _s based starter theme and trying to implement your responsive-menu.js.

I have managed to add the proper BEM classes to the navigation, but somehow get the following error:

Uncaught ReferenceError: menuIcons is not defined
    at new ResponsiveMenu (responsive-menu.js:13)

Hope you can help me on my way solving this.

Cheers, Tibor

Hi Brett,

When running npm run dev on a fresh install, I get the following error:

Error: clean-webpack-plugin only accepts an options object

The issue seems to be the path.resolve part, on line 99 in webpack-common.js:

new CleanWebpackPlugin(path.resolve(__dirname, config.paths.public), { verbose: false }),

Would you have any idea on how to fix this? (my webpack knowledge is very limited..)

Thanks in advance!

Should look into adding the meta-theme tag, eg:

<meta name="theme-color" content="#000000" />

Possibly a way to add this automatically from a config file.

We need to add some basic JS for things like toggling a menu and the menu itself.

Been following this for a while and think its a good fit for how I've grown used to writing CSS.
The CSS in the project is due a rework so should explore in greater detail.

Link

I think it might be worth investigating using something similar to Exhale: https://github.com/justintadlock/exhale/blob/master/app/Block/Component.php

This replaces the default WordPress long winded classes with Tailwinds shorter, more succinct classes.

Hi Brett,

I'm trying to use a custom font, but can't seem to get it working. I have added the font files to resources/fonts, and used

@font-face { font-family: "CadizWeb";font-style: normal; font-weight: 400; src: local("CadizWeb"), local("CadizWeb-Regular"), url("../../fonts/CadizWeb-Regular.woff2") format("woff2"), url("../../fonts/CadizWeb-Regular.woff") format("woff"); }

I can see the fonts are duplicated to the right directory in /public, but I think this also has to do something with the proper path to the custom fonts from /public.

Hope you can help..

The theme should try and more closely follow WordPress coding standards (with a few exceptions) and include a working phpcs config to enforce it.

Now that I've been using the theme for a while I think its time to look at simplifying the view structure. The folders are nice, but ultimately make development a little too complex for 99% of projects.

A solid example of what I think might work better is https://github.com/m-e-h/forsite/tree/master/views

Production assets should have a .min suffix added where applicable.
Then we can safely ignore any non production assets in .gitignore to make sure only production assets are comitted.

Tailwind 1.0 is nearly out: https://tailwindcss.com
Might be worth looking at this as an option for styling.

I think some more sensible utility classes would be helpful overall so there is less duplication.

See how the tab sizes can be changed. 8 size tab is too large!

Any Gutenberg styles that I notice need adding will be listed here...

Tables

• Default style should be a bit more pleasing
• Styling for striped tables

Pullquotes

• Styling should be applied to the nested blockquote rather than the wrapping div
• Styling for solid styled

Columns

• Need responsive styles. Should be 1/2 columns by default.

Buttons

• Remove underline on hover and focus
• Coloured buttons need reworking

Twitter embed

• Bottom is cut off by the wrapper

Dividers

• Dotted option looks incorrect in editor

Media text

• No styling at all for the media text block

Hi Brett,

Not an issue, but I noticed you closed all Tailwind related branches. Coincidently I also noticed that WebDevStudios is working on their wd_s theme to support Tailwind; thought you might want to give that a look (since I still think it would be nice to have a Tailwind-supporting version of Luxe ;-)):

https://github.com/WebDevStudios/wd_s/tree/feature/tailwind

Cheers, Tibor

We need to bake in support for WooCommerce out of the box.
This needs to include styling as well as filters etc.

The theme needs a full Sass makeover. Refer to Uuups for an excellent example.
We should be able to do this without using Foundation!

Elements:

• Forms
• Blockquote
• Code
• HR
• Lists
• Links
• Media
• Tables
• Headings

Components:

• Comments
• Button
• Entry
• Footer
• Header
• Menu
• Pagination
• SVG
• Table

Explore the possibility of using the core WordPress scripts package and extending it for my needs.
See https://mor10.com/a-simpler-way-to-add-svgs-to-custom-wordpress-gutenberg-blocks-using-svgr/ for ideas.

When there is an elaborate menu with many nested menu items on multiple levels, a user is unable to scroll down on mobile when he/she has expanded some of these levels to the extend that they fall outside the viewport. In that situation the menu will close when scrolling.

I'd love to submit a pull-request that improves this, but I'm not sure where to look. Can you point me in the right direction? Does the menu lose focus when someone scrolls and therefor closes? I still see the hamburger icon having the :focus outline. I don't think responsive-menu.js has any influence on this.

Any pointers appreciated :-)