The drinkingtime from brianium

drinkingtime's People

Contributors

Stargazers

Watchers

drinkingtime's Issues

User screen input should be keyboardType numeric

Should give the text input on the user screen a keyboardType prop with a value of numeric

User screen dot menu should hide for first visits

If the isFirstVisit prop is true for the user screen, the dot menu should be hidden

Be more explicit on screen styling

react-navigation screen components seem to influence styling, the easiest solution seems to be fixing it at the screen level in the ui package. Just be sure to explicitly set background colors and set margins on components within the screen, not the screen itself:

For instance, the home screen becomes: (note styles.view and styles.button)

import React from 'react';
import { StyleSheet, View } from 'react-native';
import SafeAreaView from '../../components/SafeAreaView';
import Text, { TextStyle } from '../../components/Text';
import Button from '../../components/Button';
import Drink, { DrinkType, Size } from '../../components/Drink';
import colors from '../../lib/colors';
const Home = (props) => (<SafeAreaView style={styles.view}>
    <Drink size={Size.Large} style={styles.drink} type={DrinkType.Beer}/>
    <Text style={styles.title} textStyle={TextStyle.Title}>
      Drinking Time
    </Text>
    <View style={styles.button}>
      <Button text="Start Drinking" onPress={props.onButtonPress}/>
    </View>
  </SafeAreaView>);
const styles = StyleSheet.create({
    button: {
        flex: 1,
        justifyContent: 'flex-end',
        marginBottom: 83,
        width: '100%',
    },
    drink: {
        marginTop: 62,
    },
    title: {
        color: colors.black,
        fontSize: 48,
        marginTop: 24,
    },
    view: {
        backgroundColor: 'white',
        alignItems: 'center',
        justifyContent: 'center',
    },
});
export default Home;