Giter VIP home page Giter VIP logo

Comments (18)

pinuke avatar pinuke commented on May 28, 2024 2

@rotello should we start a club? maybe a support group... "Brian Petro's Annoying Fans Anonymous"

from obsidian-smart-connections.

rotello avatar rotello commented on May 28, 2024 2

i think we could :-P

from obsidian-smart-connections.

brianpetro avatar brianpetro commented on May 28, 2024 2

I really appreciate it, but also couldn't imagine keeping this thing going if it weren't for such enthusiastic and helpful people like yourselves. Thank you @smartguy1196 @rotello 👏

from obsidian-smart-connections.

brianpetro avatar brianpetro commented on May 28, 2024 1

I am doing more test. it seems that the kindle clipping are working, while the mobi / loooong form MD i imported (it s basically a full book i ve ) is not indexed.

Great to know, thanks! This type of feedback is really helpful.

In the background, "parsing," breaking the notes into logical chunks, plays a big role in the plugin's effectiveness. So less common formatting is more likely to run into issues.

I do have a lot of improvements I want to make to the parser. A lot of them are designed to handle long-form content better. So, in time, the plugin will improve at handling these cases.

Lastly, I know it's incredibly frustrating when software doesn't work as expected, and it's easier to walk away than to contribute to its improvements. So thanks again for your continued assistance!

Brian 🌴

from obsidian-smart-connections.

brianpetro avatar brianpetro commented on May 28, 2024 1

@dartungar which language is this occuring with?

I have two ideas for changes that will both contribute to solving this:

There is now a language setting in Smart Connections, and with that, we can adjust how the tokens are estimated. Some languages use characters that make the "divide by 4" estimate unreliable. This calculation should be easy to adjust based on the language selected in the settings.

Additionally, I plan on implementing a method to catch this error, reduce the amount of context, and resubmit the request automatically. This should prevent bad estimates from causing a fatal error like this.

After making those two changes, I think this issue will be solved.

from obsidian-smart-connections.

brianpetro avatar brianpetro commented on May 28, 2024

Hey @leips , thank you for taking the time to bring this to my attention!

Are you able to take a screenshot of the error in the console?

Is this happening after the first, or many, messages?

Thanks for your help in solving this issue :)

from obsidian-smart-connections.

leips avatar leips commented on May 28, 2024

The screenshot,

imagen

I try with a few notes, everything works, but after I put the of the notes in my vault (500 notes) this error appears every time I'm asking something about the notes.

from obsidian-smart-connections.

brianpetro avatar brianpetro commented on May 28, 2024

Thanks for the quick follow-up.

The plus sign in the top right of the chat window will clear the current context. This will be necessary until I implement a manual pruning of past messages.

but after I put the of the notes in my vault (500 notes)

Can you clarify what you mean by this?

Thanks,
Brian 🌴

from obsidian-smart-connections.

leips avatar leips commented on May 28, 2024

Same error after click the plus sign.

Can you clarify what you mean by this?

I made two test. First, with a few notes, everything works. Second, with a 500 notes. After refresh the embeddings, this message appears when I ask something.

from obsidian-smart-connections.

brianpetro avatar brianpetro commented on May 28, 2024

Is the 500 note vault something you'd be comfortable sending me so I can test it out? Otherwise I'll have to think on it a bit, not sure what's up. [email protected]

from obsidian-smart-connections.

leips avatar leips commented on May 28, 2024

It's personal information.

Yesterday I deleted the embeddings and started over all the process. There is something about the embeddings that change every time I refresh the process. I'll continue testing.

Thanks!

from obsidian-smart-connections.

brianpetro avatar brianpetro commented on May 28, 2024

@leips I think I might have an idea what's up.

Do you have some really long notes? Maybe ones that don't use a lot of headings? Like, large text blocks (>1000 chars) without and headings?

If so, the logic for limiting lengths of notes in the context window is probably the problem.

This is something that I can improve to better handle cases like I mentioned above.

Thanks for your help in figuring this out!

from obsidian-smart-connections.

rotello avatar rotello commented on May 28, 2024

I am doing more test. it seems that the kindle clipping are working, while the mobi / loooong form MD i imported (it s basically a full book i ve ) is not indexed. I ve not got any error.
I updated the plugin. closed the Vault and it seems to work. I am excited
Screenshot 2023-03-17 at 20 17 27

from obsidian-smart-connections.

rotello avatar rotello commented on May 28, 2024

Thank for bearing my obnoxiousness :-)

from obsidian-smart-connections.

pinuke avatar pinuke commented on May 28, 2024

Issue reported again in comment: #88 (comment)

from obsidian-smart-connections.

dartungar avatar dartungar commented on May 28, 2024

Yeah, for sake of convenience here is my comment:
image

from obsidian-smart-connections.

dartungar avatar dartungar commented on May 28, 2024

@brianpetro well, most of my notes are in Russian (hope that doesn't put you off! 😶 ). That does seem like a potential cause, will check the new setting. Cheers!

from obsidian-smart-connections.

brianpetro avatar brianpetro commented on May 28, 2024

Closing in favor of this FR #126

from obsidian-smart-connections.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.