briles / gruvbox-atom Goto Github PK

Any thoughts on styling the colors use by the indent-guide-improved package to better mesh with the Gruvbox palette?

.indent-guide-improved {
  background-color: gray;
  &.indent-guide-stack {
    background-color: cyan;
    &.indent-guide-active {
      background-color: blue;
    }
  }
}

Highlighted words are black instead. This is with default One Dark UI theme.

There's a bug in Gruvbox Plus that causes <text> boxes in Atom's settings windows, search bar, etc., to be unreadable when using a light UI theme (e.g., "One Light") and Gruvbox Plus' "Brightness" setting is set to "Dark".

See screenshot using the "One Light" UI theme that comes with Atom, and Grubox Plus set to "dark" brightness, "hard" contrast, and "no dimmed colors" variant:

The cause seems to be that Atom uses 'mini' text-editor controls for settings, et al. <text> input boxes. When Gruvbox Plus is set to "dark", it uses a light color for default text. On normal text-editors, this is fine, because Gruvbox Plus also sets a dark background color. However, on mini text-editors, Atom uses the UI theme's background color, which can be light. This leads to unreadable light text on a light background.

Atom version: 1.9.0-beta0
Gruvbox Plus version: 1.2.3
OS: Mac OS X "El Capitan" v10.11.5

Scopes at cursor:
text.html.php
meta.embedded.line.php
punctuation.section.embedded.end.php
source.php

I think that current state of themes (with configuration inside theme package) is difficult to change them automatically or buy hotkeys, so would be nice to split them to light and dark variants

What do you think?

I try reinstall theme but I still see one text color in my code

After the recent update all font is only the creme color :(

Hello,

I've been using this theme for years (thanks!), and all of a sudden it appears to have broken.

Apologies for not knowing the theme terminology here, I'll post a couple screenshots:

This is 'gruvbox plus' theme since the last few days:

Here's the gruvbox theme from here (which isn't as cool as this one!):

As you can see it has lost the highlighting colour in various places.

EDIT
Atom @ 1.32.0
On OS X
Using language JavaScript

Hi, it seems some items in the pug syntax aren't highlighted
Gruvbox:

Nobber:

And is it possible for pug mixins to have a different color?
Gruvbox:

Nobber:

Besides, I love this theme!

• note the first 3 commas on color and the last is white.
• The alpha value in the rgba color is magenta if it's 0 but green if its something else.
• hyphenated propetry in transition has a magenta hyphen
• this is minor and probably not worth it, but the digit in the transition timing is white while other digits in property values are magenta.

Thanks for the great atom syntax @Briles, I think it's a great improvement on what I was using before.

Just a small point I have noticed: the editor highlights a word in red sometimes when I'm typing in the editor, which makes correct spelling unnecessarily difficult. Is it possible to make this an opt-in/out feature? Does it have to do with a language grammar?

Happy New Year,
cbc

[Enter steps to reproduce:]

1. ...
2. ...

Atom: 1.14.3 x64
Electron: 1.3.13
OS: Mac OS X 10.12.3
Thrown From: gruvbox-plus-syntax package 1.3.1

Stack Trace

Failed to activate the gruvbox-plus-syntax theme

At variable @background is undefined in /Users/rebekahwiese/.atom/packages/gruvbox-plus-syntax/styles/editor.less:0:20

LessError: variable @background is undefined
  at /packages/gruvbox-plus-syntax/styles/editor.less:0:20

Commands

Non-Core Packages

gruvbox-plus-syntax 1.3.1 
pigments 0.37.0 

Normally when your cursor is next to a bracket, it and its corresponding bracket is underlined. The brackets that are on the same line as the cursor are not underlined.

gruvbox version 1.2.0
atom version 1.7.0

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

http://pastebin.com/jirpRGjJ