broccolijs/broccoli#166

Any info on how to use this with broccoli-cli?

(current broccoli-cli idles at ~37%)

cc @krisselden

• maybe sane will add support -> amasad/sane#31

When a change is detected, the watcher builds and then

• appends the filepath that triggered the change
• emits a change event with the results hash that includes the filePath that changed and triggered the build

Because the build is debounced, it's possible for multiple files to change before the build starts, but only the first one will get reported in the results hash filePath property.

This can be demonstrated by changing two files very quickly, e.g.:

• touch path/to/a.js && touch path/to/b.js -> broccoli-sane-watcher emits change with {filePath: path/to/a.js}
• touch path/to/b.js && touch path/to/a.js -> broccoli-sane-watcher emits change with {filePath: path/to/b.js}

I'm not sure how "public" the filePath property on the hash is considered to be, but the livereload server in ember-cli does use that property to determine whether it should trigger a livereload notification in the shouldTriggerReload method.

If it seems like a good idea to gather all the filepaths that changed before the build started and report them in a filePaths property on the results hash I would be happy to make a PR for that.

This enables:

• understanding why a build happened
• logging via DEBUG=broccoli-sane-watcher*
• enable wrapping tooling to provide better information.

ember-cli#8

source: broccolijs/broccoli#163 (comment)

Comparison of master against my forked branch: master...timmfin:move-to-broccoli-v1

This was a very quick "brute force" pass. but it got me going locally. Maybe this helps (but if not no biggie... just figured I'd FYI you on my changes).

I can't find any docs on broccoli-sane-watcher, is it meant to integrate it in the Brocfile.js or the cli?

We have broccoli running with some people on one dev-server, and it consumes almost all the CPU.

I am unsure if it is this watcher, but since introducing it we seem to kill the build when a filter fails. For example if es6-validate-import fails to parse the JS. The build breaks, and we are unable to recover without restarting ember-cli

npm WARN engine makeerror@1.0.10: wanted: {"node":"0.6.x"} (current: {"node":"1.6.2","npm":"2.7.3"})
npm WARN engine tmpl@1.0.3: wanted: {"node":"0.6.x"} (current: {"node":"1.6.2","npm":"2.7.3"})

I've submitted PR's to the offending dependencies

• amasad/sane#46
• daaku/nodejs-makeerror#5
• daaku/nodejs-tmpl#3

Once they update, someone (me if I notice it) should update this module accordingly.

ember-cli/ember-cli#974 (comment)

cc @amasad