brominne / pe Goto Github PK

state activation box unclosed, consider close it usingdeactivate State when all actions on State are performed

does the List<SemesterData> refers to the four Semester that the Module is offered in? if so, consider removing the List<SemesterData> because it is double counting the same attributes

In other commands like list extra arguments are checked

this is not done in info.

Maybe consider adding similar check here for add command

Compared to level 9000 mod, which is identified as non existance, level 7 should also be invalid mod level, considering making 7 invalid level for mod code

activation box missing from state, since the diagram is using activation box so maybe do not ignore it here

method addSelectedModule should have input selectedModule:Module not Module:selectedModule, as Module is variable type here, should be put at back
same for getSelectedModuleList, removeSeletedModule

different behavior for timetable and select, junk input before / is ignored in select while identified as invalid command in timetable considering add check for select, refer to #9

There are modules which should be equivalent and cannot be taken together, like the cs1010 series. Maybe check if a newly added module is conflicting a module thats already in the list.

LessonType seems like a enum, consider adding it to the diagram as Semester depends on it

There are junk input behind search, and it is not detected
considering try to check for extra input before parse for /code and /module

AddModuleCommand tried to call to Ui twice consecutively, while control is not handled back to AddModuleCommand.
Considering adding
Ui -> AddModuleCommand:
after
AddModuleCommand -> Ui: addMessage()

new issue

the instance of SelectedModule is created in AddModuleCommand and should also be destroyed automatically when AddModuleCommand is destroyed. The object adds to the ModuleList is a copy of this instance.

gess1037 is a legit mod and i am studying it this sem, but the software ignored modules with four letter
considering allowing for gessXXXX types of module code, which contains 4 character before 4 digit code number

when program control transfer from Storage to State and it is not transferred back, then control is transferred from Storage toUi, consider giving control back to Storage by adding State -> Storage:

There are junk input behind select, and it is not detected

considering try to check for extra input before parse for /code and /module

Extra arguments are not catch in timetable command, which is done in list.

Maybe consider adding similar checks for timetable

For both incorrect command, Clearly the program knows the command is add, but it says unknown command in second picture, but seems here both commands are entering here are violating syntax
consider adding a help message to show syntax for add in the second case