broundal / pytolemaic Goto Github PK

When using setup.py, it is definitely not appropriate to tightly pin requirement versions. They must then be loosely pinned if at all. Please review https://packaging.python.org/discussions/install-requires-vs-requirements/#install-requires

it’s best practice to indicate any known lower or upper bounds

It is not considered best practice to use install_requires to pin dependencies to specific versions, or to specify sub-dependencies (i.e. dependencies of your dependencies). This is overly-restrictive, and prevents the user from gaining the benefit of dependency upgrades.

I advise updating requirements.txt to loosely pin its entries as advised in the above article. I see that requirements.txt is used by install_requires in setup.py.

Hi,

The logger in https://github.com/Broundal/Pytolemaic/blob/master/pytolemaic/utils/general.py is causing issues; it really should be up to the user what and how the logging is done etc, I know could use a LOGLEVEL env var but thats not really how these things work; the logger should be created in the .py file that actually runs the code and not a package that provides functionality.

Big fan aside from this but please amend as makes this whole unusable for me otherwise!

Please definitely mention the pip install pytolemaic command prominently in the readme.

Packages like coverage can go in a requirements-dev file. There is no reason to burden any user with requiring it.