browserify is not sending correct caching headers about browserify HOT 6 CLOSED

I put in a last-modified header but quite possibly it doesn't work:

https://github.com/substack/node-browserify/blob/master/index.js#L107

from browserify.

Your last modified is always returning the time of the request. You probably want to keep the time of bundle creation in memory, and reset it when you update the bundle (like when a file is changed and the 'watch' option is set).

Also, you are not setting the Etag header, so in essence you're not adhering to the specs I think.

Thanks again for all the work ;)

On 27Jul, 2011, at 19:22 , substack wrote:

I put in a last-modified header but quite possibly it doesn't work:

https://github.com/substack/node-browserify/blob/master/index.js#L107

Reply to this email directly or view it on GitHub:
#48 (comment)

from browserify.

Did you look into this yet? I will do it myself if I can find the time, but that won't happen soon. Maybe next week...

I am almost certain you have to return a 304 if the client asks for a cache validation.

from browserify.

+1 for this. Browserify should cache the bundle, and if there are no changes to the source files, it should send 304. It should also set Last-Modified headers, etc.

from browserify.

I don't think browserify should handle the caching. A middleware or a reverse proxy handle this perfectly, all they need is the Last-Modified header.

from browserify.

middleware is gone in v2

from browserify.