brunyuriy / crystalvc Goto Github PK

Right clicking on an icon should allow you to delete that repo.
Right clicking on a project (or anywhere on the row?) should allow you to 
delete the whole project.  

In the Bill and Melinda scenario, the shading is correct for a textual conflict 
but it is not for a build conflict.

Kivanc: When user clicks on refresh (from tray menu), if the daemon is not 
running, nothing is done. 

I would disable the many item.  

We want to add git tests the same way we have hg tests for checking the basic 
relationships.  

I added a border around the project panels.
(See commit f1e3cf14493b)

When you right click on an icon, you should have the ability to edit the 
relevant config data.

Crystal doesn't get Melinda's build conflict right in the demo

When closing the configuration window with unsaved data, the main Crystal 
window gains focus and the dialog pops up to ask if the changes should be 
saved.  Ideally, the focus would not change until after the user answered the 
dialog.  

Crystal seems to run out of memory sometimes.  

One problem is there is no way to pass the xms / xmx arguments to java when 
running a jar via double clicking it.  

Stack trace:
Exception in thread "AWT-EventQueue-0" java.lang.OutOfMemoryError: Java heap 
space
       at java.lang.Integer.valueOf(Integer.java:642)
       at sun.util.logging.PlatformLogger$JavaLogger.doLog(PlatformLogger.java:530)
       at sun.util.logging.PlatformLogger.finest(PlatformLogger.java:302)
       at sun.awt.X11.XErrorEvent.<init>(XErrorEvent.java:20)
       at sun.awt.X11.XToolkit.globalErrorHandler(XToolkit.java:194)
       at sun.java2d.loops.MaskBlit.MaskBlit(Native Method)
       at sun.java2d.loops.Blit$GeneralMaskBlit.Blit(Blit.java:204)
       at sun.java2d.pipe.DrawImage.blitSurfaceData(DrawImage.java:953)
       at sun.java2d.pipe.DrawImage.renderImageCopy(DrawImage.java:575)
       at sun.java2d.pipe.DrawImage.copyImage(DrawImage.java:90)
       at sun.java2d.pipe.DrawImage.copyImage(DrawImage.java:1024)
       at sun.java2d.pipe.ValidatePipe.copyImage(ValidatePipe.java:196)
       at sun.java2d.SunGraphics2D.copyImage(SunGraphics2D.java:2988)
       at sun.java2d.SunGraphics2D.drawImage(SunGraphics2D.java:3021)
       at sun.java2d.SunGraphics2D.drawImage(SunGraphics2D.java:2974)
       at sun.awt.X11.XTrayIconPeer$IconCanvas.paint(XTrayIconPeer.java:587)
       at sun.awt.X11.XTrayIconPeer$IconCanvas.repaintImage(XTrayIconPeer.java:566)
       at sun.awt.X11.XTrayIconPeer$TrayIconCanvas.repaintImage(XTrayIconPeer.java:533)
       at sun.awt.X11.XTrayIconPeer$IconCanvas$IconObserver$1.run(XTrayIconPeer.java:607)
       at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
       at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:705)
       at java.awt.EventQueue.access$000(EventQueue.java:101)
       at java.awt.EventQueue$3.run(EventQueue.java:666)
       at java.awt.EventQueue$3.run(EventQueue.java:664)
       at java.security.AccessController.doPrivileged(Native Method)
       at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
       at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:87)
       at java.awt.EventQueue$4.run(EventQueue.java:680)
       at java.awt.EventQueue$4.run(EventQueue.java:678)
       at java.security.AccessController.doPrivileged(Native Method)
       at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
       at java.awt.EventQueue.dispatchEvent(EventQueue.java:677)

It would be great if all the tool tips (especially ones over error icons, but 
really all of them) remained up instead of disappearing after a few seconds.  

Kivanc: Make Relation and DataSource abstract, create 2 classes called 
HGRelation and HGDataSource.

One issue is that if authentication credentials expire, Crystral will keep 
banging the remote server with requests and set off security alarms.  

If a pull results in an error, it should stop refresh on that repository and 
let the user know (likely via a tool tip on the X icon).  The user should then 
be able to re-enable a repository, once fixing the pull problem.  

"After I click "File > Refresh" in the Crystal window, the menu item turns
to a gray "Refreshing..." for only a moment, then changes back to black
"Refresh" without actually refreshing the Crystal window.  Soon thereafter,
the Crystal window did refresh, though I don't know if it was because of my
action or the regularly scheduled periodic refresh."

There should be a way from within Crystal to clear the cache.  Menu is probably 
best, but maybe a button.

Right now, loadXMLPreference loads only from the default location.  

This should be refactored to load from any File and then call that with a 
default location.  

The grid in the config is all over the place.

If a project in the config uses a VC that is not installed, crystal may 
gracefully deactivate that project, rather than insist a proper path to the VC 
executable is given.  

It's unclear how to exit the configuration editor and apply changes.

Similarly, it is unclear whether or not Crystal must be restarted when the 
configuration is edited using the GUI

dataSources in a single project should have unique shortNames, but it's 
possible to create 2 with different names and change them to have the same 
name.  

Crystal should:
1. not crash if either is missing (I suppose even if both are missing)
2. exit gracefully if a project requires git (respectively hg) and it is not 
installed.

If the master repository (likely others too) has two heads, Crystal reports a 
red X with that repository and a weird tooltip ("crystal is having trouble 
comparing...").  

This maybe should be grouped under the bigger issue of Crystal not dealing with 
branches (although it is OK with a multi-branch repo, but not multi-headed on a 
branch repo).  

Allow clearing of cache for a single project (row in Crystal table).
UI: right clicking on a row and getting a menu to clear the cache of just that 
project?

Mousing over the "About" menu item makes it disappear (though it is still 
functional). Clicking on "About" makes it disappear as well (until the about 
window is closed).

(This seems to be particular to my set up since Yuriy can't reproduce this, 
perhaps this is an OSX -only issue).

Changing the config should halt the refresh, put crystal in a happy stopped 
place, and then return to a reload place.  

(identified by Kivanc in a code review)

The short Name of a repository cannot handle the following characters
\/ ;:

The reason for this bug is that Crystal uses the shortName in the path for the 
project cache.  I replaces these characters with _.  

Each entry in the configuration should be checked for validity and tell the 
user if it is invalid.  

Running git on windows returns error codes *most* of the time.  

Turns out, while only git.cmd is in the path on windows, it somehow redirects 
the path in which is it being executed when executed from within java.  
Replacing cmd with bin and searching for the git.exe executable solves this 
problem.  

When exiting the configuration window, the window should know whether there 
were any changes.  

Add the ability to add compile and test commands from within the config window.

Right clicking on a project name (or anywhere on the row?) should allow you to 
add a new repo to the project.  

What steps will reproduce the problem?
1. Add a http clone that uses the attached hgignore file

What is the expected output? What do you see instead?

ERROR 2011-10-09 16:15:21,861 (ConflictDaemon.java:116) - Runtime Exception 
caught while getting state for: 
MASTER_HG_http://code.google.com/p/rt-refactor-suggest
Unexpected line in the log file: files:       .hgignore pub/proposal/.hgignore
java.lang.RuntimeException: Unexpected line in the log file: files:       
.hgignore pub/proposal/.hgignore
    at crystal.server.HgLogParser.parseLog(HgLogParser.java:145)
    at crystal.model.RevisionHistory.<init>(RevisionHistory.java:50)
    at crystal.server.HgStateChecker.getRelationship(HgStateChecker.java:295)
    at crystal.client.ConflictDaemon.calculateRelationship(ConflictDaemon.java:83)
    at crystal.client.CalculateProjectTask.doInBackground(CalculateProjectTask.java:113)
    at crystal.client.CalculateProjectTask.doInBackground(CalculateProjectTask.java:23)
    at javax.swing.SwingWorker$1.call(SwingWorker.java:277)
    at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
    at java.util.concurrent.FutureTask.run(FutureTask.java:138)
    at javax.swing.SwingWorker.run(SwingWorker.java:316)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
    at java.lang.Thread.run(Thread.java:619)

What version of the product are you using? On what operating system?

0.2.20110729

This has been verified on Linux and Windows.  It is very evident when the 
refresh rate is set to be frequent (e.g., 1 second).  

Make sure that the icon never changes to something else (e.g., the clock) 
during the calculation.  

[deleted issue]

Sometimes, a version control operation tried by Crystal fails, or produces
output to standard error.


1.  If the output is only to standard error, and the exit status is OK, then
does the user really need to be informed?  (I'm not sure what all the cases
are; it would be good for you to collect logs and find out all such
occurrences.)


2.  Right now, the user is given two options:
   * ignore the repository
   * re-clone

2.1.  I am not sure that the "ignore" option really ignores; even though I
always choose that, I haven't seen the red X in a very long time.

2.2.  There is not a "retry" option.  But, I frequently get transient
errors.  For example, suppose that Dropbox is in the middle of coping
changes from a remote repository to my local Dropbox copy.  Then, the
Mercurial repository may temporarily be in an inconsistent state.  Trying
again immediately or after a short wait would probably result in success,
without any need to distract the user.

Crystal tries to write to the config file in 2 situations:

1. When the user edits the configuration.
2. When crystal discovers some non-standard (but still parsable) XML.  

If the .conflictClient file is write protected, Crystal crashes and throws 
exceptions.  Instead, in case 1, Crystal should display a nice error message, 
and in case 2, Crystal should just ignore the error (log it) but not display 
any error and not throw any exceptions and not crash.  

Here is the users bug report:
"It's smart to make one's .conflictClient.xml file read-only, because
Crystal has an antisocial tendency to overwrite it if it has any syntax
error.  But, when Crystal tries to overwrite it, it crashes with a long
stacktrace because the file isn't writeable."

Adding a new repo int he configuration editor puts items in the wrong order.

Crystal uses outdated icons

It seems that after clearing the cache, or when starting Crystal without a 
cache, some icons appear as X the first time.  In my experience, these go away 
after a refresh.  

Crystal re-saves the config whenever a field is edited in the configuration 
window. This is strange -- typically editing a config can be cancelled without 
anything being changed. I think it would help to have a "Save' and "Cancel" 
buttons at the bottom of the window so the user could commit the changes or 
abort the process altogether.

The word "daemon" does not appear anywhere in the manual. Yet, "Disable daemon" 
is prominently placed in the menu. Is it that necessary? If yes, then I would 
rename it to something like "Disable polling for changes" or similar text.

Running Crystal's PreferencesGUIEditorFrame main method (originally intended 
only for manual testing) erases the config file.  

We should just remove this method.  

On OS X, a running application instance of Crystal is named 
"com.simontuffs.onejar.Boot". This is meaningless and confusing. It should be 
just called Crystal or have Crystal in its name.

Crystal currently sleeps a long time between refreshing.  I think it's
reasonable to check for changes to remote repositories only periodically.
However, it would be possible/desirable to check for changes to local
repositories much more frequently.  In particular, I propose that Crystal
should check every (say) 5 seconds whether the timestamp on any
locally-available .hg directory (which might be my copy, or one of the ones
to which I am comparing) has changed.  If so, then Crystal re-computes any
relevant relationships (or maybe it just recomputes the whole row for
simplicity).

This is motivated by the fact that I am constantly wondering whether
Crystal is incorrect, because I do a local operation and, a little while
later, see that Crystal's display is still wrong.  It would be better to
make Crystal feel more responsive -- certainly to things that the user has
done, but really to anything on the local file system.

Right now, entering an "hg commit" local state, makes the screen very wide.  
It'd be good if the icons could be variable width.  

There are 5 packages in Crystal:
crystal
crystal.client
crystal.server
crystal.model
crystal.util
plus there is crystal.client.images that contains various images that Crystal 
uses, but no code.  

The crystal package contains only a Constants.java class with various global 
variables.  

I believe the original intent of the crystal.client package was to contain the 
front end, though this is heavily not true anymore.  
I believe the original intent of the crystal.server package was to contain the 
back end, though this is heavily not true anymore either.  The two ends are 
spread around these two packages without any meaningful, to me, rhyme or reason 
for the separation.

The crystal.model package contains classes that describe objects related to 
repositories, relationships, states, and other information on repositories.  

The crystal.util package contains classes that execute command-line operations, 
deal with logging, and allow some GUI stuff like multiline tool tips.  

Some anonymous classes are undocumented.

Right now, after changing the config, you have to quit and restart crystal.  It 
would be better if the settings reloaded without restarting.  

Fix the spelling of "Committers" in the tool tip (currently, it says 
"Commiters".

I had to textually search the manual to figure out what the difference is. It 
would be nice to include the hollow icons next to their solid variants so that 
it's clear that these icons are normal, and do exist, and mean something 
different from the others.

The crystal main window should not change size during execution (unless someone 
changes the configuration).  To do this:

The left most (name + local state) cell should be the size of that cell with 
"hg commit" in it (even when "hg commit" is not showing).

The rest of the cells should all have width equal to the max natural width of 
all those cells.  Thus the grid for these (non-left-most) cells will be 
regular.  

There should be a bit more white space between the cells names.  This should be 
fixable simply by adding a prefix and suffix space to the repo names when added 
to the JLabels.  

If possible, it would b good to put a box around each project row.  Or a single 
line separating each project row.  This should help with the problem of 
identifying "whether a label applies to the icon above or below it."