brynm / icheckbox Goto Github PK

What steps will reproduce the problem?
1. Use IE 7 or 8
2. Use JQuery 1.4.4
3. Animate check on or off

What is the expected output? What do you see instead?
IE should display the checkboxes appropriately but instead Jquery throws an 
invalid argument exception.

What version of the product are you using? On what operating system?
This occurs in IE version < 9

Please provide any additional information below.
The plugin attempts to set a css property that does not exist in earlier 
versions of IE, backgroundPosition. These earlier versions however do have 
backgroundPositionX and backgroundPositionY. Changing the on/off callback 
functions to the following corrects the issue in all tested browsers:

iCheckOff: function (elem , atime, animOnly) {
                        atime = typeof(atime) == 'number' ? atime : settings.switch_speed;
                        animOnly = animOnly== true ? true : false;
                        atime = parseInt(atime) > 0 ? atime : 1;
                        if ( animOnly == true ) {
                            jQuery(elem).animate({backgroundPositionX: settings.switch_swing+'px', backgroundPositionY: '0px'}, atime, 'linear');
                        } else {
                            jQuery(elem).animate({backgroundPositionX: settings.switch_swing+'px', backgroundPositionY: '0px'}, atime, 'linear', function() {
                                    var cB = jQuery(jQuery(this).parent()).find('input');
                                    jQuery(cB).removeAttr('checked');
                                    jQuery(cB).change();
                                });
                        }
                    },
                // animate on function
                iCheckOn: function (elem, atime, animOnly) {
                        atime = typeof(atime) == 'number' ? atime : settings.switch_speed;
                        atime = parseInt(atime) > 0 ? atime : 1;
                        if ( animOnly == true ) {
                            jQuery(elem).animate({backgroundPositionX: '0px', backgroundPositionY: '0px'}, atime, 'linear');
                        } else {
                            jQuery(elem).animate({backgroundPositionX: '0px', backgroundPositionY: '0px'}, atime, 'linear', function() {
                                    var cB = jQuery(jQuery(this).parent()).find('input');
                                    jQuery(cB).attr('checked', 'checked');
                                    jQuery(cB).change();
                                });
                        }
                    }

The demo page loads the jquery.iphone-switch.js from Daniel LaBare. Yet, it is 
never used while giving the impression that it is necessary for the iCheckbox 
plugin to work. As far as I see it, it is not.

Only a slight inconvenience but I'd remove that JS file.

Please explain how the new feature would appear to an end-user:

A disabled checkbox should support having a different look and style that can 
be defined via CSS 
by the developer.

As a bonus, perhaps the end user is greeted with a dialog or other feedback for 
attempting to use 
a disabled control.

Please explain how the feature should be implemented in the JS source:
This requires:
1. A new optional style and the appropriate settings. This MUST be optional and 
should have 
some default that leverages the existing settings (perhaps an opacity change to 
denote "disabled" 
or something similar.
2. Code to support detection and use of a "disabled" state.
3. A set of defaults that get overridden by the developer when they choose to 
implement the 
state themselves.

If you have a code sample for the feature or have a diff of it being
implemented, please include it: