bswinnerton / launchbar-github Goto Github PK

Using this action: https://prenagha.github.io/launchbar/updates.html.

Given that this tool was written in Javascript, it might be nice to add exception tracking to see where people are running into problems.

It looks like Sentry might have a Javascript offering.

While testing out #39, I ran into the following issue (using version 4659587 of github.lbaction):

I'm often trying to find various GitHub Project boards and find them difficult to navigate to. It'd be great if on the organization / repo menus you could enumerate all of the projects and fuzzy search them.

It would be nice to expose the version from the Settings view.

@jasonrudolph suggested an idea in jasonrudolph@d896721#commitcomment-20974402 to go straight to:

• My Repositories
• My Pull Requests
• My Issues
• My Gists

This issue is to track that feature request.

I can't reproduce this in every case, but nonetheless I do sometimes see this when running <user> gist:

After #30 was merged, the screenshots in the README.md became out of date. Let's update them to the latest and greatest.

When I invoke the action, hit spacebar, and then type justinmimbs/, I don't get a list of the user's repositories. If I type justinmimbs and then select the View Repositories action, I only get the View All Repositories option.

We'll want to return a special sort of message when:

• The action is rate limited
• The server responds with an application error
• The server responds with an authentication error

For example in:

It'd be nice to see at a glance which repositories are forks.

Given that this tool was written in Javascript, it might be nice to add anonymized analytics to see which views are most popular to help drive the product forward.

It'd be great to test the GitHubLB class. This could act as the "integration test" to ensure that various different inputs expose the correct outputs.

We'll just want to stub out any calls to Action or LaunchBar.

Things has support for URI schemes. It'd be really neat if you could paste in a GitHub URL and have LaunchBar fetch the title via an API call (using the GraphQL API's top-level resource field), and then add it to Things.

In other words, when a user enters a URL like the following into LaunchBar:

https://github.com/bswinnerton/launchbar-github/pull/91

...have it automatically convert it to something like:

Review bswinnerton/launchbar-github#91 "Use first class hide() function from LaunchBar"

With the full link back to that Issue / PR.

In addition to #25, it would be nice if there was an option in settings to update this action to the latest version.

When trying to type in a url like rails/rails#123 into LaunchBar and the GitHub action is targeted, an error is returned.

For some reason immediately after you shorten a link, LaunchBar does not close, you have to hit ESC. I'd love to find a way around that.

I'm not in love with the idea of having to generate a token by hand on https://github.com/settings/tokens/new and then set it with !set-token <token>. Instead (or perhaps, in addition to), it'd be nice if there was a website that offered a convenient way for users to download the action and set the token. This website could allow for users to sign in with GitHub using the OAuth Web Application Flow and generate a token on their behalf. Then, with this token, the website could craft a URL that looks something similar to:

x-launchbar:action/com.github.LaunchBar.action.GitHub/setToken?token=<token>

Which when clicked would invoke runWithURL(url, details) using the Action URL Script functionality in LaunchBar. From there, we could execute the regular setToken functionality.

Huge shout out to @marcomasser for the wonderful suggestion ✨.

I'm not sure if this is possible, but it'd be great if the action could start fuzzy searching for repositories right after the user types something like bswinnerton/ (which would require an API call).

I think this should be possible using the Suggestions Script functionality. We'd just want to make sure that it doesn't start executing until after a / is typed in order to avoid a collision with #22.

For example with the link https://developer.github.com/changes/2016-11-29-user-management-webhooks/.

When anyone submits a pull request, there should be a test that executes to ensure that the execution of script/build does not create a change in Contents/Scripts/bundle.min.js.

This should be fairly straightforward, we'll just want to store the GitHub base URL in the LaunchBar preferences.

With at least a one hour TTL (to align with the GitHub rate limit).

For example, after typing:

And hitting command + enter,

It'd be great if it automatically went to the appropriate page (similar to what this would do):

Unfortunately there's no LaunchBar API to remove files, but one thing that we could do is iterate over the files that exist in the cache directory and zero them out.

When the token doesn't have the appropriate scopes, the action can't access the API and it's not apparent why.

Stale JSON cache files are never cleaned up.

When not signed into the application and you search for a commit, the following error appears:

Along with this notification:

As reported in #8 (comment):

@bswinnerton: When I enter a owner/repo name (e.g., apple/swift) and hit command+enter, the LaunchBar window disappears, but it doesn't open the repo:

Is there any trick to getting this to work correctly? If there's additional information I can provide, please let me know.

Using version ad78ad7 of this action:

This plugin looks really useful. Thanks for your work on it!

However, the GitHub permissions it asks for after clicking Install seemed a bit, well, permissive 😄. For example, it wants read/write for user profile data. Are all of the permissions the plugin asks for required, or can they be trimmed down a bit?

The manual instructions to get a token make it sound like the actual permissions it needs are less.

For now, I'll give it a go with the manual install.

Identical to #62, but with pull requests.

When typing out something like apple/swift, ideally that repository would show up first in the repository list. That is not the case right now:

This causes problems for #88 since users will want to hit ⌘ + Enter to go directly to the repository in question rather than navigate down.

Observed behavior

If you search for a commit that is not part of a pull request (e.g., 212d9cf4631cd175cc45e1930d141768a87b45f8), it results in the following error:

Expected behavior

If the commit isn't part of a PR, I was thinking that it would take you straight to the commit itself. For example, searching for 212d9cf4631cd175cc45e1930d141768a87b45f8 could take you to:
212d9cf

If that's not feasible, it would be nice to gracefully handle the error and inform the user that there is no pull request with the given commit.