Not working with libextobjc/EXTScope about spritekit-components HOT 6 CLOSED

I am not a core contributor just a user of this framework. For those of us not familiar with libextobjc and ETXScope it might be helpful to elaborate on exactly what is not working. An example would also be helpful, from your the issue title it is not even clear that SpriteKit-Components is actually at fault.

from spritekit-components.

Sorry, I put this quickly and certainly is not very clear. The library libextobjc #define onExit, so that clashes with your onExit method.

This library is used usually because of @weakify(self)

I would be interested to have both in my project, you could rename those methods? Want me to do it on a pull request for your comfort?

Thanks! :)

from spritekit-components.

Okay I see what you mean, I am using ReactiveCocoa which also has these extensions, and it just so happens onExit isn't a component method I have had to use in any conflicting scenario. As these frameworks become more popular this problem will only increase.

I assume the only way to avoid this would be to rename onExit method? Doing so would be an API breaking change, and would do so without any direct trace, existing onExit code would just be never called.

If the change is accepted my vote would be to rename both onExit and onEnter selectors for the sake of consistency. Perhaps onExitScene/onEnterScene would be a good name.

We should definitely highlight this change in the README.md also.

from spritekit-components.

Fixed! :) Check it out! #10

from spritekit-components.

I agree with @nacrossweb and wouldn't want to change the API requiring everyone to refactor their projects unless it really makes sense, especially since it already mirrors cocos2d with which a lot of devs are already familiar.

We could define a preprocessor macro for a compatibility mode (such as SKC_COMPATIBILITY) that when enabled in the build settings will change onExit to onExitScene, and onEnter to onEnterScene.

It will make the code a little messy with some extra macros or ifdefs, but won't require everyone using the library to refactor all their projects with the next update. Thoughts?

from spritekit-components.

Good solution, thank you very much! 👍 @nacrossweb @levilansing @buddingmonkey

from spritekit-components.