busser / murmur Goto Github PK

Murmur 0.6 seems to have a console log related to forwarding children to child processes. For our usecase it's not interesting to have these logs in development and production environments. Any chance this can be moved perhaps behind a -debug flag or similar?

Whisper's internal clients to various external secret managers are thread-safe: they can fetch multiple secrets concurrently. However, whisper currently uses these providers sequentially.

When whisper needs to fetch a large number of secrets, fetching them concurrently would improve overall runtime.

When contributors fork the repo and open a PR, Github Actions workflows fail:

The workflow fails to authenticate to GCP:

The error message is:

Error: google-github-actions/auth failed with: retry function failed after 4 attempts: gitHub Actions did not inject $ACTIONS_ID_TOKEN_REQUEST_TOKEN or $ACTIONS_ID_TOKEN_REQUEST_URL into this job. This most likely means the GitHub Actions workflow permissions are incorrect, or this job is being run from a fork. For more information, please see https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

The problem is that the workflow attempts to authenticate to GCP through OIDC. This requires the id-token: write permission. We set this permission correctly in the workflow configuration file, and workflows work as expected for PRs that are not from forks.

However Github enforces a "Maximum access for pull requests from public forked repositories" of id-token: read, as detailed in this documentation.

Currently a maintainer must pull the source branch from the fork and manually run the end-to-end tests in order to know if the proposed changes break anything.

Ideally we want approved PRs to run end-to-end tests so that contributors can get quick feedback on their contribution.

To track interest and discussion on adding a vault provider.

Hello 👋

The AWS sdk version is not using the latest one which is v2.

You should migrate to this one because they have versioned their sdk by modules which allows for a smaller binary overall.

I have a use case where I want to use murmur in golang integration tests within Visual Studio Code. VS Code has an option to set a .env file e.g. go.testEnvFile in settings, but as far as I can tell there isn't a way to run murmur before the test or debug is started from within the ide e.g. when clicking "debug test" above a test function.

If ResolveAll is exposed outside of internal I can call it from within the tests and manually set the env vars to their secrets, would you be open to moving this outside of the internal package?

If a developer specifies the same secret across multiple envvars, and perhaps applies different filters to those variables, whisper should ideally not query the root secret store multiples times. e.g.

SECRET1=awssm:12345|somefilter1
SECRET2=awssm:12345|somefilter2
SECRET3=awssm:12345|somefilter3

Ideally this would generate one query to AWS SM for 12345 and then apply the three different filters to generate the three different output variables.

We have long-term plans for a Kubernetes mutating webhook that injects the entrypoint into pods. A quick win would be to provide a Kyverno policy that does just that.

Currently murmur logs very little and doesn't have options to enable more or less logging.

With Go 1.21's new structured logging package, we should be able to add robust logging without adding any complex dependencies to murmur.

Love this idea, thanks for creating this package. Was googling for "Berglas for AWS" and hoping to find exactly this package.

Using the example Dockerfile:

Step 1/3 : FROM alpine
 ---> c059bfaa849c
Step 2/3 : COPY --from=ghcr.io/busser/whisper:latest /whisper /bin/whisper
invalid from flag value ghcr.io/busser/whisper:latest: Head "https://ghcr.io/v2/busser/whisper/manifests/latest": unauthorized

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• ⬆️[Go] Update module github.com/Azure/azure-sdk-for-go/sdk/azidentity to v1.6.0 [SECURITY]
• ⬆️[Go] Update Go packages (github.com/Azure/azure-sdk-for-go/sdk/azcore, github.com/aws/aws-sdk-go-v2, github.com/aws/aws-sdk-go-v2/config, github.com/aws/aws-sdk-go-v2/service/secretsmanager, github.com/scaleway/scaleway-sdk-go, github.com/spf13/cobra, k8s.io/client-go)
• ⬆️[Terraform] Update Terraform providers (aws, azuread, azurerm, github, google, google-beta, scaleway)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

AWS's default behavior is to store secrets as a JSON object with lots of secrets as key/values on that object. It'd be nice to be able to pull an individual value from that secret object. Something like

awssm:arn:aws:secretsmanager:us-west-2:1111111111:secret:mysecretobject.somepassword

It would be handy to have a flag for whisper that causes it to produce a summary of what secrets it loaded successfully/unsuccessfully to the console

If Murmur receives a signal, like SIGTERM for example, then it won't pass it on to the underlying command.

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: .github/renovate.json5
Error type: Invalid JSON5 (parsing failed)
Message: JSON5.parse error: JSON5: invalid character 'a' at 18:3