Comments (19)
hristo-kanchev
commented on May 9, 2024
1
Actually just finished this today, @gaearon 😆
I'll be creating the PR tomorrow morning. 🚀
from react-devtools-experimental.
bvaughn
commented on May 9, 2024
1
Sounds great! Thanks!
…On Sun, Apr 7, 2019, 11:05 AM Hristo Kanchev ***@***.***> wrote:
Hey @bvaughn <https://github.com/bvaughn>.
Absolutely no problem if you want to make changes to the PR. Go for it! 🚀
The next time I'll be able to take a look at this is probably next
Friday/Saturday 😭 , so I think it would be better if you make the
necessary changes.
If you don't have time, give me a shout and I'll try to find time during
the working week.
Thanks!! ✋
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABznaoYqdU7_xRxsBJONwrGqFJMZaXkks5vejNSgaJpZM4bJ9tZ>
.
from react-devtools-experimental.
gaearon
commented on May 9, 2024
1
I get this on master. Is it expected?
It doesn't happen every time. Happens if I enter and exit owner mode a few times.
from react-devtools-experimental.
hristo-kanchev
commented on May 9, 2024
I'll take a look at this one over the weekend. 🎸
from react-devtools-experimental.
hristo-kanchev
commented on May 9, 2024
Short demo of my work so far.
from react-devtools-experimental.
bvaughn
commented on May 9, 2024
Ooh nice! That's looking promising!
from react-devtools-experimental.
hristo-kanchev
commented on May 9, 2024
Hey @bvaughn.
Just letting you know that I'm still working on this.
I've been quite busy lately, so I wasn't able to give this issue much attention, all though I think I've identified all edge cases 🚀
from react-devtools-experimental.
bvaughn
commented on May 9, 2024
No hurry. Thanks for the update.
…On Thu, Mar 28, 2019, 7:42 AM Hristo Kanchev ***@***.***> wrote:
Hey @bvaughn <https://github.com/bvaughn>.
Just letting you know that I'm still working on this.
I've been quite busy lately, so I wasn't able to give this issue much
attention, all thoughI think I've identified all edge cases 🚀
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABznZMBTm2I0x2S4NRO3Ooi19ZyCIsbks5vbMLqgaJpZM4bJ9tZ>
.
from react-devtools-experimental.
hristo-kanchev
commented on May 9, 2024
Update:
This feature is almost finished.
Just need to refactor and fix one small issue when resizing.
I made a short video if anyone is interested (feedback is greatly appreciated) to see it before I submit my PR.
from react-devtools-experimental.
bvaughn
commented on May 9, 2024
Looking nice!
from react-devtools-experimental.
gaearon
commented on May 9, 2024
@hristo-kanchev How's it going? Want to get any help on this?
from react-devtools-experimental.
bvaughn
commented on May 9, 2024
Hey @hristo-kanchev! The UI you shared looks great 😄 Thanks!
Before I get too deep into the PR, I wanted to ask your preference. Would you prefer I make any tweaks/edits to the PR myself? Or would you prefer I leave feedback and let you make them?
No real preference from my side. Didn't want to seem like I was asking too much by leaving requests for changes. Also didn't want to look passive aggressive by just making them myself. 😅
from react-devtools-experimental.
bvaughn
commented on May 9, 2024
I've got a little time this morning to mess with it, so I think I'm going to just make a guess that it's okay for me to build on top of what you've got 😄 hope it's okay!
from react-devtools-experimental.
hristo-kanchev
commented on May 9, 2024
Hey @bvaughn.
Absolutely no problem if you want to make changes to the PR. Go for it! 🚀
The next time I'll be able to take a look at this is probably next Friday/Saturday 😭 , so I think it would be better if you make the necessary changes.
If you don't have time, give me a shout and I'll try to find time during the working week.
Thanks!! ✋
from react-devtools-experimental.
bvaughn
commented on May 9, 2024
Is it expected?
Nope
from react-devtools-experimental.
hristo-kanchev
commented on May 9, 2024
@gaearon @bvaughn I'll check it after work today. Apologies.
from react-devtools-experimental.
bvaughn
commented on May 9, 2024
No worries. I probably broke it with one of my tweaks. I'll follow up tomorrow.
from react-devtools-experimental.
hristo-kanchev
commented on May 9, 2024
Hey @bvaughn It seems that the changes in the OwnerStack.css vanished. 😆 Can you take a look? Also, It I forgot to add max-height the the .Dropdown class in the OwnerStack.css. Can you add that as well? Thanks!!
from react-devtools-experimental.
bvaughn
commented on May 9, 2024
Hey @bvaughn It seems that the changes in the
OwnerStack.css
I don't know what you mean. What changes?
Also, It I forgot to add
max-heightthe the .Dropdown class in theOwnerStack.css
I already added one when I was tweaking things 😄
from react-devtools-experimental.
Related Issues (20)
- Truncation of key prop in GUI HOT 1
- Improve HOC search UX HOT 1
- Profiling does not work in Chrome HOT 4
- Improve globaly state/props edition. HOT 3
- Don't show "context" for classes without either contextType or contextTypes HOT 9
- Doesn't scroll down to the component when inspecting HOT 10
- Potential issue when using typescript. HOT 3
- node type filtering HOT 4
- Some memo components displaying as Anonymous HOT 6
- Hook names grabbing solution w/o changing api HOT 1
- Inspecting complex values HOT 5
- feat: support search by prop, state, hooks HOT 1
- Style editor doesn't support single quotes for string values HOT 2
- The Context hook is not shown unless another hook is also presen like useState or useEffect HOT 7
- can not edit state with version `2f1c100` HOT 2
- Document/allow custom panel/extensions HOT 1
- Occasional FOUC when loading DevTools HOT 1
- Tooltips appear to be Times New Roman in Firefox HOT 2
- An easier way to see all siblings HOT 1
- Fully disable 0.14 support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-devtools-experimental.