cadrach / lol_ise Goto Github PK

I have invested a fair bit of time into creating an item set. However, when I downloaded it off the website, then re-uploaded (to check if it was successful) the "Config" folder I just downloaded, it was lacking an entire item set. Please fix this, as I did not wish to have to downgrade to the legacy client to update my item sets.

In the Config foulder of my game I have a file called "ItemSets.json". It contains every item set I made in the legacy client. In first the title and things like associated Champions and Maps are declared and the blocks with their names and their items (items are there as ID) are spelled out. would it be possible for you to come up with a fifth uploading option that lets me use my old item sets and converts them into kind.
ItemSets.zip

404 (broken link) from clicking the link on the description of "Spellthief's Edge" (or any upgrade)

http://lol.item-set.com/frostqueenslinequestreward

Browser (Chrome, Safari, Internet Explorer) and Version

Provide a Screenshot when possible

Steps to reproduce

• upload item set
• start LoL
• modify item set in LoL
• go to http://lol.item-set.com/
• try to reload the modified item set
• the old unmodified set is still there

I cannot find a way to clear the existing item sets in the editor, nor how to reload the item sets.

The new item set editor in the client only allows a maximum of 20 item sets. So it's basically crap. Please please please, don't quit updating this awesome tool, because I'm still using it. :)

Happens in Firefox and Chrome.

When I try to add a new global set, an error gets logged to the console, saying "cannot read property blocks of undefined". I also tried this yesterday and the error was different, saying something about angular.copy not being found I think.

Browser (Chrome, Safari, Internet Explorer) and Version

google chrome Version 55.0.2883.95 (64-bit)

Provide a Screenshot when possible

I create this item set:

and download this json file:
{"title":"sejuani custom","map":"any","mode":"any","type":"custom","priority":false,"sortrank":null,"champion":"Sejuani","blocks":[{"type":"startingjungle","recMath":false,"items":[{"id":1039,"count":1},{"id":2031,"count":1},{"id":3340,"count":1},{"id":2055,"count":1}]},{"type":"early","recMath":false,"items":[{"id":"1413","count":1},{"id":1401,"count":1},{"id":1001,"count":1},{"id":"3136","count":1}]},{"type":"essential","recMath":false,"items":[{"id":3742,"count":1},{"id":"3065","count":1},{"id":"3151","count":1},{"id":"3009","count":1}]},{"type":"finish","recMath":false,"items":[{"id":3075,"count":1},{"id":3143,"count":1},{"id":3083,"count":1},{"id":"3026","count":1},{"id":"3512","count":1},{"id":3102,"count":1},{"id":"3190","count":1},{"id":"3158","count":1},{"id":"3111","count":1}]},{"type":"consumables","recMath":false,"items":[{"id":2138,"count":1},{"id":"3363","count":1},{"id":"2139","count":1},{"id":"3364","count":1}]}]}

but these are the items that show up in game:

(the order of some of them might be slightly different, but the basic idea is that not all the items show up, some blocks are completely missing, etc.)

I was looking for mana related items and couldn't find the category to check, expecting "Mana" to be available.

I noticed there was MP and also "Magic Penetration" categories. I checked under MP and found what seem to be the Mana items. So, I wonder if this was an oversight or if there is some "MP" for Mana "something" that I don't know about. :-)

It'd be really helpful for me if clicking on an item would not only show the build path for that item, but also link to those smaller items. For instance, a Giant's Belt is part of the build path for a Warmog's. If I click on the Warmog's, I'd like to be able to see the build path for it. And on top of that, I'd like to be able to interact with the smaller items like the Giant's Belt. You could either make those icons clickable so when you click on the Giant's Belt in the Warmog's tooltip it selects the Giant's Belt on the main page, or you could just make those tooltip icons draggable so you could take the Giant's Belt from the Warmog's tooltip and drag it to your item set. This would mean that you wouldn't have to hunt down the smaller items once you decide on a legendary to build into.

I'd also really love a filter for legendary items, or any end items, really. I like to think of items in terms of a. items that build into other items and b. finished items. It'd be nice if you could filter out all the smaller items and just see the finished items.

With pre-existing builds that include multiple champions, a lot of them are missing

Browser Chrome

When you block a site from creating additional dialogue pop ups and try to delete an item block it wont allow you because you haven't said that its OK. instead of an alert you need to use something else so people can block the additional dialogue without issue.

Browser (Chrome, Safari, Internet Explorer) and Version:

Firefox Nightly(happens on Stable version too.). There's no problems downloading item sets on Chrome browser, Stable and Canary versions work fine.

Provide a Screenshot when possible

https://puu.sh/uUl7s/897b7077e9.gif - Gif that shows you what happens when you click download in Firefox browser.

Browser (Chrome, Safari, Internet Explorer) and Version

Google Chrome Version 55.0.2883.87 m

Provide a Screenshot when possible

Steps to reproduce

There is no button to clear all item sets, only individual item sets.

Clearing the Cache does not remove the item sets either (see attached image).

In order to clear all of the item sets (other than by pressing the individual delete buttons), I needed to clear the "Local and Session storage" in the Chrome Developer tools (accessed by pressing ctl+shift+I

(second screenshot, of this button, follows)

Steps to reproduce:

1. Set up some custom hot-keys in game.
2. Upload /Config directory to online Item Set Editor
3. Make changes using web interface.
4. Download and install new item set.
5. Custom hot-keys from step 1 no longer set.

Browser (Chrome, Safari, Internet Explorer) and Version

Chrome Version 57.0.2987.133 (64-bit)

Steps to reproduce

I uploaded a zip file that i created earlier and when i download the zip file again it has the following structure:

Lol_Item_Set.zip\Config\Global\Recommended\Config\Global\Recommended\Global0.json

I think it remembers the file structure in the old zip file and just adds another \Config\Global\Recommended\ . Only in the last Recommended folder are .json files.
I uploaded the wrong zip file again and then downloaded the sets and it adds another batch of those three folders. It shows the sets in the website just fine.

This is one annoying omission from legacy Item Set Creator. One can only move an item between blocks by dragging and cannot copy.

Reason
One could have one build in one Block and want to create a similar one on another Block and would want to copy most items to new block. As it is now, we would have to search for all the items by filtering the whole item icon list or pick the item from all the possibilities. Dragging them would be faster and more convenient to user.

Option #2
depending on effort involved. Highlight Item on the All Items middle display when yo click on an item in a block. Then the user can see where it is and drag it to a different block.
First option involves only Ctrl+Drag. Option #2 involves Click, locate item under "All", then Ctrl+Drag.

Note/question:
Is there a forum for discussing your app's usage, advantages, things users have done, doubts and kudos in general? There should be. I would like to discuss some things about user documentation (perhaps provide enhancements), Riot's folder structure for items, etc.
Thanks for a great tool.

Browser : Chrome

When you have too many champs who share a set, the champs take up all the window and you can't see / edit the set anymore (had to go into the inspector and put "display: none" on the champions div to be able to edit the set again).

Cheers and thank you for this amazing tool ! :)

Chrome, have uBlockOrigin and tried disabling it - same issue.
Chrome version 57.0.2987.133 (Official Build) (64-bit)

Made an item set for zed, clicked download, nothing happens. No popup, no download, literally nothing. Tried to click gear in top right corner and download .JSON file and still nothing

Works fine using Edge

Browser (Chrome, Safari, Internet Explorer) and Version

Chrome (Edit: Version 58.0.3029.81, updated version & issue was retained)

Provide a Screenshot when possible

Steps to reproduce

Have a ton of .Json files. Easy to do if you have a lot of non-champion specified item sets due to how riot documents these. Each of those is granted a .json file for each champion, so if you have 50 of those like me. That's 50 x 136 files. Or somewhere around 6,750 bonus Json files to clog up the data. If you want to delete every item set, search "RIOT_ItemSet_" in your config folder(a copy of the config folder to be safe) and delete every item that appears in the search.
Note: The differently named item sets at the top of Capture2.png is from the "Lol Item Creator" I used, thinking it would let me create my itemsets. It just made more recommended item builds... They were somewhat useful so I kept them anyways though. I don't have anywhere near 30 item sets on Akali by the way. I have like 1 other than those 5 generated ones.

Browser (Chrome, Safari, Internet Explorer) and Version

Tested on Chrome 57 and Firefox 51

Provide a Screenshot when possible

Steps to reproduce

1. Drag /Applications/League of Legends.app/Contents/LoL/Config to window.
2. Check JS console output.
3. Wrong format, missing: type,map,mode,blocks,champion

I would like to Import Itembuilds from OP.GG with 2 options:

1st. Higest Winrate Build.
2nd. Highest Pickrate Build.

A example for maneging the items and slots would be:

Highest winrate starting items -> highest winrate core Build slot -> The 3 highest winrate boots in boots slot -> The 6 highest winrate Items in a "good items" slot. -> the basic consumeable slot.

I noticed some items didn't appear ingame while I was sure I put them in my sets.
After looking at the files created by the item set editor, I find out what was the issue.
The correct format for JSON is {"id":"3157","count":1} but this item had this markup : {"id":3157,"count":1}.
I noticed this for the Zhonya and te Hextech Gunblade.

Some people have their installation under C:\Riot Games since their first installation, like me.

Perhaps help / documentation should mention that possibility for people who cant find installation under Program File(x86).

Thanks.
(And thanks for your contribution)

Browser (Chrome, Safari, Internet Explorer) and Version

Chrome

Provide a Screenshot when possible

Steps to reproduce

Make an item set on the website.
Download the new LoL client.
Install as told by the readme
Go into a custom match.
Expect to be able to choose item set, but I can't.

Browser (Chrome, Safari, Internet Explorer) and Version

Tried Firefox 52.0.1, Chrome 57.0.2987.110, Internet Explorer 11.953.14393.0 and Edge 38.14393.0.0

Provide a Screenshot when possible

Steps to reproduce

Like I described in the title, the site seems to enter the screenshotted mode after one use or changing the language. after this first happened in firefox i tried using edge and internet explorer which didn't work (surprise - who uses them anyway?), so installed chrome, could download once, closed the window and played lol. When i tried to create another set it once again entered the i-can-do-nothing-mode and never went back, even after deleting cookies and cache, same goes for firefox.
nothing is clickable exept "bugs", this is how i came here.

Browser Firefox 50.1

Couldn't get the upload to work right, ended up being an old Flash installation that wasn't removed when updated. Had to totally remove Flash and reinstall to fix the problem, uploads by drag and drop work fine in Firefox now, although all champions get all item sets. Or most of them it seems to be randomly selected from the list if there are too many. The screenshot below shows what it looks like in the background - just to be clear I have only general item sets that I have named for what champions I use them on, and no champion-specific item sets.

And on Firefox it's not possible to download the files, it ends up here: http://i.imgur.com/i5EoWun.png and nothing happens. I figure it works in Chrome so I can still use it there at least, might want to add a disclaimer it works on Chrome.

Still failing to upload a zip on here though. https://we.tl/Qa8z97d66S for the download of my config.

Step 1 Go to your Applications Folder
Step 2 Right Click on the League of League icon, click "Show Package Contents"

Step 3 Click on Contents, LoL, Config, Global, Recommended Paste the .json

Step 4 Paste the .json file from the .zip file
Step 5 Win all of the games with your custom builds

Would you agree to use another skeleton for the project, to have a nodeJS/Gulp based build in order to produce the JSON files during the build, and minify the whole project to enhance first load of the app ?

I'm used of generator-gulp-angular, that has been refactored into FountainJS, it's really handy ...

Browser (Chrome, Safari, Internet Explorer) and Version

Chrome, Firefox

Provide a Screenshot when possible

Steps to reproduce

Tick AD and/or CDR: Warrior enchantment does not show up despite giving AD and CDR.
Tick AP and/or Other MS: Runic Echoes does not show up.
Tick HP: Cinderhulk does not show up.

It may simply be an issue from Riot's end, as the enchantment do not show up either when filtering the stats they give in the official Item Set tool.

Browser (Chrome, Safari, Internet Explorer) and Version

Microsoft Edge 38.14393.1066.0
Microsoft EdgeHTML 14.14393

Provide a Screenshot when possible

Steps to reproduce

No Facking Idea

More of a minor oversight than an issue, but Elixir of Wrath is listed as a spell vamp item while Death's Dance isn't.

Browser (Chrome, Safari, Internet Explorer) and Version

Provide a Screenshot when possible

Steps to reproduce

• load item set
• I cannot find a way to change the champion (or champions) that an item set is mapped to.
  This applies for:
• item sets mapped to one champion
• item sets mapped to multiple champions
• item sets not mapped to a champion

Browser (Chrome, Safari, Internet Explorer) and Version

Chrome Version 58.0.3029.96 (64-bit)

Provide a Screenshot when possible

Steps to reproduce

1. Pick a champion with item builds set up outside of LoL Item Set Editor.
2. Create new builds with LoL Item Set Editor.
3. Delete old builds not set up in LoL Item Set Editor.
4. Champion gets sent down all the way to the bottom of list.

I noticed this immediately as soon as I made new item builds on LoL ISE for Ashe and deleted her old ones. I thought it was bugged and the site deleted her, wasting my time and effort making her new build until I scrolled all the way to the bottom to find her there. Same thing happened with others below Ashe.

There is no "Total Biscuit of Rejuvenation"
http://prntscr.com/f1oubl
http://prntscr.com/f1ouf2

Reminder for me that the tool will need to update to the new API before July

It just doesn't. I tried deleting the files "ItemSets.json" and "PersistedSettings.json" while replacing the "Champions" folder with the new one. Logging onto League just replaces files to old ones I had in the Legacy Client. (A whole month's worth of updating my item sets with ISE flushed down the drain.)

Browser (Chrome, Safari, Internet Explorer) and Version

Chrome ver. 58.0.3029.110 (64-bit)**

Provide a Screenshot when possible

https://i.gyazo.com/45d43ad29a59920c3c893e4adb095c8e.png

Steps to reproduce

I thought I had deleted the two item builds I highlighted up above, but for whatever reason they stuck around. It happens when downloading all the builds at once of course.

The download don't work on Opera browser.
Maybe if you treat Opera like a chrome browser (Opera is based on Chrome) it will work with no problem.

Issue Described here: https://boards.na.leagueoflegends.com/en/c/alpha-client-discussion/G71fNgKl-porting-item-sets-to-new-client

Require the ability to provide the old ItemSets.json file, and have it be separated out into the new structure (folders per champion etc).

In the attached ItemSets.json file, I have item sets specific to a single champion, and some that are shared by multiple champions. None set per map though. I'd like to be able to recover them and port them to the new structure, (successful example with the included Garen folder, where I loaded him on the old client, before it was disabled.).

Item Sets.zip

Would be nice if you could import some of the recommended items from lolalytics.com. I use this website for everything

Browser (Chrome, Safari, Internet Explorer) and Version

Chrome Version 57.0.2987.98 beta (64-bit)

Provide a Screenshot when possible

Steps to reproduce

Tooltips for items on the right side in the itemset blocks are not adjusting to the browser window borders. They are always aligned with their middlepoint and if you made a few blocks half of the tooltip is outside the browser, maybe use the same behaviour as you use for the ones in the overview?

Browser: Chrome/Vivaldi

Provide a Screenshot when possible

https://zapodaj.net/images/2632cd648d568.jpg

Steps to reproduce

When working with Global Sets on Chrome and Vivaldi after setting them up it is impossible to download settings. The download just won`t start and no link to the file is shown.

Browser (Chrome, Safari, Internet Explorer) and Version

Chrome

Provide a Screenshot when possible

Steps to reproduce

1. Create global item set in Chrome
2. Download and copy over to League of Legends folder
3. Launch in new client
4. Items not in game

Hello!
I love the work you're putting into this! I don't seem to be able to get global item sets to work at all. The attached screenshot shows that my item sets are at an earlier version from what I have downloaded. I have not tested this on other browsers. I will attach the config file and the item set I downloaded.

Config.zip
Lol_Item_Set (2).zip

I have gotten around this by adding each champion I could want a specific item set for manually.

For instance, Warwick now has 2 AD Jungle pages.

One of which is correct

The other is not

You can see how the bottom image is missing all the bloodrazor enchants and the control ward.

Let me know if you need any more info!

Browser (Chrome, Safari, Internet Explorer) and Version

Google Chrome Version 55.0.2883.87 m

Provide a Screenshot when possible

Steps to reproduce

Drag a "Champions" folder that is very large into the editor. Example of large folder:
Champions.zip

Only item sets up to a certain point will load. (In the most recent case, it loaded up to Swain, but no further.)

The item description for frostqueens claim, for example, reach out of the screen on the top side.
Happens with some other items aswell (Redemtion,Tiamat, ...).

Browser: Chrome, Version 58.0.3029.110 (64-bit).

Screenshot: https://gyazo.com/e6b99a487a09e77becf2352e6818e087

Steps to reproduce: Simply click on the frostqueens-claim icon.

PS: Great website you designed there :D

Browser (Chrome, Safari, Internet Explorer) and Version

Google Chrome Version 55.0.2883.87 m

Provide a Screenshot when possible

Steps to reproduce

Upload certain item sets, like these:
examples.zip

Some of the items appear as black boxes, with a delete button and no description.

My best guess is that at least some of them are old items, like the pink ward.

I have confirmed for at least one page that the blank items do not appear in game either.

First of all thanks for this awesome tool :)

It's only an idea, but it would be great to be able to import a build from mobafire.

I'm also an AngularJS developer, so if you are open to pull requests, I could try to work on this on my spare time. Tell if you are interested about this idea ...

When the list of items is scrollable, it requires approximately 5 turns of my scrollwheel to go approximately 2.5 rows of items. It doesn't feel right at all. I can usually scroll through that much vertical space in an instant, with one quick turn of the scroll wheel.

It sure looks pretty the first time I scroll through it, but quickly becomes cumbersome when I'm just trying to find an item.

Nice work by the way!