Giter VIP home page Giter VIP logo

lithium-fabric's People

Contributors

2no2name avatar amnotbananaama avatar byquanton avatar chocohead avatar earthcomputer avatar eatmyvenom avatar embeddedt avatar fxmorin avatar gegy avatar ishland avatar jaskarth avatar jellysquid3 avatar joaoh1 avatar kichura avatar kroppeb avatar lucilletea avatar magneticflux- avatar maityyy avatar malte0811 avatar mrgrim avatar mrmangohands avatar radiok avatar spacewalkerrs avatar spottedleaf avatar srbedrock avatar stupefacient avatar telepathicgrunt avatar theepicblock avatar tr7zw avatar wesley1808 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

lithium-fabric's Issues

Cant Load World!

latest.log
it crashes if i try to generate a new world
i used the latest lithium (not release files) to build a jar

Creeper behaviour

With Lithium installed I have noticed that creepers don't behave as expected around cats,
The expected behaviour is that they would run away from a cat that is within a 6 block radius however with lithium installed the creeper needs to be within a 2 block radius.

This was tested on Fabric 1.15.2

Happy to provide more information if needed,

"Definitely not up to no good" on boot

admin@yuno:/home/minecraft$ [17:24:07] [main/INFO]: Loading for game Minecraft 1.15.2
[17:24:08] [main/INFO]: [FabricLoader] Loading 6 mods: [email protected], [email protected], [email protected], [email protected]+build.196, [email protected]+build.6, [email protected]
[17:24:08] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8 Source=file:/home/minecraft/fabric-server-launch.jar Service=Knot/Fabric Env=SERVER
[17:24:08] [main/INFO]: Lithium's configuration file was loaded successfully
[17:24:08] [main/INFO]: Not applying mixin 'me.jellysquid.mods.lithium.mixin.chunk.no_chunk_locking.MixinPalettedContainer' as no configuration enables it
[17:24:08] [main/INFO]: Not applying mixin 'me.jellysquid.mods.lithium.mixin.redstone.MixinRedstoneWireBlock' as no configuration enables it
[17:24:08] [main/INFO]: Not applying mixin 'me.jellysquid.mods.lithium.mixin.redstone.MixinWorld' as no configuration enables it
[17:24:08] [main/INFO]: Transforming class net/minecraft/class_2382 using patch set 'Modify mutability flags in Vec3i'
[17:24:09] [main/INFO]: Transforming class net/minecraft/class_2338$class_2339 using patch set 'Use mutable fields in Vec3i'
[17:24:12] [main/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[17:24:12] [main/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[17:24:12] [main/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[17:24:12] [main/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[17:24:12] [main/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[17:24:12] [main/INFO]: Definitely not up to no good

Server then goes on to boot normally. Only got this when I restarted the server to enable flying in the server.properties because my friend kept getting kicked.

Lithium removes hitboxes inside some blocks.

Expected Behavior

Lithium should not change any block hitboxes.

Actual Behavior

Lithium has fewer hitboxes than vanilla, e.g. inside extended piston bases or daylight sensors.

Reproduction Steps

Build this contraption (using soul sand, and setblock the piston then)
In Vanilla the outcome is a) while in Lithium the outcome is b).

Analysis

It is caused by Lithium replacing the cuboid method that creates VoxelShapes. In vanilla sometimes VoxelShapes with a BitSet are created. They have a collision box at every bit border (8th or 4th of a block) that is inside the cuboid. Lithium does not have those collision boxes inside the cuboid.
Disabling shapes.specialized_shapes works around the issue.

Attachments

a) https://cdn.discordapp.com/attachments/648967810139029505/724030415480029284/2020-06-21_00.38.00.png
b) https://cdn.discordapp.com/attachments/648967810139029505/724030982176374956/2020-06-21_00.40.32.png

Server hangs under certain conditions when players go through a Nether portal

Reproduction Steps

We have had 3 people join our server and ever since updating to 1.16.1 it is random but to those 3 it crashes whenever they enter or leave the nether, now it is not 100% of the time for them but random

  1. Affected Player goes into nether Portal
  2. Server instantly crashed

Crash Report File

crash-2020-07-21_16.43.16-server.txt

Additional Information

Any help would be appreciated and when I say instant crash it is within 3 seconds of them going through the portal and server stops, I am not the greatest at reading crash reports so any help would be appreciated.

Forge Version on Curs

Was the Forge Version for Lithium removed from Curse and why? Will it be back soon? I can't upload my pack on curse using the Forge Version of this mod, it gets rejected.

Chunks do not render correctly on multiplayer servers

When joining a server, chunks do not render correctly on the client. I have yet to test it with a vanilla server.

Expected: chunks render normally, no random voids and all blocks are rendered

image

Installed mods:
image

Before installing lithium chunks had rendered correctly, this only occurs after adding lithium

logs if needed:
latest.log

Heavy redstone/mechanisms can lead to broken chunk loading within the same dimension

Originally reported by Andrews54757 on the Discord.

When the server is under some heavy loads (Andrews54757 reports many will work, I've only reproduced it while running this ice farm), chunk loading within the same dimension will stop working properly.
Only chunks very close to players will load, and nearby chunks will also unload when they shouldn't. A player travelling to this dimension through a portal is likely to overload the server, kicking everyone but not crashing it.

Here's a video of the chunk loading issue in 20w14a.

I've reproduced this issue both in 1.15.2 and 20w14a.
In 1.15.2 running lithium 0.4.6 and optionally phosphor 0.5.2
In 20w14a running lithium 0.5.0-alpha1 and phosphor 0.5.2

In 1.15.2 I've found that using phosphor, and disabling both use_fast_shape_comparison and extend_block_shape_cache, will fix the issue - chunks will load properly and players won't be kicked. Andrews54757 reports that this wasn't enough to fix the problem.

Optimize /locate command for all structures at an insane rate with a single mixin!

Basically in vanilla, if you have a structure that has a very low spacing/separation but is put in a very rare biome, doing /locate could cause the game to stall for minutes or even longer.

The reason for this is because in StructureFeature's locateStructure method, worldView.getChunk(chunkPos.x, chunkPos.z, ChunkStatus.STRUCTURE_STARTS); actually generates the chunk so for something thousands of blocks away, the game is generating every chunk along the way for each structure spawn attempt.

To fix this, go into StructureFeature's locateStructure method and wrap ChunkPos chunkPos down to if (n == 0) with this if statement:

if(worldView.getBiome(mutable.set(trueChunkX << 4, 1, trueChunkZ << 4)).hasStructureFeature(structure)) {
Checking if the biome can even spawn the structure first is much, much, MUCH faster than generating the chunk and checking for the structure that way. Why even generate the chunk if the structure is 100% not gonna spawn there because of the invalid biome? smh Mojang.

The good new is this can be done within modded structure by overriding that method like I did here: https://hatebin.com/cfpqkgfskf

But if this can be included in LibStructure, everyone will benefit including vanilla. It would also make treasure maps in chests load much faster as well as they too rely on the /locate command.

For comparison, here's locate command without the fix looking for a Jungle Mineshaft that has a spacing of 1 and separation of 0. It takes a complete full minute while the world hangs and ultimately fails because /locate has a chunk radius of 100 * the structure's spacing config which is about 1600 blocks outward.
https://streamable.com/1b0su0

And here's /locate command with the fix finding the Jungle Mineshaft 3500 blocks away in mere seconds (I increased the radius in the locateStructure method I overridden).
https://streamable.com/84fx82

(originally was posted on LibStructure but this is a much better fit for Lithium Earthcomputer/LibStructure#1)

1.12.2 backport possible?

I'm not asking anyone to do it necessarily, but I am curious if it is possible. I'm a software engineer and would love to give a crack at a backport, but would love to know about any potential problems

Crash with ReplayMod

When starting the mod with Replay Mod in 1.14.4, it doesn't even load to the menu, just says "An unexpected error occured..."

OptiFine is incompatible with Lithium

Mods and versions used:
Minecraft 1.16.1
Fabric 0.8.9+build.203
Lithium 0.5.0-rc1 (default settings)
Fabric API 0.14.1+build.372
Preview_OptiFine_1.16.1_HD_U_G2_pre2 (default settings)
Optifabric-1.1.0-beta2 (default settings)
(Not Enough Crashes 1.2.4+1.16.1)

Reproduction Steps:

  1. Singleplayer
  2. Create New World (on main menu)
  3. Create New World (botton left confirm button)

Crash Report File:
https://gist.github.com/MaoDoBan/fe76263d57013cea043befec20380031

Additional Information:
I have no ideia if this is a Lithium, Optfabric or Optfine problem.

Spigot support

Hello,
i wanted to ask if there is a way to run Lithium or Phosphor on a spigot/paper-spigot server.

Lithium crashes my game everytime I enter a single-player world?

Everytime I try to enter a single-player world with the Lithium mod, I crash? But when entering a Multiplayer world it works perfectly fine. Sorry, this might sound like someone already reported it but I just can't seem to find the reason for it?

---- Minecraft Crash Report ----
// Don't be sad, have a hug! <3

Time: 2020-07-28 13:00:59 CST
Description: Exception in server tick loop

java.lang.IllegalAccessError: tried to access field net.minecraft.class_3898$class_3208.field_18247 from class net.minecraft.class_3898
at Not Enough Crashes deobfuscated stack trace.(1.15.2+build.17)
at net.minecraft.server.world.ThreadedAnvilChunkStorage.updateCameraPosition(ThreadedAnvilChunkStorage:2249)
at net.minecraft.server.world.ServerChunkManager.updateCameraPosition(ServerChunkManager:467)
at net.minecraft.server.network.ServerPlayNetworkHandler.onPlayerMove(ServerPlayNetworkHandler:867)
at net.minecraft.network.packet.c2s.play.PlayerMoveC2SPacket.apply(PlayerMoveC2SPacket:122)
at net.minecraft.network.packet.c2s.play.PlayerMoveC2SPacket$Both.apply(PlayerMoveC2SPacket:18)
at net.minecraft.network.NetworkThreadUtils.lambda$checkThreadAndEnqueue$0(NetworkThreadUtils:34)
at net.minecraft.class_2600$$Lambda$5479/1082886050.run(Unknown Source)
at net.minecraft.server.ServerTask.run(ServerTask:18)
at net.minecraft.util.thread.ThreadExecutor.executeTask(ThreadExecutor:172)
at net.minecraft.util.thread.ReentrantThreadExecutor.executeTask(ReentrantThreadExecutor:23)
at net.minecraft.server.MinecraftServer.executeTask(MinecraftServer:763)
at net.minecraft.server.MinecraftServer.executeTask(MinecraftServer:154)
at net.minecraft.util.thread.ThreadExecutor.runTask(ThreadExecutor:134)
at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer:745)
at net.minecraft.server.MinecraftServer.runTask(MinecraftServer:739)
at net.minecraft.util.thread.ThreadExecutor.runTasks(ThreadExecutor:115)
at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer:723)
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer:676)
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer:256)
at net.minecraft.server.MinecraftServer$$Lambda$4526/1988560864.run(Unknown Source)
at java.lang.Thread.run(Thread.java:745)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- System Details --
Minecraft Version: 1.16.1
Minecraft Version ID: 1.16.1
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_51, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 301586728 bytes (287 MB) / 1073741824 bytes (1024 MB) up to 1073741824 bytes (1024 MB)
CPUs: 4
JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx1G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
Suspected Mods: Unknown
Fabric Mods: betterdroppeditems: Better Dropped Items 1.2.0-1.16
blur: Blur 1.0.6
boostedbrightness: Boosted Brightness 1.0.0
clear-skies: Clear Skies 1.3.38
cloth-basic-math: Cloth Basic Math 0.5.1
cloth-config2: Cloth Config v4 4.5.6
durabilityviewer: Giselbaers Durability Viewer 1.16-fabric0.13.1-1.7.2
fabric: Fabric API 0.13.1+build.370-1.16
fabric-api-base: Fabric API Base 0.1.3+12a8474c7c
fabric-biomes-v1: Fabric Biomes (v1) 0.2.7+059ea8667c
fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.4+c6a8ea897c
fabric-command-api-v1: Fabric Command API (v1) 1.0.8+5ce5339802
fabric-commands-v0: Fabric Commands (v0) 0.2.0+52d308367c
fabric-containers-v0: Fabric Containers (v0) 0.1.8+045df74f7c
fabric-content-registries-v0: Fabric Content Registries (v0) 0.1.9+059ea8667c
fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.1.2+b7f9825d7c
fabric-dimensions-v1: fabric-dimensions-v1 1.0.0+a71b30537c
fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.3.3+7066030f7c
fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.1.3+0d474ec47c
fabric-item-groups-v0: Fabric Item Groups (v0) 0.2.0+438f96367c
fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.0+e16a97747c
fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.0+3fa9f7c57c
fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 1.0.0+b0993bc102
fabric-loot-tables-v1: Fabric Loot Tables (v1) 0.1.10+059ea8667c
fabric-mining-levels-v0: Fabric Mining Levels (v0) 0.1.2+b764ce997c
fabric-models-v0: Fabric Models (v0) 0.1.0+dfdb52d67c
fabric-networking-blockentity-v0: Fabric Networking Block Entity (v0) 0.2.5+b50ffc7b7c
fabric-networking-v0: Fabric Networking (v0) 0.1.10+e00ecb5f02
fabric-object-builder-api-v1: Fabric Object Builder API (v1) 1.5.5+e00ecb5f7c
fabric-object-builders-v0: Fabric Object Builders (v0) 0.6.0+da175ad67c
fabric-particles-v1: fabric-particles-v1 0.2.1+0a6f2a707c
fabric-registry-sync-v0: Fabric Registry Sync (v0) 0.3.8+7dba2d6c7c
fabric-renderer-api-v1: Fabric Renderer API (v1) 0.2.13+eae12eb87c
fabric-renderer-indigo: Fabric Renderer - Indigo 0.3.1+059ea8667c
fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 2.0.1+5a0f9a607c
fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.1.3+b7f9825d7c
fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 0.1.7+12a8474c7c
fabric-rendering-v0: Fabric Rendering (v0) 1.1.0+534104907c
fabric-rendering-v1: Fabric Rendering (v1) 1.1.2+346247d77c
fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.2.5+059ea8667c
fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.0.1+f362c86e7c
fabric-tag-extensions-v0: Fabric Tag Extensions (v0) 0.2.5+5a6e8f4c7c
fabric-textures-v0: Fabric Textures (v0) 1.0.4+eae12eb87c
fabric-tool-attribute-api-v1: Fabric Tool Attribute API (v1) 1.1.4+5794386e7c
fabricloader: Fabric Loader 0.9.0+build.204
gameinfo: GameInfo 1.5.3 1.16
gbfabrictools: GBfabrictools 1.2.2+1.16
lithium: Lithium 0.5.1
loadcatcher: Entrypoint Catcher 2.0.0
minecraft: Minecraft 1.16.1
mm: Manningham Mills 2.0
modmenu: Mod Menu 1.12.2+build.16
notenoughcrashes: Not Enough Crashes 2.1.0+1.16.1
optifabric: Optifabric 1.1.0-beta2
org_slf4j_slf4j-api: slf4j-api 1.7.30
org_slf4j_slf4j-simple: slf4j-simple 1.7.30
org_zeroturnaround_zt-zip: zt-zip 1.14
phosphor: Phosphor 0.6.0+build.7
satin: Satin 1.4.0-nightly.1.16-pre5+build.1
smb: Better Mod Button 1.1.0
voxelmap: VoxelMap 1.10.6
waila: Hwyla 1.9.22
worldedit: WorldEdit 7.2.0-beta-02+d10d7d6
Player Count: 1 / 8; [class_3222['XiG0'/49, l='ServerLevel[Resource Flat Test]', x=-276.78, y=54.12, z=-171.87]]
Data Packs: vanilla, fabric/fabric-tool-attribute-api-v1
Type: Integrated Server (map_client.txt)
Is Modded: Definitely; Client brand changed to 'fabric'

Broken skeleton farm with Lithium

Game version: 1.15.2
Lithium version: lithium-mc1.15.2-fabric-0.4.6-mod
Fabric version: 0.5.2.39

Screenshot

Mobs cram in a tunnel

Seems like the right last mob tries to pathfind towards to spawner and declines to enter bubble column

After uninstalling mods, everything works like a charm

Crash With Optifine On World Load in 1.16.1

Reproduction Steps

Run fabric with mods:

  • optifine (1.16.1-pre2)
  • optifabric (1.1.0-beta2)
  • lithium (0.5.0-rc1)

Crash Report File

[Server thread/ERROR]: Encountered an unexpected exception
java.lang.IllegalAccessError: tried to access field net.minecraft.class_3898$class_3208.field_18247 from class net.minecraft.class_3898
	at net.minecraft.class_3898.method_18713(class_3898.java:2749) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.class_3215.method_14096(class_3215.java:467) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.class_3244.method_12063(class_3244.java:867) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.class_2828.method_12272(class_2828.java:122) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.class_2828$class_2830.method_11054(class_2828.java:18) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.class_2600.lambda$checkThreadAndEnqueue$0(class_2600.java:34) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.class_3738.run(class_3738.java:18) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.class_1255.method_18859(class_1255.java:172) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:763) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:154) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.class_1255.method_16075(class_1255.java:134) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:745) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:739) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.class_1255.method_5383(class_1255.java:115) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:723) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:676) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:256) ~[intermediary-minecraft-1.16.1-client.jar:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_241]

Additional Information

Minecraft Version: 1.16.1
Operating System: Mac OS X (x86_64) version 10.15.5
Java Version: 1.8.0_241, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation

Wither is able to break unbreakable blocks.

Issue: Blocks that withers shouldn't be able to break are able to be broken. Ex: Bedrock.

Expected: Withers shouldn't be able to break bedrock since they can't in vanilla.

Repro: Create a wither in the end under the bedrock portal platform. The wither will be able to break the bedrock and end portal blocks inside.

Update to 1.16 pre8. This is VERY far behind.

Reproduction Steps

Use the mod...

Crash Report File

Please upload your crash report as a file to GitHub Gist and replace this text with a link to the uploaded report.
No errors are given. I'm simply given the usual Fabric The game crashed window, so no point.

Additional Information

Provide any additional information or context which may be relevant to the issue. If you have none to add, you can remove this section.
N/A.

Add API

Hi there,
I have come across a situation where my mod is incompatible with one of the optimizations in Lithium, and I would like a way to detect whether this optimization is enabled, and give the user a friendly message to disable this optimization.
Could you provide an API to enable other mods to determine which Lithium optimizations are enabled?
Thanks! ~Earth

1.14? Not an issue, just a request

Hey I play on 1.14.4 and I do not wish to update my server, can you make a 1.14 version if it is easy? If it is, I would be very grateful although I do understand if you do not want to.

Crash with Vexes and Carpet mod

Mods and versions used

Minecraft 1.16.1
Fabric 0.8.9+build.203
Lithium 0.5.0-rc1
(Carpet Mod 1.4.0)
(Fabric API 0.14.1+build.372)
(Not Enough Crashes 1.2.4+20w17a)

Reproduction Steps

  1. Create a new Superflat world. Use the Void preset for best performance.
  2. Set your spawn point where you initially spawn (/spawnpoint).
  3. Summon 5 evokers (/summon evoker x5). You can instead activate a repeating command block with the command /summon vex ~ ~ ~ {LifeTicks:20}.
  4. Give yourself max healing (/effect give @p instant_health 1000000 22).
  5. Switch gamemode to survival.
  6. If Carpet mod is installed, fast-forward the game with /tick warp 72000.
  7. The server will crash after a few minutes.
  8. If Not Enough Crashes is installed, click through the crash screen.
  9. The game will exit to the multiplayer menu with "Internal exception: java.lang.StackOverflowError".

Crash Report File

https://gist.github.com/James103/e35b958585c3700722edfb700c0d0e8e

Additional Information

The crash does not occur without Lithium installed, and Not Enough Crashes tells me that Lithium is a possible cause of the above crash.

In my case, the world on which the game crashed is hidden from the world selection screen due to java.nio.channels.OverlappingFileLockException until you restart the game entirely.

Hatched Turtle Home Beach Coordinates Incorrect

We've been experiencing an issue where newly hatched turtles do not have their home beach coordinates set correctly. Sometimes they can be off by hundreds or even thousands of blocks and can be on any block type. We've narrowed down the issue to Lithium and have reproduced it on 0.4.4 and 0.4.5.

Additionally, we've observed hatched turtles home positions changing over time seemingly randomly.

Thanks!

Bees don't exit their hive in the nether

Game version: 1.15.2
Lithium version: lithium-mc1.15.2-fabric-0.4.6-mod
Fabric version: 0.5.2.39

I have a honey farm on top of the nether bedrock. It was working fine, but after adding lithium the bees no longer exit their hive even after an hour of AFK. After disabling lithium and restarting the server, all 3 bees from each hive immediately exited and started pollinating.

Screenshot and logs below

Screenshot ![2020-05-08_23 30 13](https://user-images.githubusercontent.com/446084/81462955-068f8100-9184-11ea-8121-03b84dfa7a6b.png)

2020-05-08-2.log

Exception thrown while saving oversized chunks

Lithium is unable to handle oversized chunks correctly (possibly due to a problem with the compactor?) Trying to save oversized chunks results in the following exception being thrown and the chunk not being saved:

java.lang.IllegalStateException: Cannot grow
	at me.jellysquid.mods.lithium.common.world.chunk.LithiumHashPalette.computeEntry(LithiumHashPalette.java:69) ~[lithium-fabric-mc1.16.1-0.5.0.jar:?]
	at me.jellysquid.mods.lithium.common.world.chunk.LithiumHashPalette.method_12291(LithiumHashPalette.java:58) ~[lithium-fabric-mc1.16.1-0.5.0.jar:?]
	at net.minecraft.class_3508.compact(class_3508.java:557) ~[intermediary-server.jar:?]
	at net.minecraft.class_2841.method_12330(class_2841.java:1099) ~[intermediary-server.jar:?]
	at net.minecraft.class_2852.method_12410(class_2852.java:261) ~[intermediary-server.jar:?]
	at net.minecraft.class_3898.method_17228(class_3898.java:716) ~[intermediary-server.jar:?]
	at net.minecraft.class_3898.method_18843(class_3898.java:443) ~[intermediary-server.jar:?]
	at java.util.concurrent.CompletableFuture.uniAccept(CompletableFuture.java:670) ~[?:1.8.0_252]
	at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:646) ~[?:1.8.0_252]
	at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:456) ~[?:1.8.0_252]
	at net.minecraft.class_3898.method_20605(class_3898.java:424) ~[intermediary-server.jar:?]
	at net.minecraft.class_3898.method_17233(class_3898.java:401) ~[intermediary-server.jar:?]
	at net.minecraft.class_3215.method_12127(class_3215.java:339) ~[intermediary-server.jar:?]
	at net.minecraft.class_3218.method_18765(class_3218.java:347) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:873) ~[intermediary-server.jar:?]
	at net.minecraft.class_3176.method_3813(class_3176.java:306) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:813) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.handler$zdn000$modifiedRunLoop(MinecraftServer.java:3296) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:653) ~[intermediary-server.jar:?]
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:256) ~[intermediary-server.jar:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_252]

World generation is different

Expected Behavior

Although the mod touches world gen, it is supposed to not affect the way in a way like that.

Actual Behavior

Worlds generated with this mod on are different from the ones without it/vanilla. The terrain itself generates differently, but other observed effects are more floating islands on the nether, smaller end cities, less connected caves, among other things.

Reproduction Steps

  1. Create a world in vanilla or without a mod, take note of the seed
  2. Create another world with the mod on with the same seed as the previous
  3. Compare generation results

Attachments

First on each pair are without Lithium, and the second, with. Seed was 104967040175852735 .
2020-07-08_12 24 17
2020-07-08_12 24 58
2020-07-08_12 15 13
2020-07-08_12 15 41

Creepers aren't afraid of cats (MC 1.16.1, Lithium 0.5.0, Fabric 0.8.9b203)

Expected Behavior

Creepers should run away from cats if they are within 6 blocks of them.

Actual Behavior

Creepers don't care about cats at all.

Reproduction Steps

  1. Spawn in a creeper
  2. Spawn in a cat right next to it
  3. Nothing happens

I did search a bit around and found that #13 mentions the same problem, but apparently it was fixed? Also, over on Discord, lucy mentions the same bug 2-3 weeks ago.

Build fails with included wrapper

The build fails with this error:

> Could not resolve all dependencies for configuration ':minecraftLibraries'.
   > org.lwjgl:lwjgl:3.2.2 has more than one client module definitions.

As seen on Discord here:

Hello, I'm having issues compiling Lithium-1.16.x when i do ./gradlew build it says build failed here's the log
https://sourceb.in/c43950c27f

I'll make a PR that changes the wrapper back to 4.10.2 so Chocohead's Loom fork works.

Startup crash with campfires cook mobs

I am the developer of Camp Fires Cook Mobs.

I went to the JellySquid Discord and some members tried to help me figure this issue out, but we couldn't find a solution. The conversation starts here and ends here, if you'd like to see what was suggested.

In short, we tried to get the custom key in fabric.mod.json that requests lithium disable certain modules to work. We also tried disabling the modules using lithium.properties, but for some reason this wasn't working either (or at least my log output didn't make it look like it was working).

Version 1.1.1 of camp fires cook mobs has lithium (and phosphor, which it also crashes with, but I've been unable to use curemaven to get it into a dev environment) declared as a breaking conflict, so if you're trying to run them together use 1.1.0.

Reproduction Steps

  1. Install lithium
  2. Install camp fires cook mobs
  3. Start the game
  4. Game crashes

Crash Report File

No crash report was generated.
Here is the latest.log from my non-dev environment.
Here is the latest.log from my dev environment.

Additional Information

Minecraft 1.16.1
camp-fires-cook-mobs-1.1.0+1.16.1.jar
lithium-fabric-mc1.16.1-0.5.1.jar
Fabric loader 0.9.0+build.204

Server Install Docs

Just came across your mod but how do I install this server side the docs say you can do but theres no instructions on how to.

stacked tnt explode at the wrong height

Expected Behavior

tnts at the exact same position explode at the same position

Actual Behavior

stacked tnt can explode a bit higher,somtime more than 1 block, outside water

Reproduction Steps

1.summon a bunch of tnt at one spot in a 1 high water pool
execute as @e[type=minecraft:minecart] run summon tnt ~ ~2 ~-3 {Fuse:20}
2.it blow up blocks on top

Attachments

2020-06-30_21 08 56
2020-06-30_21 09 07

Conflict With ModUpdater

Expected Behavior

It starts successfully with ModUpdater.

Actual Behavior

[22:02:49] [main/ERROR]: Error loading companion plugin class [me.jellysquid.mods.lithium.mixin.LithiumMixinPlugin] for mixin config [lithium.mixins.json]. The plugin may be out of date: FactoryConfigurationError:Provider org.apache.xerces.jaxp.DocumentBuilderFactoryImpl not found
javax.xml.parsers.FactoryConfigurationError: Provider org.apache.xerces.jaxp.DocumentBuilderFactoryImpl not found
	at javax.xml.parsers.DocumentBuilderFactory.newInstance(DocumentBuilderFactory.java:145) ~[380f7456-4d9b-4995-8be7-b763afa3afa3.jar:?]
	at org.apache.logging.log4j.core.config.xml.XmlConfiguration.newDocumentBuilder(XmlConfiguration.java:191) ~[server.jar:?]
	at org.apache.logging.log4j.core.config.xml.XmlConfiguration.<init>(XmlConfiguration.java:92) ~[server.jar:?]
	at org.apache.logging.log4j.core.config.xml.XmlConfigurationFactory.getConfiguration(XmlConfigurationFactory.java:46) ~[server.jar:?]
	at org.apache.logging.log4j.core.config.ConfigurationFactory$Factory.getConfiguration(ConfigurationFactory.java:522) ~[server.jar:?]
	at org.apache.logging.log4j.core.config.ConfigurationFactory$Factory.getConfiguration(ConfigurationFactory.java:459) ~[server.jar:?]
	at org.apache.logging.log4j.core.config.ConfigurationFactory.getConfiguration(ConfigurationFactory.java:265) ~[server.jar:?]
	at org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:613) ~[server.jar:?]
	at org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:634) ~[server.jar:?]
	at org.apache.logging.log4j.core.LoggerContext.start(LoggerContext.java:229) ~[server.jar:?]
	at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:242) ~[server.jar:?]
	at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:45) ~[server.jar:?]
	at org.apache.logging.log4j.LogManager.getContext(LogManager.java:174) ~[server.jar:?]
	at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:618) ~[server.jar:?]
	at me.jellysquid.mods.lithium.mixin.LithiumMixinPlugin.<init>(LithiumMixinPlugin.java:20) ~[lithium-fabric-mc1.16.1-0.5.0-rc1(1).jar:?]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:?]
	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:490) ~[?:?]
	at java.lang.Class.newInstance(Class.java:584) ~[?:?]
	at org.spongepowered.asm.mixin.transformer.PluginHandle.<init>(PluginHandle.java:97) [fabric-server-launch.jar:?]
	at org.spongepowered.asm.mixin.transformer.MixinConfig.onSelect(MixinConfig.java:598) [fabric-server-launch.jar:?]
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.selectConfigs(MixinProcessor.java:476) [fabric-server-launch.jar:?]
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.select(MixinProcessor.java:438) [fabric-server-launch.jar:?]
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.checkSelect(MixinProcessor.java:416) [fabric-server-launch.jar:?]
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:285) [fabric-server-launch.jar:?]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:191) [fabric-server-launch.jar:?]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:178) [fabric-server-launch.jar:?]
	at org.spongepowered.asm.mixin.transformer.FabricMixinTransformerProxy.transformClassBytes(FabricMixinTransformerProxy.java:23) [fabric-server-launch.jar:?]
	at net.fabricmc.loader.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:157) [fabric-server-launch.jar:?]
	at net.fabricmc.loader.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:143) [fabric-server-launch.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:522) [?:?]
	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:190) [fabric-server-launch.jar:?]
	at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:140) [fabric-server-launch.jar:?]
	at net.fabricmc.loader.launch.knot.KnotServer.main(KnotServer.java:26) [fabric-server-launch.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
	at net.fabricmc.loader.launch.server.FabricServerLauncher.launch(FabricServerLauncher.java:61) [fabric-server-launch.jar:?]
	at net.fabricmc.loader.launch.server.FabricServerLauncher.setup(FabricServerLauncher.java:105) [fabric-server-launch.jar:?]
	at net.fabricmc.loader.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:49) [fabric-server-launch.jar:?]

Reproduction Steps

Start a server (doesn't happen with the client) running both Lithium and ModUpdater (https://www.curseforge.com/minecraft/mc-mods/modupdater).

Thoughts

It seems ModUpdater's JIJ'd Dom4J library is conflicting with Lithium calling getLogger inside its Mixin plugin, which makes no sense considering ModUpdater itslef (and Minecraft) all call getLogger() at various points in time. Dom4j is bundled in ModUpdater here: https://gitea.thebrokenrail.com/TheBrokenRail/ModUpdater/src/branch/master/build.gradle#L33. I have no idea why this would cause a conflict,

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.