Comments (5)
@NoComment1105 Are you still able to reproduce this? I can't reproduce the issue, the value is saved properly for me.
from sodium-fabric.
@NoComment1105 Are you still able to reproduce this? I can't reproduce the issue, the value is saved properly for me.
Yes i am still able to reproduce, however it is only when you lower the entity distance and not when you raise it
from sodium-fabric.
Confirmed on the latest commit (currently 885222a).
Analysis
It looks like the problematic line of code is the Math.round()
function here. Since the values for Entity Distance 50% and 75% are converted to 0.5 and 0.75 respectively, the Math.round()
function rounds them to the nearest integer (which would be 1.0 or 100%). This has the effect of the option appearing not to save even though it is saving a rounded result. I'm not sure what the best fix for this would be, as I'm not sure of Jelly's preferences or alternative rounding operations to use.
from sodium-fabric.
Confirmed on the latest commit (currently 885222a).
Analysis
It looks like the problematic line of code is theMath.round()
function here. Since the values for Entity Distance 50% and 75% are converted to 0.5 and 0.75 respectively, theMath.round()
function rounds them to the nearest integer (which would be 1.0 or 100%). This has the effect of the option appearing not to save even though it is saving a rounded result. I'm not sure what the best fix for this would be, as I'm not sure of Jelly's preferences or alternative rounding operations to use.
OK, thanks for still looking into it even though you couldn't reproduce initially, will this be fixed for the next version?
from sodium-fabric.
In 1.16.2+, you can save it above 100%. It just won't do anything.
from sodium-fabric.
Related Issues (20)
- Leaves rendered incorrectly on fast graphics HOT 5
- 1.20.1 Random chunks not rendering HOT 2
- Brightness slider description is wrong and misleading HOT 2
- Allow disabling of occlusion culling HOT 1
- Random crash and corruption. HOT 1
- Apply "Smooth Lighting" to all modded fluids HOT 1
- Animations for block are broken HOT 3
- BIG FPS DROP when I open chest or inventory HOT 1
- when i use pistons the crash my game HOT 1
- game crash HOT 1
- a Resource pack makes Sodium crash HOT 4
- Entering fullscreen should not perform a video mode switch
- Frame presentation should be performed asynchronously
- DXGI should be used for frame presentation
- Add an option to configure render scaling HOT 3
- emotecraft and sodium incompatibility on new mod version HOT 1
- No lightning in the Nether HOT 1
- Summarized dependency of Sodium in Entity Texture Features (ETF) mod HOT 2
- The renderSectionManager property of SodiumWorldRenderer is null, leading to a NullPointerException when calling the getVisibleChunkCount() method. HOT 1
- Unreported Exception thrown when trying to load into a World HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sodium-fabric.