calconnect / caldavtester Goto Github PK

Two tests PUT vcards having the following form:

VERSION:3.0
PHOTO;BASE64:...

The PHOTO properties appear to be illegal per v2.1, v3.0, v4.0 by my reading.

The verifier for the test checks for PHOTO;ENCODING=b:... which is the proper for for v3.0

I don't know if the source resource was deliberately written because its been seen in the wild, or if its a simple typo.

Should we fix the source resource to be v3.0 compliant or fix our implementations to accept such a resource?

Test 1 in suite free-busy reports of file scripts/tests/CalDAV/availability.xml uses a dataString verifier, in which the existence of the string FREEBUSY;FBTYPE=BUSY:$now.year.1:0104T170000Z/PT1H is checked.

However, as the same period can also be expressed as period-explicit (RFC 5545, section 3.3.9), this should be considered appropriately by the test, so that a string FREEBUSY;FBTYPE=BUSY:$now.year.1:0104T170000Z/$now.year.1:0104T180000Z wouldn't fail the test either.

CardDAV/errorcondition.xml PUTs invalid vCard data and expects failure. However, it looks for a CARDDAV:valid-addressbook-object-resource precondition which does not appear in RFC 6352. The most appropriate documented precondition code is CARDDAV:valid-address-data.

Should we change the test to look for the documented precondition code, or modifiy the prepostcondition validator to accept multiple values? I looked at doing the latter but I don't understand Python well enough to make the change.