Giter VIP home page Giter VIP logo

courier-library's Introduction

courier-library

Improvements

  • More test cases, only tested the happy paths, there should be edge case and bad input tests, i.e test for null inputs and empty order lists
  • add some error handling, you can create parcels with negatives sizes right now
  • inject the configuration into the order service
  • use the configuration in the tests so we aren't tied to specific numbers in them, i.e there shouldn't be "SmallParcelShouldCost3Dollars" rather "SmallParcelShouldCostSmallParcelPriceDollars"
  • The OrderService ended up quite large, we could probably seperate out the price calculation logic into it's own class
  • Even though I removed it I would add back in the ParcelType enum to make switching easier
  • I would complete the discounts work (2 hour mark https://github.com/calvinv/courier-library/commit/1a9dc99bc62d41d9f520c37d8284cf3e6878a762)

courier-library's People

Contributors

calvinv avatar

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.