Giter VIP home page Giter VIP logo

clean2's People

Contributors

andytlr avatar camel-chased avatar duub avatar hagai-lvi avatar rgbkrk avatar

Stargazers

avatar avatar avatar

Watchers

avatar avatar

Forkers

rgbkrk

clean2's Issues

Package.getStylesheetsPath is deprecated.

Store package style sheets in the styles/ directory instead of stylesheets/ in the Clean2 package

Package.getStylesheetsPath (C:\Users\Florian\AppData\Local\atom\app-0.200.0\resources\app.asar\src\package.js:460:9)
Package.getStylesheetPaths (C:\Users\Florian\AppData\Local\atom\app-0.200.0\resources\app.asar\src\package.js:471:32)
Package.loadStylesheets (C:\Users\Florian\AppData\Local\atom\app-0.200.0\resources\app.asar\src\package.js:453:38)
<unknown> (C:\Users\Florian\AppData\Local\atom\app-0.200.0\resources\app.asar\src\package.js:183:19)
Package.measure (C:\Users\Florian\AppData\Local\atom\app-0.200.0\resources\app.asar\src\package.js:163:15)
Package.load (C:\Users\Florian\AppData\Local\atom\app-0.200.0\resources\app.asar\src\package.js:177:12)

Not compatible with linter or autocomplete

When distraction free mode is enabled, auto complete and linter popups show up to the far left of the text area, even though the text is centered horizontally. The popup also shows up on the same line that the user is typing on, instead of just below it, occasionally covering what the user is typing.

I love this package as it most closely resembles sublimes distraction free mode. Great job.

Failed to activate the Clean2 package

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 0.208.0
System: Mac OS X 10.10.3
Thrown From: Clean2 package, v0.12.3

Stack Trace

Failed to activate the Clean2 package

At Cannot read property 'command' of undefined

TypeError: Cannot read property 'command' of undefined
  at Object.module.exports.activate (/Users/olegshilov/.atom/packages/Clean2/lib/clean.coffee:82:23)
  at Package.module.exports.Package.activateNow (/Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:238:19)
  at /Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:770:25
  at Emitter.module.exports.Emitter.emit (/Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:219:20)
  at CommandRegistry.handleCommandEvent (/Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61)
  at CommandRegistry.module.exports.CommandRegistry.dispatch (/Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:153:19)
  at EventEmitter.<anonymous> (/Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:70:30)
  at emitOne (events.js:77:13)
  at EventEmitter.emit (events.js:166:7)

Commands

     -9:07.6.0 emmet:insert-formatted-line-break-only (atom-text-editor.editor.is-focused)
     -9:07.6.0 editor:newline (atom-text-editor.editor.is-focused)
     -9:07.4.0 core:paste (atom-text-editor.editor.is-focused)
     -9:01.6.0 core:move-right (atom-text-editor.editor.is-focused)
     -9:00.9.0 editor:delete-to-beginning-of-line (atom-text-editor.editor.is-focused)
     -9:00.5.0 core:backspace (atom-text-editor.editor.is-focused)
     -8:42.6.0 core:paste (atom-text-editor#editor.fontFamily.editor.mini.is-focused)
     -8:39.6.0 editor:select-to-first-character-of-line (atom-text-editor#editor.fontFamily.editor.mini.is-focused)
     -8:37.8.0 core:backspace (atom-text-editor#editor.fontFamily.editor.mini.is-focused)
  3x -8:33.4.0 core:undo (ul.list-inline.tab-bar.inset-panel)
     -7:21 core:paste (atom-text-editor#editor.fontFamily.editor.mini.is-focused)
     -5:58.9.0 core:select-all (atom-text-editor#editor.fontFamily.editor.mini.is-focused)
     -5:58.5.0 core:paste (atom-text-editor#editor.fontFamily.editor.mini.is-focused)
  2x -0:47.4.0 core:save (atom-text-editor#editor.fontFamily.editor.mini.is-focused)
     -0:01.5.0 clean2:toggle (atom-text-editor.editor.is-focused)

Config

{
  "core": {},
  "Clean2": {}
}

Installed Packages

# User
Clean2, v0.12.3
atom-beautify, v0.28.2
color-picker, v2.0.4
emmet, v2.3.10
file-icons, v1.5.7
language-javascript-jsx, v0.3.6
linter, v0.12.7
linter-coffeelint, v0.3.2
linter-csslint, v0.0.13
linter-eslint, v0.5.8
minimap, v4.9.4
minimap-git-diff, v4.1.3
minimap-pigments, v0.1.1
pigments, v0.4.5
terminal-status, v1.6.8

# Dev
No dev packages

Uncaught TypeError: Cannot set property 'opacity' of undefined

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.5.3
System: Ubuntu 14.04.4
Thrown From: Clean2 package, v0.16.0

Stack Trace

Uncaught TypeError: Cannot set property 'opacity' of undefined

At /home/beenorgone/.atom/packages/Clean2/lib/clean.coffee:59

TypeError: Cannot set property 'opacity' of undefined
    at Object.module.exports.restoreOpacity (/home/beenorgone/.atom/packages/Clean2/lib/clean.coffee:59:22)
    at Object.module.exports.applyConfig (/home/beenorgone/.atom/packages/Clean2/lib/clean.coffee:84:10)
    at Object.module.exports.toggle (/home/beenorgone/.atom/packages/Clean2/lib/clean.coffee:99:6)
    at atom-workspace.subs.add.atom.commands.add.clean2:toggle (/home/beenorgone/.atom/packages/Clean2/lib/clean.coffee:90:28)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/opt/atom/resources/app.asar/src/command-registry.js:260:29)
    at /opt/atom/resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/opt/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:544:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/opt/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:363:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeydown (/opt/atom/resources/app.asar/src/window-event-handler.js:97:36)
    at HTMLDocument.<anonymous> (/opt/atom/resources/app.asar/src/window-event-handler.js:3:61)

Commands

     -1:30.8.0 markdown-writer:insert-new-line (atom-text-editor.editor.is-focused)
     -1:30.8.0 markdown-lists:insert-new-line (atom-text-editor.editor.is-focused)
     -1:30.1.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
     -1:29.3.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused.autocomplete-active)
     -1:28.2.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
     -1:26.8.0 core:move-down (atom-text-editor.editor.is-focused)
     -1:26.4.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused)
     -1:26.2.0 markdown-writer:insert-new-line (atom-text-editor.editor.is-focused)
     -1:26.2.0 markdown-lists:insert-new-line (atom-text-editor.editor.is-focused)
     -1:24.8.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
     -1:24.1.0 core:move-down (atom-text-editor.editor.is-focused)
     -1:23.7.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused)
     -1:22.7.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
     -1:21.9.0 core:move-up (atom-text-editor.editor.is-focused)
     -1:20.7.0 core:save (atom-text-editor.editor.is-focused)
  2x -0:08.9.0 clean2:toggle (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "disabledPackages": [
      "vim-mode",
      "tidy-markdown",
      "markdown-pdf",
      "Zen",
      "minimap-cursorline",
      "minimap-highlight-selected",
      "minimap-pigments",
      "markdown-toc",
      "markdown-scroll-sync",
      "minimap",
      "emmet",
      "typewriter",
      "angularjs",
      "atom-beautify",
      "linter",
      "language-pfm"
    ],
    "followSymlinks": true,
    "themes": [
      "dark-flat-ui",
      "atom-zeus-syntax"
    ]
  }
}

Installed Packages

# User
Clean2, v0.16.0
atom-zeus-syntax, v1.0.3
auto-detect-indentation, v0.4.2
autoclose-html, v0.21.0
build-markdown, v1.0.2
color-picker, v2.1.1
dark-flat-ui, v1.2.4
file-icons, v1.6.14
highlight-selected, v0.11.2
markdown-format, v2.5.1
markdown-lists, v0.0.2
markdown-writer, v2.3.1
open-in-browsers, v0.0.11
open-recent, v5.0.0
pigments, v0.24.1

# Dev
No dev packages

Deprecated selector in `Clean2/styles/clean.less`

In Clean2/styles/clean.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

  • .clean2 atom-text-editor::shadow .gutter => .clean2 atom-text-editor.editor .gutter

  • .clean2 atom-text-editor::shadow .vertical-scrollbar => .clean2 atom-text-editor.editor .vertical-scrollbar

  • .clean2 atom-text-editor::shadow atom-text-editor-minimap => .clean2 atom-text-editor.editor atom-text-editor-minimap

  • .clean2 atom-text-editor::shadow atom-text-editor-minimap:hover => .clean2 atom-text-editor.editor atom-text-editor-minimap:hover

  • .clean2.clean2-show-gutter atom-text-editor::shadow .gutter => .clean2.clean2-show-gutter atom-text-editor.editor .gutter

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

REQ: Sudo Toolbar Package dimming

Hi,

I was wondering if you could please add support for Sudo Tool-bar package similar to what you did with minimap? The toolbar is the only element that is left on my UI when toggling your package. It seems like quite a popular Atom package so it might be worth the time? The class that needs the transparency is '.tool-bar'.

Or better yet, maybe a modular solution allowing package/class names (comma separated list?) that can be custom dimmed in transparency through your package config would be cool!

I would attempt this myself but I know zero coffee script. Your package is the only one that I find acts like a true focused zen mode for coding.

Thanks, I hope you will consider.

Package.getActivationCommands is deprecated.

FYI - can't activate clean in the latest release of atom (0.207). Here's the depreciation warning directly from atom:

Use activationCommands instead of activationEvents in your package.json
Commands should be grouped by selector as follows:

  "activationCommands": {
    "atom-workspace": ["foo:bar", "foo:baz"],
    "atom-text-editor": ["foo:quux"]
  }
Package.getActivationCommands (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:806:9)
Package.hasActivationCommands (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:731:20)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:185:24)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:163:15)
Package.load (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:177:12)
PackageManager.loadPackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:372:14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.