Giter VIP home page Giter VIP logo

cgxp's Introduction

cgxp's People

Contributors

arnaud-morvan avatar asaunier avatar bbinet avatar carlos-gil avatar elemoine avatar eleu avatar fredj avatar fvanderbiest avatar ger-benjamin avatar kalbermattenm avatar marionb avatar ochriste avatar pagameba avatar pvalsecc avatar rbovard avatar sbrunner avatar tonio avatar twpayne avatar vicb avatar ybolognini avatar yjacolin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

cgxp's Issues

redlining export KML

Currently we need to add the following (in viewer.js) to get redlining KML export working:

GeoExt.ux.LayerManagerExportWindow.prototype.baseUrl =
"${request.static_url('cartoriviera:static/lib/cgxp/sandbox/LayerManager/ux/')}";

Currently this is not documented at all.
We definitely need to find a workaround for this, or at least document it.

One solution would be to have a baseUrl config parameter for our redlining plugin, but this parameter need to be relayed to the LayerManager ux (which is n-levels deeper).

Zoom triggers unnecessary GetLegendGraphics requests

How to reproduce

  • Select a theme (overlay) and activate alle it's layers
  • Make sure no legend is displayed in the layertree
  • Make sure the legend panel is close
  • Monitor the http requests
  • Zoom in the map
  • The applications fires many unnecessary GetLegendgraphics requests

Expected

  • GetLegendGraphics requests are fired only if the legend is activated in the layertree (for the specific layer) or if the legend panel is open

IE issue with LayerTree opacity slider

Get from #15

With IE I have noticed two problems with the layer opacity slider:

IE7 + IE8: the layer opacity is not always correct when playing with the opacity cursor: for instance the layer items seem darker on the map when slider value is 99% than 100%.

IE7 + IE8 + IE9: when playing with the slider cursor, the layer visibility sometimes switches to false (layer disappears) when sliding back to 100%.

Incorrect footprint of the Print plugin

When the printing plugin is activated, the footprint should automatically be adapted (size+center) when zooming or panning. This behaviour is currently broken.

Azimuth measuring tool

We need a live information on the azimuth angle and distance while drawing the circle, ie Lux : http://map.geoportail.lu/
Besides, as in LUX, we would like to have the altitude difference between the two points

translations are missing

The SITN project uses GeoExt.Lang.add to add translations. I don't think it should. In principle GeoExt.Lang.add should not be used in projects. Do we agree with that?

Layertree KML icon doesn't display KML (neither on map, nor on GE plugin)

How to reproduce:

  • log into the admin interface
  • go to the layer section
  • select a layer
  • add the URL of a KML document in the field "KML 3D" and save
  • load the webgis
  • add the layer to the layertree
  • a KML icon is displayed
  • click on the KML icon
  • nothing happens

Expected:

  • click on the KML icon
  • the KML is displayed on the map
  • the GE plugin openitself and display the KML in 3D

WFSGetFeature bugs

  1. request all layers even the ones not queryable:
    if a query is done on a group, all layers in that group are queried, even if the query has been deactivated in the mapfile, meaning a tab/bloc will be created for that layer in the result panel

  2. in projet morges, the min/maxscale are not respected when doing a query: investigate to see if it's a general problem or only in morges

  3. even if there is not result for a layer, selecting the related tab in the featureGrid trigger a hilight on the map: find why, there should be none.

actionConfig on addKMLFile and WMSBrowser

It would be nice to add some kind of actionConig property to the AddKMLFile and WMSBrowser plugins in order to define a custom tooltip for example (because I didn't find any way to define a tooltip on these plugins...). I think that Alex had done that for some other plugins...

Connexion doest not always work with IE !

On some machines, the connexion button doesn't work with IE. It does not depend on IE versions : on some machines it works with IE 8 and 9, and on other machines it does not work. To reproduce :

1°/ Open http://map.cartoriviera.ch in IE on a machine which has the problem
2°/ Connect with c2c/c2c -> The application reloads, but the connexion button is not in state connected

This is an important problem, several users have mentioned it, and I can reproduce it on my PC at home, but not on my PC at office, with the same IE 9 version...

THANKS

featureWindows - windows become grey and hilight stop working after a while

when using the featureWindow plugin, hovering the mouse over the window's result hilight the related feature on the map.

but if this is done several time (ie, several query followed by several hover), 1) the hilight stop working and if we continue to try to move the mouse cursor over the window, 2) the window content disappear and become all grey.
at this point, the whole featureWindow plugin stop working correctly and it is not possible to do a new query.

this is visible on http://preprod.cartoriviera.ch

"Color" label is not translated into french in "Draw" plugin

in c2cgp when you enable draw (surlignage) feature, draw a point, a windows appears allowing the user to choose the color.

The label should be translated into the langage used in the interface. ie into french if french is a the default langage.

Editing module - mouse pointer

We just saw another bug in the edition plugin. If you don't activate any layer and click into the map, then the mouse pointer turns into the wait mode and doesn't come back to the normal pointer except if you click elsewhere...

Order of layers in layertree is not consistent with the order on the map

Feedback from a client :

I've added a new Layer Group. In there there are several Layers, some have a fill and some have a hatch. To draw the hatched ones over the filled ones I do have to give them an order greater than the filled ones. This way in the legend they appear below the filled layers but in the map they are drawn over the filled layers. This behaviour doesn't seem logically to me. The hatched layers should as well be above the filled layers in the legend (this would be the equal behaviour then as we have for the themes; the most upper ones are drawn over the other themes).

IE print window

When printing through IE, the window telling that the print is done does not contain any text... I tried with SITN, geobl and cartoriviera and it always react the same.

Is that a bug or a Ext/CSS mis-configuration?

Underscores and dashes are not accepted in the login form

Either in the username field or in the password field, the "-", "_" and "+" keys are ignored. At least when the login panel is displayed above the map => in that case, pressing one of those keys will simply zoom/unzoom the map (no problem with the search field for instance). It seems that the key press event is intercepted by the map and not transmitted to the login field?

Inconsistent i18n systems

In CGXP we mainly use the OpenLayers.i18n() system whereas GXP uses GeoExt.Lang. Both systems are quite different:

  • OpenLayers.i18n() is a simple key-value replacement system: strings are translated "on the fly" when used.
  • GeoExt.Lang updates the i18n strings, directly in the properties of the GXP classes

Should we consider using GeoExt.Lang in CGXP as well, in order to keep the consistency between GXP and CGXP?

In addition this inconsistency may create problems. For instance with
https://github.com/camptocamp/cgxp/blob/master/core/src/script/CGXP/plugins/Measure.js
=> this plugin is inspired from a GXP plugin (using GeoExt.Lang) and does not use OpenLayers.i18n(). That would not be relevent since the interface strings are unchanged. However for now translations for this plugin are broken because GeoExt.Lang has no translation for it.
Should we change the plugin so that it extends the original one, and removing the interface string properties?

too many translation strings

The code itself includes translation strings. For example, plugins/ContextualData.js includes this:

    defaultTpl: "Local Coordinates : {coord_x} {coord_y}<br />" +
        "WGS 84 : {wsg_x} {wsg_y}<br />",

This is overwritten in the en.js file:

    "cgxp.plugins.ContextualData.Tooltip.prototype": {
        defaultTpl: "Suisses Coord. : {coord_x} {coord_y}<br />" +
            "WGS 84 : {wsg_x} {wsg_y}<br />",

We should either use translation keys in the code, or use english in the code and remove translations in en.js. GeoExt uses english in the code, and I think we should the same.

If people agree I'll write a patch.

Map responds to keyboard events even when it does not have the focus

When the Google Earth view is visible the user can use the keyboard to move the camera.

Unfortunately, the map also responds to these key events and so the map pans whenever the user moves the camera.

The map should not respond to keyboard events when it does not have the focus.

Print plugin shouldn't assume there is a featureGrid plugin activated

At https://github.com/camptocamp/cgxp/blob/master/core/src/script/CGXP/plugins/Print.js#L236

var printExport = this.target.tools[this.featureGridId].printExport();

=> The print plugin tries to access to the featureGrid plugin. If no featureGrid is available (for instance if one uses the FeaturesWindow plugin instead), a JS error is issued.

=> The print plugin should at least test if featureGrid is available before using it and if not, make sure that the PDF generation succeeds though. It would be useful to support other features listing tool (FeaturesWindow).

WFSGetFeature action automatical deactivation

(At least) in the bl_gis project, the WFSGetFeature control (and its action) automatically deactivates when a response is received from server.
If the response is empty or if no request is sent, the info tool stays active.

In my opinion, the same behavior (deactivation) is intended in both case.

Print invisible features

Actually all the feature (of the FeatureGrid) will be send to the print, but most of them will be marked as display:none ...

Than those feature shouldn’t be send !

Make sure vector layers are above overlays

The vector layers of some CGXP plugins (Fulltextsearch, FeaturesWindow, RedLining ...) are sometimes stacked below WMS layers and then their features may be totally or partially hidden. It generally happens when the user add a new theme on the map.

In OpenLayers, I notice there is only a distinction between baselayers and overlays when setting the z-index of a newly added layer. Therefore, if one adds a WMS layer, its z-index will be higher than the ones of previously added vector layers.

I see at least one exception: it seems that the vector layer bound to the FeatureGrid plugin is always on top. I don't really know why (maybe because this vector layer is also linked to an OL.Control.SelectFeature or something like that, that would keep it above?).

We need to find a solution so that the application vector layers have always the highest z-indexes, no matter how many overlays are added meanwhile.

Make cgxp tests available online

We don't have continuous testing in place for CGXP. And It's unlikely to happen anytime soon. In the mean time we should probably put the test runner page online somwhere, so we can run tests at any time without the need for a local installation.

FeatureGrid javascript error

When doing consecutive queries on the map (using the query tool) the following javascript error is raised:

TypeError: store is null Featur...odel.js (line 254)

Looking at the trace, it seems to be related to an error on line 557 in FeatureGrid.js

requests are avoided by ongoing requests

[ContextualData]
Currently we're using showLocationInMapRequestonGoing to prevent new requests to be sent if a there's a request for which we're waiting for a response.
I think that the resulting behavior is disturbing for the end user when using mouseover. In this case, it's almost impossible to know for which position the response from server is given.
Rather, I think it would be better to cancel ongoing requests if a new request is to be sent.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.