camspiers / json-pretty Goto Github PK

Provides support for json pretty printing in php 5.3

License: MIT License

PHP 100.00%

json-pretty's Issues

Remove Pimple dependency

It's quite clear, from README, that you don't need Pimple to use json-pretty.
I see that you could use Pimple, but I think that it's not fair to keep it as dependency.
You should remove your Container class (maybe adding its code in README) and move "pimple/pimple" from "require" to "suggest".

Breaks DateTime string

If there is a datetime value in the json, it will break the value and cause 2015-09-08 08:56:10 to become 2015-09-08 08: 56: 10

Line 71,
https://github.com/camspiers/json-pretty/blob/master/src/Camspiers/JsonPretty/JsonPretty.php#L71

There are other issues with commas

Using JSON_PRETTY_PRINT

[
    {
        "id": "34",
        "system_id": "2000",
        "src": "***",
        "dst": "790",
        "dcontext": "RingGroups-2000",
        "clid": "***",
        "channel": "SIP\/***-0000005c",
        "dstchannel": "SIP\/2000200-0000005d",
        "lastapp": "Dial",
        "lastdata": "SIP\/2000200&SIP\/2000201),20,ktwx",
        "calldate": "2015-09-08 08:56:10",
        "answer": "2015-09-08 08:56:10",
        "end": "2015-09-08 08:56:20",
        "duration": "10",
        "billsec": "0",
        "disposition": "NO ANSWER",
        "uniqueid": "pbx1-1441698970.92",
        "linkedid": "pbx1-1441698970.92",
        "internal": "0",
        "outbound": "0",
        "inbound": "1",
        "uploaded": "0",
        "ddi": null
    }
]

Using your lib:

[
        {
                "id": "34",
                "system_id": "2000",
                "src": "***",
                "dst": "790",
                "dcontext": "RingGroups-2000",
                "clid": "***",
                "channel": "SIP\/***-0000005c",
                "dstchannel": "SIP\/2000200-0000005d",
                "lastapp": "Dial",
                "lastdata": "SIP\/2000200&SIP\/2000201),
                20,
                ktwx",
                "calldate": "2015-09-08 08: 56: 10",
                "answer": "2015-09-08 08: 56: 10",
                "end": "2015-09-08 08: 56: 20",
                "duration": "10",
                "billsec": "0",
                "disposition": "NO ANSWER",
                "uniqueid": "pbx1-1441698970.92",
                "linkedid": "pbx1-1441698970.92",
                "internal": "0",
                "outbound": "0",
                "inbound": "1",
                "uploaded": "0",
                "ddi": null
        }
]

Problem with escaped quotes

Hi man, thank you for your algorithm. I found some issue with this condition:

json-pretty/src/Camspiers/JsonPretty/JsonPretty.php

Line 86 in 17be37c

($c > 1 && $json[$c - 2].$json[$c - 1] === '\\\\')

When I have string in my app like:

<a href=\"{{.domain_cabinet}}/login?next_url=/contest/fbsstar&utm_nooverride=1"

its formatting into:

<a href=\"{
{
.domain_cabinet
}
}/login?next_url=/contest/fbsstar&utm_nooverride=1"

in source file and breaking it

I fixed this with replacing the second condition to:

($c > 1 && $json[$c - 2] === '\\' && $json[$c - 3] !== '\\'))

camspiers / json-pretty Goto Github PK

json-pretty's People

Contributors

Stargazers

Watchers

Forkers

json-pretty's Issues

Remove Pimple dependency

Breaks DateTime string

Problem with escaped quotes

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent