Giter VIP home page Giter VIP logo

Comments (28)

meilechwieder avatar meilechwieder commented on May 12, 2024 1

This is R&D for auto-update, note for manual is it's already possible.

from capacitor-updater.

riderx avatar riderx commented on May 12, 2024

/bounty $100

from capacitor-updater.

algora-pbc avatar algora-pbc commented on May 12, 2024

πŸ’Ž $100 bounty created by riderx
πŸ™‹ If you start working on this, comment /attempt #72 to notify everyone
πŸ‘‰ To claim this bounty, submit a pull request that includes the text /claim #72 somewhere in its body
πŸ“ Before proceeding, please make sure you can receive payouts in your country
πŸ’΅ Payment arrives in your account 2-5 days after the bounty is rewarded
πŸ’― You keep 100% of the bounty award
ℹ️ If something is not clear ask before working on it, otherwise your chance to rework it is high
πŸ‘¨β€πŸ‘©β€πŸ‘§β€πŸ‘¦ Join the Discord to get help
πŸ™ Thank you for contributing to Cap-go/capacitor-updater!

Attempt Started (GMT+0) Solution
🟒 @ayewo Aug 9, 2023, 7:40:00 PM #242

from capacitor-updater.

aazam-gh avatar aazam-gh commented on May 12, 2024

Hello, I'd like to work on this issue :)

from capacitor-updater.

riderx avatar riderx commented on May 12, 2024

Hi @Alcadeus0 that awesome ! please feel free to ask here any missing info

from capacitor-updater.

aazam-gh avatar aazam-gh commented on May 12, 2024

@riderx How do I reproduce this issue?

from capacitor-updater.

riderx avatar riderx commented on May 12, 2024

@Alcadeus0 you can use the demo app:
https://github.com/Cap-go/demo-app

Acceptance criterial:

  • updated should be download and apply at first launch
  • a loader is visible while the download happen
  • works both in ios and android
  • no code duplication

from capacitor-updater.

aazam-gh avatar aazam-gh commented on May 12, 2024

@riderx running npx cap verify gives me
image
why isn't the pod being found?

from capacitor-updater.

riderx avatar riderx commented on May 12, 2024

this command run from the CI and in local, did you run the command in the root folder?

from capacitor-updater.

aazam-gh avatar aazam-gh commented on May 12, 2024

yes I'm running in the root folder, maybe that's why

from capacitor-updater.

riderx avatar riderx commented on May 12, 2024

mmm ok sorry, you have to have the package manager cocoa pods and use a mac.
This task is pretty hard, good knowledge in ios/android is recommended.
plus you have to understand capacitor env

from capacitor-updater.

aazam-gh avatar aazam-gh commented on May 12, 2024

@riderx i see that's understandable. I use Ubuntu so it won't be possible even if i decide to use a vm with mac OS. You can un-assign me from the issue

from capacitor-updater.

riderx avatar riderx commented on May 12, 2024

I can grant you of half the price if you find a solution in android

from capacitor-updater.

aazam-gh avatar aazam-gh commented on May 12, 2024

Sure, I'll give it a shot

from capacitor-updater.

ayewo avatar ayewo commented on May 12, 2024

Hi @meilechwieder,

Regarding your earlier comment:

This is R&D for auto-update, note for manual is it's already possible.

If you have a moment, mind sharing more details how you currently do it manually?

from capacitor-updater.

ayewo avatar ayewo commented on May 12, 2024

Here goes nothing while I /attempt #72 .

Options

from capacitor-updater.

riderx avatar riderx commented on May 12, 2024

Hey @ayewo I made half of this working, it's done in IOS, I still have some issue in Android.
Have you something on your side ?
Maybe we can join forces

from capacitor-updater.

ayewo avatar ayewo commented on May 12, 2024

Hi @riderx

Maybe we can join forces

You've already done 50% do I really have a choice πŸ˜€?

Since you've coded the iOS implementation, perhaps you could share it so I can translate it for Android.

from capacitor-updater.

riderx avatar riderx commented on May 12, 2024

I'm sorry, I really needed it, and a shower showed me the way ^^.
I just finished the Android part as well 5 min ago.

So the bounty in this state is not available anymore.
I would more now try to battle test it, and be sure this work 100% of the time.
Can you help on that ?
I can do 100 bounty for this

from capacitor-updater.

ayewo avatar ayewo commented on May 12, 2024

Haha @ shower thoughts 😁

Sure. I updated the capacitor-related dependencies for the demo-app from v4.x.x to v5.x. and will share that later.

Is that what you used for initial testing.

from capacitor-updater.

riderx avatar riderx commented on May 12, 2024

i use prod app but you can use this one too

from capacitor-updater.

algora-pbc avatar algora-pbc commented on May 12, 2024

πŸ’‘ @ayewo submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

from capacitor-updater.

ayewo avatar ayewo commented on May 12, 2024

Hey Martin @riderx,

Testing on iOS and Android ended up taking quite a bit of time ... I think some refactoring and/or some unit tests will be usefulβ€”especially for the partial download featureβ€”as I ran into some scenarios where some bundles were failing to delete.

Miscellaneous Issues

  • On Android, I did get the occasional A resource failed to call release so there's a resource leak somewhere.
  • The CLI seems to output an invalid URL at the end of a bundle upload. Towards the end, it will offer the following 404 URL https://web.capgo.app/app/p//logs in its output (or maybe I don't have authorization to see it?):
●  Check logs in https://web.capgo.app/app/p//logs to see if update works.
β”‚
●  Welcome onboard ✈️!
β”‚
●  Your Capgo update system is setup
β”‚
●  Next time use `npx @capgo/cli@latest bundle upload` to only upload your bundle
β”‚
β””  Bye πŸ‘‹

from capacitor-updater.

riderx avatar riderx commented on May 12, 2024

I think you are right i never tested end to end local env so that could be broken, if you need time to fix it i can do bounty for that

from capacitor-updater.

ayewo avatar ayewo commented on May 12, 2024

The demo app worked on both iOS and Android in my testing. Had to fix a minor logic bug in the demo app (the Splashscreen was shown too quickly, an if block never got called) and fixed a minor bug in the iOS plugin.

For the miscellaneous issues, I can open a separate ticket for them later as they’ll require time for me to investigate and fix them.

Right now, I’m trying to complete the work I started on #119 so please accept the PRs I opened for this issue:

Thanks!

from capacitor-updater.

algora-pbc avatar algora-pbc commented on May 12, 2024

πŸŽ‰πŸŽˆ @ayewo has been awarded $100! 🎈🎊

from capacitor-updater.

FernetB avatar FernetB commented on May 12, 2024

Hi!, i have a question

Where i can see how to make a loading page with auto update: true and direct: true?

from capacitor-updater.

riderx avatar riderx commented on May 12, 2024

You can find it here:
https://capgo.app/docs/plugin/force-update/#direct-update

from capacitor-updater.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.