Giter VIP home page Giter VIP logo

core-app's People

Contributors

tansudasli avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

core-app's Issues

Add canActivated capability to auth. mandatory pages

  • master can be seen.
    • if user clicks, route to / again
  • [x ]detail pages are for authorized users only!
    • if directly try to access, route to / again.

use ng generate guard components/authz/authentication.guard, then update app-routing.module.ts for related parts

performance check and updates

google page score for

  • mobile 82-84
  • desktop 97

after prod. configs completed, this should be done !

below results are v1.0.0-M1 results

google - desktop

google - mobile

webpage -

consider material.ts file location

it is under app/material/material.module.ts.
but is it much better as app/app-material.module.ts. this is main modules like app/app-router.module file.

Impl. data model in Firebase db

  • define related entities in firebase db
  • implement w/ dummy data and real data model
  • replace static coded data w/ data from firebase

possible search queries

master

  • search in master records (any field)
  • search in latitude and longitude based (near records of user x,y coordinates)
  • master has detail records
  • filter master records which has xyz tag in detail records

detail

  • detail.component: search in detail records (any field)
  • detail.component: search regarding to 1st day, 2nd day, 3rd day (additional fields)

user

  • access user by uid and related details

impl. auth. w/ google capabilities

  • login w/ google
  • logout
  • continue as XXX
  • auto register user data in firestore for additional data
  • update routes and ban unauthenticated users to access some pages

Add basic PWA capabilities

  • only basics to feel more web-app in browser.

  • ng add @angular/pwa --project core-app does the most of the job.

  • not implemented service workers.

  • not implemented appshell for better rendering

firebase keys must be hide in rep.

under the environments/ folder, firebase keys are open and accessible.
it shouldn't be

  • consider, injecting these values in ci/cd pipelines ?
  • consider below as ci/cd pipeline options
    • github actions-beta
    • google build
    • circleci

Inject semantic web tags

-use role="section" kind of semantic web things in .html files.

this is critical for assistive technologies and user agents (bots)

Imp. data model for user

  • update user.model.ts file for missing fields such as lat,lang etc.

there r 2 records.

  1. in firebase firestore db
  2. in firebase authentication

and 1st one has many fields than 2nd one.

2nd provides some fields (emailVerified etc..), and we should store in 1st one, also.

Implement service workers

Increase PWA score

  • implement service workers.
  • implement appshell for better rendering
    • in browser, loading logo (w/ appshell ?)
    • after addtohomescreen, loading logo in chrome
    • after addtohomescreen, loading logo in safari
  • manual PWA checks

pwa

redirect problem from /index 2 index

  • app-routing.module
    'index' routes to 'MasterComponent'.
    but when the url ' ' refreshed (onLoad pages comes w/ this), it routes to '/index'

on production this creates a 404 error.

Preps. to deploy firebase (must for auth. impl.)

  • firebase init
  • changes in environments/environment.prod file (dev and test is same )
  • ng build --prod
  • firebase deploy
  • google consent approval (mandatory for signin w/ google)

mandatory for auth. implementation

getting user consent

  • login w/ google

    • auto set true all consents, then show them in accounting page
    • redirect to getting consent page
    • later, get consent from user (worst one)
  • login w/ phone

    • verify/verification path already shows consents.

Impl. additional pages

  • library
  • account
  • search
  • menu
    • when user click hamburger menu, on the top bar, it opens up.
    • think of move signout link to here also.

css updates

  • understand materialized css and apply better for responsive and mobile designs

inject additional pages such as 404

  • 404 (not found)
    • angular part page-not-found component.
    • firebase 404.html.
  • 500 (unexpected)
  • 403 (forbidden)
  • 401 (unauthorized)
  • connection failures
  • custom error pages
  • terms
  • privacy

poi based search in firebase for default filtering

  • get user location
  • then search poi based search to filter near
  1. should this be a core-app capability ? or we should just use a search based capability instead of default location based filtering?
  2. or how can we extend core-app for such kind of things considering the updates later ?

ga impl.

  • w/ tag manager inject into html files
  • adjust ga capabilities (scrolling etc.)
  • firebase-ga impl.
  • check reporting, funnels, urls etc..

impl. auth. w/ phone capabilities

  • impl. login w/ phone
  • logout
  • auto register user data in firestore for additional data
  • update routes and ban unauthenticated users

below is necessary if user goes w/ login w/ phone.

  • impl. authz/register pages components
  • store it in firestore.

otherwise we are eliminating registration steps (instead automatically create register data comes from google signin)

project structure for model files

separating Detail.ts and Master.ts under model/ folder is not good. angular doue not use MVC pattern, and also MVVM is not appropriate for project folder hierarchy !

so it is best to utilize model files, where the upper-related components!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.