cardjizzerapp / cardjizzerbackend Goto Github PK

Currently every player can start a game they've joined. Restrict the start ability only to the owner.

The current build is failing due to not working tests. The code has been changed to work with callbacks. Not all commands are working with this.

The current server (http-package) does not support SSL encryption. We should introduce the https package.

Files to change: app.js

The current README looks quite empty concerning the "how to start contributing" part. Add some basic documentation for every developer which wants to add something to this project. Add commands for testing, building and linting the projects' code.

The logo of the README.md file is currently in each repository that uses this logo.

Due to multiple repositories containg our logo I would suggest moving this svg file to the assets repo and reference it in this and every other readme.md file

Current situation

There is a command (setUsername) used for creating a link between the websocket and the user that wants to log in. Since this command is now deprecated and will be replaced by the login command there is now a need for using real Google oauth data in unit tests (or maybe not. Have a look at solutions).

Solutions

Multiple solutions are conceivable.

• Create and insert a dummy user after the database was created and use those credentials.
• Use real Google oauth data

Unfortunately Google doesn't provide such dummy data. The only possible way of implementing the second approach would be real users that need to provide a refresh token every 60 minutes.

Conclusion

Considering only the effort put in the first approach it would be the better one.
BUT
This will result in a lower test coverage and the oauth mechanism can then be broken easily.