carlalexander / passwords-evolved Goto Github PK

It looks like the plugin doesn't work when installed in the mu-plugin folder.
When trying to login from wp-login:

2020/01/02 19:30:21 [error] 22873#22873: *1832 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught Error: Call to a member function get_password_generator() on null in /var/www/html/wordpress/web/app/mu-plugins/passwords-evolved/pluggable.php:58
Stack trace:
#0 /var/www/html/wordpress/web/wp/wp-includes/class-wp-session-tokens.php(149): wp_generate_password(43, false, false)
#1 /var/www/html/wordpress/web/wp/wp-includes/pluggable.php(881): WP_Session_Tokens->create(1578166221)
#2 /var/www/html/wordpress/web/wp/wp-includes/user.php(101): wp_set_auth_cookie(1, false, true)
#3 /var/www/html/wordpress/web/wp/wp-login.php(1187): wp_signon(Array, true)

Note: using a Bedrock install

I have noticed there's a trunk directory in the release that contains the same files that are already in the root directory.

https://haveibeenpwned.com/API/v3

On certain sites running Jetpack v11 and Passwords Evolved v1.3.2 I'm seeing PHP fatal errors which crashes wp-admin and WP-CLI over the command line. This is also an open issue on Jetpack: Automattic/jetpack#23835. The odd thing about the error is that it's very temperamental. I just deployed Passwords Evolved to 500 sites and only 26 of them are showing PHP fatal errors in the error logs. Out of those some I can't sign into the wp-admin some I can. Also what's bizarre is that the PHP fatals seem to go away after completing a full Jetpack sync over the command line.

wp jetpack sync start --skip-plugins=passwords-evolved

Here is what the error log looks like.

PHP Fatal error:  Uncaught InvalidArgumentException: Container doesn't have a value stored for the "password.generator" key. in /www/public/wp-content/plugins/passwords-evolved/src/DependencyInjection/Container.php:94
Stack trace:
#0 /www/public/wp-content/plugins/passwords-evolved/src/Plugin.php(79): PasswordsEvolved\DependencyInjection\Container->offsetGet()
#1 /www/public/wp-content/plugins/passwords-evolved/pluggable.php(59): PasswordsEvolved\Plugin->get_password_generator()
#2 /www/public/wp-content/plugins/jetpack/jetpack_vendor/automattic/jetpack-connection/src/class-client.php(132): wp_generate_password()
#3 /www/public/wp-content/plugins/jetpack/jetpack_vendor/automattic/jetpack-connection/src/class-client.php(37): Automattic\Jetpack\Connection\Client::build_signed_request()
#4 /www/public/wp-content/plugins/jetpack/jetpack_vendor/automattic/jetpack-connection/src/class-client.php(453): A in /www/public/wp-content/plugins/passwords-evolved/src/DependencyInjection/Container.php on line 94
Fatal error: Uncaught InvalidArgumentException: Container doesn't have a value stored for the "password.generator" key. in /www/public/wp-content/plugins/passwords-evolved/src/DependencyInjection/Container.php:94
Stack trace:
#0 /www/public/wp-content/plugins/passwords-evolved/src/Plugin.php(79): PasswordsEvolved\DependencyInjection\Container->offsetGet()
#1 /www/public/wp-content/plugins/passwords-evolved/pluggable.php(59): PasswordsEvolved\Plugin->get_password_generator()
#2 /www/public/wp-content/plugins/jetpack/jetpack_vendor/automattic/jetpack-connection/src/class-client.php(132): wp_generate_password()
#3 /www/public/wp-content/plugins/jetpack/jetpack_vendor/automattic/jetpack-connection/src/class-client.php(37): Automattic\Jetpack\Connection\Client::build_signed_request()
#4 /www/public/wp-content/plugins/jetpack/jetpack_vendor/automattic/jetpack-connection/src/class-client.php(453): A in /www/public/wp-content/plugins/passwords-evolved/src/DependencyInjection/Container.php on line 94
Error: There has been a critical error on this website.Learn more about troubleshooting WordPress. There has been a critical error on this website.

If the site is on localhost or maybe even when WP_DEBUG = true, bypass the password check. Not sure which approach you'd prefer.

I found myself locked out in development because my local installation's user/password is test test

Just an early Issue to track my collaboration for improving internationalization.

• make more strings translatable
• add PT-BR translation

PHP Deprecated: Return type of PasswordsEvolved\DependencyInjection\Container::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in */wp-content/plugins/passwords-evolved/src/DependencyInjection/Container.php on line 83

Adding the attribute seems to silence this.

As this plugin is hosted on wordpress.org, the existing language files should be moved to translate.wordpress.org and the functions required to load .mo files should be removed.

From: https://wordpress.org/support/topic/wp_debug-php-deprecated-crypt/

Multiple unique WP_DEBUG notices on PHP 7.4.1 with latest version of WP core and all plugins and themes up to date:

PHP Deprecated: crypt(): Supplied salt is not valid for DES. Possible bug in provided salt format. in /wp-includes/class-phpass.php on line 272
PHP Stack trace:
PHP 1. {main}() /wp-login.php:0
PHP 2. wp_signon() /wp-login.php:1248
PHP 3. wp_authenticate() /wp-includes/user.php:95
PHP 4. apply_filters() /wp-includes/pluggable.php:549
PHP 5. WP_Hook->apply_filters() /wp-includes/plugin.php:206
PHP 6. wp_authenticate_username_password() /wp-includes/class-wp-hook.php:287
PHP 7. wp_check_password() /wp-includes/user.php:170
PHP 8. PasswordsEvolved\Password\Hasher\PasswordHasherChain->is_password_valid() /wp-content/plugins/passwords-evolved/pluggable.php:35
PHP 9. array_reduce() /wp-content/plugins/passwords-evolved/src/Password/Hasher/PasswordHasherChain.php:93
PHP 10. PasswordsEvolved\Password\Hasher\PasswordHasherChain->PasswordsEvolved\Password\Hasher\{closure:/wp-content/plugins/passwords-evolved/src/Password/Hasher/PasswordHasherChain.php:87-93}() /wp-content/plugins/passwords-evolved/src/Password/Hasher/PasswordHasherChain.php:93
PHP 11. PasswordsEvolved\Password\Hasher\WordPressPasswordHasher->is_password_valid() /wp-content/plugins/passwords-evolved/src/Password/Hasher/PasswordHasherChain.php:89
PHP 12. PasswordHash->CheckPassword() /wp-content/plugins/passwords-evolved/src/Password/Hasher/WordPressPasswordHasher.php:68
PHP 13. crypt() /wp-includes/class-phpass.php:272

PHP Deprecated: crypt(): Supplied salt is not valid for DES. Possible bug in provided salt format. in /Users/cliff/Local Sites/calc/app/public/wp-includes/class-phpass.php on line 272
PHP Stack trace:
PHP 1. {main}() /Users/cliff/Local Sites/calc/app/public/wp-login.php:0
PHP 2. wp_signon() /Users/cliff/Local Sites/calc/app/public/wp-login.php:1248
PHP 3. wp_authenticate() /Users/cliff/Local Sites/calc/app/public/wp-includes/user.php:95
PHP 4. apply_filters() /Users/cliff/Local Sites/calc/app/public/wp-includes/pluggable.php:549
PHP 5. WP_Hook->apply_filters() /Users/cliff/Local Sites/calc/app/public/wp-includes/plugin.php:206
PHP 6. wp_authenticate_username_password() /Users/cliff/Local Sites/calc/app/public/wp-includes/class-wp-hook.php:287
PHP 7. wp_check_password() /Users/cliff/Local Sites/calc/app/public/wp-includes/user.php:170
PHP 8. PasswordHash->CheckPassword() /Users/cliff/Local Sites/calc/app/public/wp-includes/pluggable.php:2416
PHP 9. crypt() /Users/cliff/Local Sites/calc/app/public/wp-includes/class-phpass.php:272