carlosalberto / libhoney-cs Goto Github PK

Provide a Makefile for usual stuff, such as:

• Tests
• Clean
• Build

We do not have batches support for sending Events yet.

the other libhoneys have switched to a model where they publish on a tag build on master, which is pretty handy.

publishing to nuget from travis-ci:
https://stackoverflow.com/questions/41509608/how-do-i-deploy-nuget-packages-in-travis-ci

libhoney-js's deploy block:

https://github.com/honeycombio/libhoney-js/blob/master/.travis.yml#L4-L9

At the moment, we have the initialization happening through a singleton (Honey.Init()), but we could have it as a single instance, such as other connectors do, i.e. new Honey('MyComponent', 'mykey01').

Observe this is a simple change but would involve a lot of boring refactoring here and there ;)

I don't know how important, but we could try testing against .Net core - I saw there's some support for it, so we could consider it.

Just realized Event.SendDroppedResponse needs to be implemented. We already have a Transmission.EnqueueResponse method so it should be a matter of exposing it and calling it.

This includes examples and actual API docs - should we include inline documentation, as other Honey connectors do?

This includes preparing the signature, updating the InternalsVisibleTo for the Test assembly, etc.

We should be able to automatize version bumping, to synchronize it with the current Makefile + Assembly information (unless manual publishing to Nuget is always the taken route).

This is already done in the Go library, and it's more of an optimization.

This is something the Go connector does, and we should likely support that as well.

(This is a potential improvement)

Right now Responses is of type BlockingCollection - which means that the user can read and write to it. We should probably offer an opaque interface, i.e. so the users can't add objects there.

Observe that BlockingCollection implements IReadOnlyCollection, but that interface doesn't offer the nice TryTake method.

We could still offer other common interfaces, such as ICollection (as BlockingCollection as of now does).