caseywebdev / backbone-composite-keys Goto Github PK

This line breaks when collections define .model as a function rather than the actual model: https://github.com/caseywebdev/backbone-composite-keys/blob/master/lib/backbone-composite-keys.coffee#L41

Backbone is always doing a PUT on models with a composite key, no matter if they are new or not. I'm assuming because of the generated ID the isNew property is always set to false.

I want to have both an integer id, and a composite key otherId, and have the composite key as the main id of the model.

Is there currently a way of doing this?

Backbone 0.9.9 's collection.get method was changed to separately check @_byId and @_byCid:

https://github.com/documentcloud/backbone/blob/0.9.9/backbone.js#L737

Unfortunately, the current master has already reverted back to the 0.9.2 behavior of having a single @_byId, so any change made would be just for 0.9.9.

I tried splitting it out like this:

 return this._byId[obj.id || @model::_generateId(obj) || obj] || this._byCid[obj.cid || obj]

Only to find that @model::_generateId(obj) causes another error when collection.model is defined as a function (as recommended in jashkenas/backbone#793), as collection.model.prototype isn't the model's own prototype. I've removed that specific _generateId call in my project to get it functional for now - what's the scenario where both the id and cid are blank? The final version I'm running for the moment (which seems to work for my use cases) is:

 return this._byId[obj.id || obj] || this._byCid[obj.cid || obj]