Comments (5)
Thanks for doing this, I know this is a widely desired feature.
I would suggest raising it as a PR anyway, as it will make it a lot easier for others to comment on your code and suggest ways to improve it.
This needs checking, but as far as I'm aware you will ask the NDI lib for video in a format, and it will always give it to you in that format, so you don't need to handle colour space conversions unless you think you can get it to perform better. I've never looked into how ycbcr colour spaces are handled in caspar, so can't currently comment on if it can be made to work as is. That feels like something that can come as a second PR though
from help.
Hello Ianshade, thank you for carrying out this work. Would it be possible to provide an already built version so that we can test?
from help.
Okay, I'll make a PR after making some adjustments that already have been suggested by others or came to my mind.
Yes, supporting only BGRA means that sources with other pixel formats will work with no problems but the NDI library has to perform the conversion (if needed, the library also deinterlaces and resamples audio). It probably is done in the fastest way a CPU can do it, but in my opinion it is still an unnecessary conversion and using 4:2:2 instead of 4:4:4:4 where possible would mean half as much data to move around. My non-scientific tests confirm that it changes a lot (almost double the performance) so I'll definitely look deeper into this 😃
from help.
I published a release on my fork :)
https://github.com/ianshade/server/releases/tag/v2.2.0-beta7-ndi-v1
from help.
Closing this issue as a PR has been raised and further discussion can be had there: CasparCG/server#1112
from help.
Related Issues (20)
- NDI +CASPARCG informations HOT 2
- CasparCG + NDI on Linux - Incorrect file extentsion HOT 3
- can not record stereo audio
- MP4 recording can't be imported in Adobe Premiere (recorded with v2.2 or v2.3)
- smooth text movement on casparcg html template
- Link is 404 for sample configs in guide page “ Guide: Example Server Configuration” HOT 3
- Wrong OpenGL version in help text HOT 3
- Caspar 2.3.0 and Intensity Pro 4k HOT 1
- Build on Debian 9
- FFmpeg producer OSC Data prefix is wrong
- 2.3 LTS - Unhandled Exception Shortly After FFMPEG Warnings HOT 5
- HTML Templates not working HOT 5
- File extension behaviour between releases
- Delete
- Casparcg 2.2.0 video contactor same as 2.09
- POSTING TO THE FORUM
- AMCP 2.3 lts INFO SERVER issue
- Woff2 font dosent work in casparcg
- HTML Lower Thirds Over Video Causes Lagging and Freezing
- Performance issues in WSL2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from help.