catalysts / cat-boot Goto Github PK

The first time that I load an Angular page with a cb-enum select control, it is not populated and I see an error in the developer console. The error is not seen when I subsequently reload the page, perhaps due to caching.

This can be reproduced with https://github.com/Catalysts/cat-boot-sample (master), loading http://localhost:8080/angular#/dynamic-page-1. Adding a loading screen does not fix the issue (see branch feature/jc/loading-screen).

The error is shown below:

angular.js:13294Error: Not yet initialized!
    at CatBootEnumService.list (http://localhost:8080/webjars/cat-boot-i18n-angular/0.0.10/cat-boot-enum/cat-boot-enum-service.js:35:23)
    at link (http://localhost:8080/webjars/cat-boot-i18n-angular/0.0.10/cat-boot-enum/cat-boot-enum-directive.js:28:48)
    at ma (http://localhost:8080/webjars/angular/1.5.2/angular.min.js:79:117)
    at n (http://localhost:8080/webjars/angular/1.5.2/angular.min.js:64:405)
    at g (http://localhost:8080/webjars/angular/1.5.2/angular.min.js:57:378)
    at n (http://localhost:8080/webjars/angular/1.5.2/angular.min.js:64:349)
    at g (http://localhost:8080/webjars/angular/1.5.2/angular.min.js:57:378)
    at g (http://localhost:8080/webjars/angular/1.5.2/angular.min.js:57:395)
    at http://localhost:8080/webjars/angular/1.5.2/angular.min.js:57:17
    at A.link (http://localhost:8080/webjars/angular-route/1.5.0/angular-route.min.js:7:442) 

In JavaMelodyAutoConfiguration, I suggest to add the following code, otherwise controllers with @RestController are not monitored

@ConditionalOnProperty(name = "javamelody.enableSpringControllerMonitoring", havingValue = "true")
@Bean
public MonitoringSpringAdvisor springRestControllerMonitoringAdvisor() {
    final MonitoringSpringAdvisor interceptor = new MonitoringSpringAdvisor();
    interceptor.setPointcut(new AnnotationMatchingPointcut(RestController.class));
    return interceptor;
}

There is neither a dist.js nor a dist.min.js in the webjar; thus all files inside the webjar need to be loaded separately in web applications

when I define the javamelody.monitoringPath in my application.properties it is ignored

the setMonitoringPath() method in JavaMelodyAutoConfiguration is never called

when I have time I will fix it and provide an MR