crud-blog's People
crud-blog's Issues
routes
- 266 lines is a lot. abstract out to separate files. if you're using commented out name spaces, it's a logical time to create a new file.
- router.get('/single-blog/:id/remove-content) is using a query that is called getCommentID and anther called getPostId or something. the naming is is unclear. we thought that you maybe were using the incorrect fields to request info.
- router.post('/post') has a req.send at line 114. it should be a next() or a res.send.
config files
DS Store should be in gitignore
queries
- some of these queries are really wide. consider line breaks.
- your commented out guides do not actually delineate what is in each section
- inconsistent indentation
Post to Heroku!
Post your site to Heroku so others can post!
passport.js
authenticateUser in your code is really just a findUser. authentication entails actually checking their username and password
app.js
You are using a process.env.Secret on your session secret. but not requiring dotenv to your app.js file. is this broken?
29 commits
- good commit frequency
- yay some feature branch workflow
- some of the commit messages aren't terribly helpful
index.hbs
You have
inside your text elements. Please just use separate
's or or /n to break line
Looking at deployed site
- typically users can click on images on posts
- users can't delete their comments and can also see the delete comment link for others' comments
- the content text area has a funky space in it for value because the closing tag is on the next line
- all the fields on the add new posts form is a text area? is this necessary?
- the title of the post is the header of the page on the update page.. feels strange
- users can delete own posts!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.