Not sure if we can pull AppVeyor artifacts directly or if we need to make GitHub releases out of them.
I'm concerned some people aren't going to be happy about building the DLL themselves!

Setup release branch to automatically build and deploy to SVN when it is pushed to.

1>Unhandled Exception: System.IO.FileNotFoundException: Could not load file or assembly 'LibGit2Sharp, Version=0.26.0.0, Culture=neutral, PublicKeyToken=7cbde695407f0333' or one of its dependencies. The system cannot find the file specified.
1> at GitVersion.Program.Main()
1>NMAKE : fatal error U1077: '"..\Tools\C2C-GitVersion.exe"' : return code '0xe0434352'

This appears to happen only with player automated naval bombard missions, where the target unit is destroyed sometime during the mission life time. The exe attempts to read the mission units, and an access violation occurs.

I guess there is a git function + parsing we can do to list changes in sources directory, if there are none then we can skip code build on appveyor

This means changes to ids breaks them every time.

void PropertySpawns::read(FDataStreamBase* pStream)
{
    CvTaggedSaveFormatWrapper&    wrapper = CvTaggedSaveFormatWrapper::getSaveFormatWrapper();

    wrapper.AttachToStream(pStream);

    WRAPPER_READ_OBJECT_START(wrapper);

    WRAPPER_READ(wrapper, "PropertySpawns",(int*)&eProperty);
    WRAPPER_READ(wrapper, "PropertySpawns",(int*)&eUnitClass);

    WRAPPER_READ_OBJECT_END(wrapper);
}

Having deps and intermediate files including the version.cpp in the Sources directory leads to problems with the Appveyor Build Cache.
We could move these in a sperate Build directory.

https://gist.github.com/baldurk/c6feb31b0305125c6d1a

This will solve problems with mismatch source code and pdb. i.e. As long as you have the pdb you can get the correct source code version of files pulled directly from git automatically.

Bad movies needs replacement or removal.

Notes:
-Still images should be .dds instead of .bik.
-The python code that triggers these movies for buildings will need look at the path ending to see if it's a .bik or a .dds, as they cannot be displayed with the same code, new code is needed for displaying a simple dds image instead of a movie.
-The correct ART_DEF_MOVIE_X then needs to be added back to all the wonders and other misc stuff that triggered movies.

In combination with #68 this causes crashes, and weird behaviour and so many camels.
Fix is just to clear them when resetting city ready for recalc.

This was broken by changes to IDValueMap in svn10994.

File: ..\CvGlobals.cpp
Line: 5414
SVN-Rev: 10998
Expression: stricmp(szType, "NONE")==0 || strcmp(szType, "")==0
Message: info type 'ADAPT_SCALE_CITY_LIMITS' not found, Current XML file is: modules\Natural_Wonders\Reef_Shark_CIV4SpawnInfos.xml

Needed to run FPKLive + other tools so we better make sure everyone has it installed!

http://www.symbolsource.org/Public

This will allow pdb to be automatically retrieved for any crashdump. This combined with the source indexing means only the minidump is needed, everything else is automatic.

Here's the documentation https://www.appveyor.com/docs/build-cache/

Some possible features:

• query/filter options
• mass edit of a set of objects of the same class
• clone existing object
• reference navigation through related objects
• perform script based modification (e.g. run on a property value = value * 0.5)

https://www.microsoft.com/en-in/download/confirmation.aspx?id=5555
It is only required for running fastdep.exe so just package the dlls it needs directly instead of the full dist exe.

TBNote: I've found both a crash scenario in PBEM and an infinite hang scenario in single player.
A player complained about exceedingly strange graphic artifice when they encircle the globe with a singular culture that possesses the GW and the hang looked to have a similar basis.
Unfortunately, I'm no front end specialist and I don't have a theory on how to isolate the cause except to say that it's the new way that the GW is being processed that's causing the crashes and hangs.
So for now, this is disabled. I may eventually create a manual option to turn it off or on and that would give us the ability to turn it off only if it's creating problems.
Better would be to FIX it but I've got no clue on that.
@Thunderbrd

Perhaps lowest, average, one era behind?

I promised @Toffer90 to add a DLL function for getting proper mouse position for tool tips.

Remapping isn't used for eCommerce asset changes could break saves.

Changed in #18 seem to be responsible. Something isn't being reset between loads.


@alberts2

We can test all DLL build configurations on CI on each commit.

https://codescene.io
Code analysis.

Would be nice to do this. We can tag our changes in github commit messages, then generate the change description automatically via script for each release to SVN (and final release in fact).
Normally we don't want ALL change descriptions to go into the player/tester facing change description.

No reason we couldn't also select a unit on loading from a save where not all units have moved either I think? That always bugged me.

@alberts2
We have to have Tools for the project to build, it isn't shared or owned by someone else, so having a separate submodule just adds friction to all operations. e.g. Writing things that require changes to tools and code/makefile etc.

Can not load game with current Main

Probably a formatter broken.

https://forums.civfanatics.com/threads/single-player-bugs-and-crashes-v39-plus-svn-after-the-20th-of-july-2019.647928/page-46#post-15530822

We should run this automatically for every commit.

Auto packing FPKs on DLL load with cache/change detection etc.

CPPCheck is good, takes a LONG time to run though. 1 hr is cap for AppVeyor.
Shouldn't run this all the time, maybe nightly/weekly.

Describe:

• FPK Live + UnpackedArt.
• The various scripts.
• The DLL build environment: deps.exe contents etc.
• The various DLL builds and their purposes.

Development prerequisites (are there any now?).
(My) recommended tools for various tasks.

The appveyor one works fine, but I can't setup the github one, I have no access to most settings on this project.

Spelling, incorrect capitalization.

Avoiding them dying to terrain damage.

@alberts2 Perhaps this is intentional, but I have no write access to master, I can't accept a PR to it.

Run it for Python changes only

@alberts2 I got this before and after merging your save compat fix branch, not sure what it is about I'm sure my saves were working before :/

This is after resaving the save file, my old ones load fine.

Requires python code that supports this convertion.

Looks like it could be inconsistent with regard to multiplying and dividing by 100. At some point a mod was integrated that required it, but it isn't clear it was correcting done, need to get the mod and original code probably.

Then again maybe it is fine...

We need something to make sure that people don't forget to recompile the dll.
That might be necessary after they switch to another branch or pull changes from our github repo.

@alberts2 I sent a request from appveyor to the caveman2cosmos org in github for installation of appveyor to Caveman2Cosmos repo. I think it will be in the repo settings maybe? I can't see it anyway I think maybe only you can?

Would be nice to have one!
It can certainly work for official release, and perhaps offer option to automatically pull and update SVN version as well.
Having ability to select mod-mods, tweak parameters, modules etc without needing to mess with xml files or whatever would be pretty great.

They use virtual functions, why?
They are slow at lookup due to calling a function on their containing classes.
What reason is there to believe they are better than a hashmap?