cbeyls / htmlconvertercompose Goto Github PK

Since ClickableText that handles hyperlinks clicks is deprecated, is there a better solution?

Right now hyperlinks are always underlined and it would be nice if it was possible for clients to define the SpanStyle used there.

I understand this goes beyond the scope of replacing Android's Html.fromHtml() API, so I totally understand if it’s also out of the scope of this library. But since this may potentially be a blocker for some people (it would be for me), I thought I would still file this just in case.

I guess the simplest option would be to receive a urlSpanStyle as an argument for AnnotatedStringHtmlHandler. I’m hoping since we’re already receiving the compactMode boolean there, this won’t hurt the API too much.

I’ll open a PR so it hopefully helps discussing about this change. And thanks a lot for open sourcing this ❤️

I’m not a line break tag expert and I don’t have any authority over the topic, but it seems that just <br> is a pretty popular and well accepted form of using the line break tag. I actually thought this was a bug in the library since my line breaks weren’t working, but then I realized it explicitly doesn’t do anything on the line break tag open. I thought the fix would be to simply do the same thing we do on tag close, but it seems there’s more to it.

This is what the sample looks like right now, with a red box at the bottom so we can observe the bottom space of the text:

If I simply change the <br /> to a <br> in the sample, this is what we get:

We lost the line break as expected, but for some reason now we have a line break at the end of the text. So if I proceed with the fix I had in mind, this is what I get:

Line break is back but 1. it’s just a single line break now for some reason, and 2. the mysterious line break in the end remains. I haven’t investigated it further and I thought I’d file the issue just in case this is already something known.