[Suggestion] indigo branch about scan_tools HOT 6 CLOSED

Why not just leave the master as the default and rebase it with the indigo branch?

from scan_tools.

@130s I branched a new indigo branch from master.

from scan_tools.

Why not just leave the master as the default and rebase it with the indigo branch?

So that handling an issue like #24 becomes easier; For example, if we merge #24 into master (assuming my comment #24 (comment) was right that the PR #24 works only for post-Hydro), people who still want to use Hydro can't build from master out of the box, but they still can using hydro branch that already exists.

(Note that separating distro(s)-specific branches may require backporting commits that work in earlier distros, if we like to maintain the same feature over branches. This may depend on requests from users IMO. I know at some repositories maintainers make great effort to make master compatible to various distros, but I must say it seems it gets costly in general)

Hope my explanation is clear.

from scan_tools.

And for default branch, I also insist on making the latest as the default branch. That way we can reduce the effort of maintaining branches (same is done at many ROS repositories).

from scan_tools.

@130s Ok. I agree. Forgive my ignorance: I have been out of the ROS loop for a couple of years so I'm trying to get back to the game. I made the indigo branch the default branch of this repo.

from scan_tools.

No need to be sorry at all! These things are not documented anywhere, only repository stalkers know 🌴

from scan_tools.