cds-snc / c19-benefits-node Goto Github PK

• RRIF
• Gross income
• Days stopped working

...and then configure Cypress-Axe to connect to a11y-tracker (Dave has the API key)

Got some in there, could use more robust testing

We should not display 500 errors to users in production.

Seems pretty narrow (see question wrapping):

According to design:

When the interface scales down, the French language toggle wraps to a new line

...should be enough room to keep it aligned like the designs

These steps are being removed. Routing changes should be taken care of in other issues.

Update content per figma design

Let's add some SAST Testing as soon as this is open sourced.

Summary

We noticed a couple problems with rendering details/summary elements, as well as svgs in Edge. It looks like you don't have them at the moment, but if you start adding them, ping me and I'll test them out in browserstack.

More detail can be found here: cds-snc/cra-claim-tax-benefits#417

Github actions -> Test -> Build -> Deploy

3 steps

• Test
• Build
• Deploy

Summary

Above the question, we want to put the service name and the "start over" link.

mockup	what we have now

Update content per figma design.

According to this issue custom domain support is not yet available for Azure CDN Endpoints in the terraform provider.

To get around this for now, adding custom domains through the Azure Portal.

All the schemas in our current code aren't relevant/don't apply to our forms + flow. Remove unneeded ones, and add just a simple one for our current questions (which at this time are just required).

Make sure that an appropriate error message is present as well.

If someone somehow arrives on a question screen and they don't have any session data, they should probably be kicked back to the start.

Big green button on Start, and buttons on the rest of the screens (probably just update the macro).

As noted in #122 there are a few issues with the way back link is integrated. With out timeline, it works for now, but in the future, would be nice to find a better solution.

• If they come in in the middle of the app, the link won’t show
• If the session clears in the middle, it also won’t work
• It’s not perfect on the first language toggle (but I’m hesitant to put a solution for this in place until #97 is worked out)
• if a person errors, the referrer will become the same page

Would like to be able to track a user through the service. To do that, could add some kind of identifier to the log output.

That identifier could perhaps be a session ID? a GUID? a hashed IP?

See new designs in Figma. The Question is no longer the <h1> element, there is a new heading element on the page.

PR #113 removes the <h1> from the radios macro.

Update the content on the start page (as seen in the figma designs)

Checking with @michellengaiCDS about where things should be linking out to

Bring over the notifications from CPPD

Made the wrong assumption that retired folks go straight to RRIF, but it's just that the result is added for them, and so that needs to be amended so they still get asked about mortgage, etc.

Will double check the routing and add the changes while at it

Update content per Figma design

In order to hand this back to ESDC we will need to make some changes to align with ESDC Cloud Policies (Or at least what they were before covid-19).

• Follow naming convention for prefixes
  Example: https://github.com/cds-snc/cppd-infrastructure/blob/master/cppd_medical_report/locals.tf
  https://github.com/cds-snc/cppd-infrastructure/blob/master/cppd_medical_report/terraform.tfvars
• KeyVaullt to store secrets
  https://github.com/cds-snc/cppd-infrastructure/blob/master/cppd_medical_report/azure_key_vault_secrets.tf
• AppService should get passwords from KeyVault
  https://github.com/cds-snc/cppd-infrastructure/blob/bcbb1d88ddd214552d01017b9a5bda7235516f51/cppd_medical_report/app-service-docker.tf#L39
• Common tags for a project
  Example: https://github.com/cds-snc/cppd-infrastructure/blob/master/cppd_medical_report/locals.tf

We'll have two domains resolving to our service:

• covid-benefits.alpha.canada.ca
• covid-prestations.alpha.canada.ca

At minimum, users coming in on the French domain should default to french.

Additionally, we should probably also handle switching the subdomain when switching languages.

For discussion: what to do when the subdomain and url path don't match? ie, what to do if someone arrives at the url: https://covid-benefits.alpha.canada.ca/fr/debut?

• Do we redirect to https://covid-benefits.alpha.canada.ca/en/start?
• Do we redirect to https://covid-prestations.alpha.canada.ca/fr/debut?
• Do we just render based on the uri? (so the domain only matters when entering, but after that just the URI matters)

Also: should we (can we?) remove the /en and /fr prefixes from uri's?

See updated designs in Figma. There is a new "Back" button above the page title that returns the user to the previous question. (Can this just hook into the browser history?)

CRA had some really cool logging stuff. Let's use it.

Once PR #39 is merged, will need to enter final content for results includes:

• CERB
• EI Regular
• EI Sickness
• EI Workshare
• CCB
• Mortgage deferral
• Rent help
• Student loan
• RRIF

See new designs in Figma. The Start Over link on Q pages gets moved down underneath the Next button. This is functionally the same.

• cerb
• ei_regular_cerb
• ei_regular
• ei_sickness_cerb
• ei_sickness
• ei_workshare

Update content per figma design.

When updating M3a, make sure to update routing in the Controller - M3b is being removed

• ccb_payment (no changes)
• gst_credit
• mortgage_deferral
• rent_help
• rrif
• student_loan

• Import WxT? (possible issues with stylesheet collisions - particularly with the css resets)
• or implement mandatory elements with Tailwind.

We need to remove the page asking the question about the GST Credit and always display it to users.

To help identify what build is currently deployed, display some sort of build identifier. We've done this in the past with a git hash.

This can either be displayed in the footer, or in a hidden comment in the page layout.

Was a quick cut, probably some ways to make more readable/testable.

Let's setup some conveniences for our testers:

• Link/button to clear the session (building on #56 which adds a /clear route, let's make that link accessible for test facilitators - do we just tell them about the route? or add a link to the footer?)
• Save session data at the end (do we just save automatically when they hit the results screen? Do we add a button for the facilitator to save the session? Make sure we save the session id, so we can query the path they took in the logs)

modify the "preamble" (Why did I call it that it's post not pre...), so that we don't have to have css and html in the localization file.

• Personal
• Confirmation

In app:

in figma: