cellrox / devns-patches Goto Github PK

When you create a new device namespace (via clone), you assign dev_ns->pid_ns in the create_dev_ns function by getting a reference to the pid namespace associated with tsk. This is actually the pid namespace of the task being cloned, and it gets replaced further up the call chain (in create_namespaces).

Additionally, you re-assign dev_ns->pid_ns (without taking a reference) in create_namepaces (kernel/nsproxy.c). This assignment leaks a reference to the original task's pid namespace, and leaves you one-reference short on the pid namespace you want.

line 745: the pr_info statement is missing a parameter - I believe you intended to pass the "addr" variable

Without CONFIG_DEV_NS the current_dev_ns() function returns NULL. This triggers a BUG_ON in drivers/staging/android/logger.c:459

The same logic would eventually trigger a BUG_ON in logger_open() as well.

Perhaps a careful look at where current_dev_ns is used is in order. If there are assumptions about pointer validity then perhaps assigning init_dev_ns to NULL is not the right way to go.

Also, the construction of current_dev_ns() without CONFIG_DEV_NS set is quite awkward. It comes out to something like: &(*(struct dev_namespace *)NULL)

If the kernel config does not contain CONFIG_DEV_NS, then it will not build.

Quick list of issues:

1. You need to define put_dev_ns() (and probably get_dev_ns)
2. get_dev_ns_tag needs a return type (presumably void)
3. need ifdef CONFIG_DEV_NS around all invocations of is_active_dev_ns() or define it in linux/dev_namespace.h as a static inline returning 1.